From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EA415290A for ; Thu, 17 Nov 2022 20:31:33 +0000 (UTC) Received: by mail-wr1-f50.google.com with SMTP id i12so1906238wrb.0 for ; Thu, 17 Nov 2022 12:31:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GgNvfOAXHjmuiPC01RZ20qna6kcHy47I8cgRmcZ99PE=; b=GPWC5/m7Uw7YC2i7MtfzvNQKjQj92U/QyivvzOTm8wW2FUYg3zYCbAOehzWCJfG2vN 2PG3m0DjUtTAOH8qCf97ydoFXAqbEfo89LgSJ/GIkW7vz3vY4iDW5utlq56CTQ7O8JUx rs98pW7mgYcrl1AJZWJJjAfKWUrtnNX8o1aNj+Bond+O3mo32NnqFpKEt61K7xeXiDmO Cp5ljx/Sjv2W4s9gLRmQ7ngyYLzktfXZufWEmMlIgzsaa/DrDu8i8n48qFkW5d81mnTX KV+sqb8AQYl+absX7x0b0rwu509eKG8ZKFFE54KR+ioE3gc0jWf+Kw9xxK3jwqrqFBLo H6qA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GgNvfOAXHjmuiPC01RZ20qna6kcHy47I8cgRmcZ99PE=; b=0q4MOTwmKArRiyfXlLAPLdF16HRT4jIjVsb84i/ZGi8kZm499SHKJ0NsYqV0/35Qq7 69LwqQiDhWojIw+qacKw336qw9Y/aJgXaIMIkR9dK65pnQOv0HBaDjFYnYUTLe4dx4X3 neKbf6MKPVehdMRem6aYteXq1EKQlaogDdtfcwD6IwGwR36AGC6CmFlBGkguXjpHYoii 70kgbmAE3/qU0cUGQMqCXHyWfE3R1sQSsiXvIU64GXWBHvMy4taKbuqN7v16DOTnDIdi CMddEyeAZbYN+uZoZUoSftme+TxLRXPysgYoIqds9Ob+JH8U6H6KECEvfBVnT3cd2Ou0 ralA== X-Gm-Message-State: ANoB5pn8JBnacxTenNucxiUPMVw5f9roJM/1310OW8zTkOs3m850woKM tqUc/recZdD2Ex4Lj+0EZTE= X-Google-Smtp-Source: AA0mqf7RJtH6v9Zfz+C1oJd50K9FMeHOnHakHTlbrjVBkVMLt5/yV5A7SZvyhJITGCArwqpsEss0YQ== X-Received: by 2002:a05:6000:1d97:b0:241:b99a:949f with SMTP id bk23-20020a0560001d9700b00241b99a949fmr2041636wrb.599.1668717092011; Thu, 17 Nov 2022 12:31:32 -0800 (PST) Received: from jernej-laptop.localnet (89-212-118-115.static.t-2.net. [89.212.118.115]) by smtp.gmail.com with ESMTPSA id e18-20020adfdbd2000000b0022da3977ec5sm1795243wrj.113.2022.11.17.12.31.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Nov 2022 12:31:31 -0800 (PST) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: mchehab@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, wens@csie.org, samuel@sholland.org, Krzysztof Kozlowski Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] media: dt-bindings: allwinner: video-engine: Fix number of IOMMU channels Date: Thu, 17 Nov 2022 21:31:30 +0100 Message-ID: <3385828.QJadu78ljV@jernej-laptop> In-Reply-To: References: <20221117060704.367945-1-jernej.skrabec@gmail.com> <20221117060704.367945-2-jernej.skrabec@gmail.com> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Dne =C4=8Detrtek, 17. november 2022 ob 14:13:00 CET je Krzysztof Kozlowski= =20 napisal(a): > On 17/11/2022 07:07, Jernej Skrabec wrote: > > Cedrus (video engine) on Allwinner H6 actually uses two IOMMU channel, > > not just one. However, Cedrus on SoCs like D1 only uses one channel. > >=20 > > Allow up to 2 IOMMU channels. > >=20 > > Fixes: 62a8ccf3a248 ("arm64: dts: allwinner: h6: Fix Cedrus IOMMU usage= ") > > Signed-off-by: Jernej Skrabec > > --- > >=20 > > .../bindings/media/allwinner,sun4i-a10-video-engine.yaml | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > >=20 > > diff --git > > a/Documentation/devicetree/bindings/media/allwinner,sun4i-a10-video-eng= in > > e.yaml > > b/Documentation/devicetree/bindings/media/allwinner,sun4i-a10-video-eng= in > > e.yaml index 541325f900a1..6446004d59d9 100644 > > --- > > a/Documentation/devicetree/bindings/media/allwinner,sun4i-a10-video-eng= in > > e.yaml +++ > > b/Documentation/devicetree/bindings/media/allwinner,sun4i-a10-video-eng= in > > e.yaml>=20 > > @@ -55,7 +55,8 @@ properties: > > description: Phandle to the device SRAM > > =20 > > iommus: > > - maxItems: 1 > > + minItems: 1 > > + maxItems: 2 >=20 > You have several compatibles in the file, so usually this is further > constrained per each variant in allOf:if:then:. Usually, yes. But this whole binding would need update. It has a few option= al=20 properties and none of them is tied to any compatible. Additionally, if I d= o=20 it as you suggest, then Robs automatic test will report the issue, because= =20 existing H6 based boards won't match this binding anymore. I would much rat= her=20 send follow up patch which clears up all optional properties. Best regards, Jernej