From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 914063C3A for ; Sun, 26 Mar 2023 18:17:52 +0000 (UTC) Received: by mail-ed1-f44.google.com with SMTP id i5so27268856eda.0 for ; Sun, 26 Mar 2023 11:17:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679854671; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FnTsQUm6HhjATm02ksR3wp/Ety48QzTJBZ9lksbtOVs=; b=Hw4H00UoiUrwTuhkIy4J+TCrs2QhEwUE7rii1JKt13al9XnNSOvNrX3bQayx1liDbE eheNALQBp83JQS/e9mxrLYAwh+Tv4/rLHPWdJ47tZfc4rMdlHyqpmyCx8lu0zYcmYqk4 Qbg581Ljc8pPoe79vk2wHR8x8TJJoOWkG6A3+kzDbl4WG5Yx6pjUnAPOOySNm1sBZfQe drOG5wWrgVaFt+J/0btk/BKu+AGxJIlmMzztYSgU6zbn34YRnN7/UbZVZ1FWpoxWEe6C fqvLeQBnnhsbA1Itl5m2n7DVfL2e/OHinXzN073EO4YJLITmDgfB2rH7vv4b1EFwP62j EIEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679854671; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FnTsQUm6HhjATm02ksR3wp/Ety48QzTJBZ9lksbtOVs=; b=dQK2n4lf4C6W81/WyQrE3hPxxyAsOryzgrnR+tesoGfFirEXLYaZj7qHrBbrcP0ksV +6NUoLv0ECt14nxhXWxtWeQdx75FpoS9ViTyqtPZtfmWiPKoqYcc9fSUjRZsPXjaWPCC ZvFtOqkGmkRfupNfSoRCfQtknVEwN6nojHdEmYANbZiAFs92w/1H+gO6CpQ8QRozClo5 gMymWx+hA0cLqLcgZdr9txoD7p93yzofpt7AkQ8x+56QiSAS3vUJUMryL2xI374r1Uh2 ExWcPsmTWc2WuQRCVLDB9+Cnzsog24vGtFMX/rcNFH2YOFjFoVpXp/sv7RIIau7+eEAO J/kg== X-Gm-Message-State: AAQBX9d9u+TmFVYs+TzsnshJ38ccgapit8RrF1b3FSRIz5wUUpn6Vq6f hHiJNFdXAiynFU/COALxC10= X-Google-Smtp-Source: AKy350bzwX2Okw452MLlLN3trK1J0tQJbXMqGx9csXq3pD9R5t41CwxzDxLp3qD2Y0tuUnKfA9LL3A== X-Received: by 2002:a17:906:5a94:b0:933:15c0:6e05 with SMTP id l20-20020a1709065a9400b0093315c06e05mr9470325ejq.7.1679854670654; Sun, 26 Mar 2023 11:17:50 -0700 (PDT) Received: from kista.localnet (82-149-1-233.dynamic.telemach.net. [82.149.1.233]) by smtp.gmail.com with ESMTPSA id q27-20020a50aa9b000000b004af73333d6esm13720731edc.53.2023.03.26.11.17.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Mar 2023 11:17:49 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Mauro Carvalho Chehab , Chen-Yu Tsai , Samuel Holland , Uwe =?ISO-8859-1?Q?Kleine=2DK=F6nig?= Cc: linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, kernel@pengutronix.de Subject: Re: [PATCH 082/117] media: sun8i-di: Convert to platform remove callback returning void Date: Sun, 26 Mar 2023 20:17:48 +0200 Message-ID: <3486523.iIbC2pHGDl@kista> In-Reply-To: <20230326143224.572654-85-u.kleine-koenig@pengutronix.de> References: <20230326143224.572654-1-u.kleine-koenig@pengutronix.de> <20230326143224.572654-85-u.kleine-koenig@pengutronix.de> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" Dne nedelja, 26. marec 2023 ob 16:31:49 CEST je Uwe Kleine-K=F6nig napisal(= a): > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is (mostly) ignored > and this typically results in resource leaks. To improve here there is a > quest to make the remove callback return void. In the first step of this > quest all drivers are converted to .remove_new() which already returns > void. >=20 > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. >=20 > Signed-off-by: Uwe Kleine-K=F6nig Acked-by: Jernej Skrabec Best regards, Jernej