From: "Jernej Škrabec" <jernej.skrabec@gmail.com>
To: Jagan Teki <jagan@amarulasolutions.com>,
Andre Przywara <andre.przywara@arm.com>
Cc: Marek Vasut <marex@denx.de>, Sam Edwards <cfsworks@gmail.com>,
Samuel Holland <samuel@sholland.org>,
Icenowy Zheng <uwu@icenowy.me>,
u-boot@lists.denx.de, linux-sunxi@lists.linux.dev
Subject: Re: [PATCH 3/3] sunxi: Kconfig: rework PHY_USB_SUN4I selection
Date: Fri, 09 Jun 2023 22:42:14 +0200 [thread overview]
Message-ID: <3504459.iIbC2pHGDl@jernej-laptop> (raw)
In-Reply-To: <20230609105621.1410483-4-andre.przywara@arm.com>
Dne petek, 09. junij 2023 ob 12:56:21 CEST je Andre Przywara napisal(a):
> At the moment we use "select" in each Allwinner SoC's Kconfig section to
> include the USB PHY driver in the build. This means it cannot be disabled
> via Kconfig, although USB is not really a strictly required core
> functionality, and a particular board might not even include USB ports.
>
> Rework the Kconfig part by removing the "select" lines for each SoC's
> section, and instead letting it default to "y" in the PHY driver section
> itself. We use "depends on !" to exclude the few SoCs we don't support
> (yet). The Allwinner V3s does not enable USB (PHY) support at the moment,
> even though it should work: let the PHY default to "n" to keep the
> current behaviour.
>
> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
I stumbled on this issue before, but it didn't bother me enough to actually
do something about that. Thanks!
Reviewed-by: Jernej Skrabec <jernej.skrabec@gmail.com>
Best regards,
Jernej
prev parent reply other threads:[~2023-06-09 20:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-09 10:56 [PATCH 0/3] phy: sun4i: Allwinner F1C100s support and cleanup Andre Przywara
2023-06-09 10:56 ` [PATCH 1/3] phy: sun4i-usb: Fix of_xlate() argument check Andre Przywara
2023-06-09 20:40 ` Jernej Škrabec
2023-06-09 10:56 ` [PATCH 2/3] phy: sun4i-usb: add Allwinner F1C100s support Andre Przywara
2023-06-09 20:40 ` Jernej Škrabec
2023-06-09 10:56 ` [PATCH 3/3] sunxi: Kconfig: rework PHY_USB_SUN4I selection Andre Przywara
2023-06-09 20:42 ` Jernej Škrabec [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3504459.iIbC2pHGDl@jernej-laptop \
--to=jernej.skrabec@gmail.com \
--cc=andre.przywara@arm.com \
--cc=cfsworks@gmail.com \
--cc=jagan@amarulasolutions.com \
--cc=linux-sunxi@lists.linux.dev \
--cc=marex@denx.de \
--cc=samuel@sholland.org \
--cc=u-boot@lists.denx.de \
--cc=uwu@icenowy.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox