From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 752734C74 for ; Thu, 25 Aug 2022 21:34:28 +0000 (UTC) Received: by mail-wr1-f46.google.com with SMTP id u5so18353404wrt.11 for ; Thu, 25 Aug 2022 14:34:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=vkI7j/ybscYbFRd8z0ozi0Hl64XiOOmBLsjf3EBHwN0=; b=AzUrQhd7gjCn9B5gg5Fzzp909mgOT7in/GTCOa43Oq8F2ADQF2/cUTj2DciK1myF+2 OFfdLxqbfVj0DgOa+iPD/g3Qjrd3oFPzrqMb0dsUBvI1YxqMikW7DV6KflDzIoLGxaF2 LQmDWSdkeTRk7uIu+MEhVLz2MlMwEjTuxGs3QPJTaDK5EkTZYFhxJ2fPERhilErN5sUT iatRgY63/M5emjQI8Y0usejKpU+NYYDmxLYouEd27eB3M/mMLknzvGn83AE+lFvp3P27 f36/AQ3gWDsBB9gCbPE/9jWu6W4oLhZODI2nJPh+fdc332B79F9aooHZY+TFu+sL85nf dpTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=vkI7j/ybscYbFRd8z0ozi0Hl64XiOOmBLsjf3EBHwN0=; b=7IGzFGL3KK8OizfuqKgXlSfX1GpTp1tucXdL7DN66a7mk3aWRDVT+qzzxFJV45utrS dac8Ucl0D3iVPDH1CI75dPNWiuzuIvmkPlUvSNssAnfxGgI5R2WvMoKpigM5Zha3nANJ ytIQDVtqE69krX8zRaAZNVeuBct8h1/GC4gqt5p4Bffn0Zf42incyGnLL5T7wkZJ/hqg rjLLOO3yVxL3aaVLQ8ogiP7DOTuV4e98lSDLCLvRjXcAPLn6yN3N1JfJu4aAjQfUkUtS i2wnVOLtWKOdYWceLx70NFiIF1Q80X5Kwq5//4jWP+WS88D7z6hCNMTP51EtvBSd/6/F hlLQ== X-Gm-Message-State: ACgBeo3aCWDarvl+atwapQ9+Z/mv5X+tMLmeALuXy1xq9BFsOLW5ISBj MVG6ZpwqwUZf8do/mmpx8fY= X-Google-Smtp-Source: AA6agR5tcJzT/e7p2SOGm8CTPB07sBJctMX85e0eAMx5SoKKJFF38Q2F4xb6D3PqMa00NCibDLvLfg== X-Received: by 2002:adf:f001:0:b0:225:3a99:3938 with SMTP id j1-20020adff001000000b002253a993938mr3199074wro.111.1661463266826; Thu, 25 Aug 2022 14:34:26 -0700 (PDT) Received: from kista.localnet (82-149-1-172.dynamic.telemach.net. [82.149.1.172]) by smtp.gmail.com with ESMTPSA id b3-20020a5d40c3000000b0022533c4fa48sm258839wrq.55.2022.08.25.14.34.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Aug 2022 14:34:26 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: linux-kernel@vger.kernel.org, Wolfram Sang Cc: Wolfram Sang , Kishon Vijay Abraham I , Vinod Koul , Chen-Yu Tsai , Samuel Holland , linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev Subject: Re: [PATCH] phy: move from strlcpy with unused retval to strscpy Date: Thu, 25 Aug 2022 23:34:25 +0200 Message-ID: <3506634.R56niFO833@kista> In-Reply-To: <20220818210056.7205-1-wsa+renesas@sang-engineering.com> References: <20220818210056.7205-1-wsa+renesas@sang-engineering.com> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Dne =C4=8Detrtek, 18. avgust 2022 ob 23:00:56 CEST je Wolfram Sang napisal(= a): > Follow the advice of the below link and prefer 'strscpy' in this > subsystem. Conversion is 1:1 because the return value is not used. > Generated by a coccinelle script. >=20 > Link: > https://lore.kernel.org/r/CAHk-=3DwgfRnXz0W3D37d01q3JFkr_i_uTL=3DV6A6G1oU= Zcprmk > nw@mail.gmail.com/ Signed-off-by: Wolfram Sang > Acked-by: Jernej Skrabec Best regards, Jernej > --- > drivers/phy/allwinner/phy-sun4i-usb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/phy/allwinner/phy-sun4i-usb.c > b/drivers/phy/allwinner/phy-sun4i-usb.c index d5f3b42eb8ce..3a3831f6059a > 100644 > --- a/drivers/phy/allwinner/phy-sun4i-usb.c > +++ b/drivers/phy/allwinner/phy-sun4i-usb.c > @@ -768,7 +768,7 @@ static int sun4i_usb_phy_probe(struct platform_device > *pdev) if (data->cfg->dedicated_clocks) > snprintf(name, sizeof(name), "usb%d_phy",=20 i); > else > - strlcpy(name, "usb_phy", sizeof(name)); > + strscpy(name, "usb_phy", sizeof(name)); >=20 > phy->clk =3D devm_clk_get(dev, name); > if (IS_ERR(phy->clk)) { > -- > 2.35.1