From: Andrew Lunn <andrew@lunn.ch>
To: Jinjie Ruan <ruanjinjie@huawei.com>
Cc: woojung.huh@microchip.com, f.fainelli@gmail.com,
olteanv@gmail.com, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, linus.walleij@linaro.org,
alsi@bang-olufsen.dk, justin.chen@broadcom.com,
sebastian.hesselbarth@gmail.com, alexandre.torgue@foss.st.com,
joabreu@synopsys.com, wens@csie.org, jernej.skrabec@gmail.com,
samuel@sholland.org, mcoquelin.stm32@gmail.com,
hkallweit1@gmail.com, linux@armlinux.org.uk,
ansuelsmth@gmail.com, UNGLinuxDriver@microchip.com,
netdev@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, krzk@kernel.org, jic23@kernel.org
Subject: Re: [PATCH net-next v3 08/13] net: mdio: mux-mmioreg: Simplified with dev_err_probe()
Date: Thu, 29 Aug 2024 14:53:10 +0200 [thread overview]
Message-ID: <3e47f3ee-bf44-46f2-a080-5dd9ac559cbc@lunn.ch> (raw)
In-Reply-To: <20240829063118.67453-9-ruanjinjie@huawei.com>
> s->iosize = resource_size(&res);
> if (s->iosize != sizeof(uint8_t) &&
> s->iosize != sizeof(uint16_t) &&
> s->iosize != sizeof(uint32_t)) {
> - dev_err(&pdev->dev, "only 8/16/32-bit registers are supported\n");
> - return -EINVAL;
> + return dev_err_probe(&pdev->dev, -EINVAL,
> + "only 8/16/32-bit registers are supported\n");
Please think about this change. Why is it wrong?
Andrew
next prev parent reply other threads:[~2024-08-29 12:53 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-29 6:31 [PATCH net-next v3 00/13] net: Simplified with scoped function Jinjie Ruan
2024-08-29 6:31 ` [PATCH net-next v3 01/13] net: stmmac: dwmac-sun8i: Use for_each_child_of_node_scoped() Jinjie Ruan
2024-08-29 12:46 ` Andrew Lunn
2024-08-29 6:31 ` [PATCH net-next v3 02/13] net: stmmac: dwmac-sun8i: Use __free() to simplify code Jinjie Ruan
2024-08-29 6:31 ` [PATCH net-next v3 03/13] net: dsa: realtek: Use for_each_child_of_node_scoped() Jinjie Ruan
2024-08-29 12:47 ` Andrew Lunn
2024-08-29 6:31 ` [PATCH net-next v3 04/13] net: dsa: realtek: Use __free() to simplify code Jinjie Ruan
2024-08-29 6:31 ` [PATCH net-next v3 05/13] net: phy: Fix missing of_node_put() for leds Jinjie Ruan
2024-08-29 12:50 ` Andrew Lunn
2024-08-29 6:31 ` [PATCH net-next v3 06/13] net: phy: Use for_each_available_child_of_node_scoped() Jinjie Ruan
2024-08-29 12:50 ` Andrew Lunn
2024-08-29 6:31 ` [PATCH net-next v3 07/13] net: mdio: mux-mmioreg: Simplified with scoped function Jinjie Ruan
2024-08-29 12:51 ` Andrew Lunn
2024-08-29 6:31 ` [PATCH net-next v3 08/13] net: mdio: mux-mmioreg: Simplified with dev_err_probe() Jinjie Ruan
2024-08-29 12:53 ` Andrew Lunn [this message]
2024-08-29 6:31 ` [PATCH net-next v3 09/13] net: mv643xx_eth: Simplify with scoped for each OF child loop Jinjie Ruan
2024-08-29 12:53 ` Andrew Lunn
2024-08-29 6:31 ` [PATCH net-next v3 10/13] net: dsa: microchip: Use scoped function to simplfy code Jinjie Ruan
2024-08-29 12:54 ` Andrew Lunn
2024-08-29 6:31 ` [PATCH net-next v3 11/13] net: dsa: microchip: Use __free() " Jinjie Ruan
2024-08-29 6:31 ` [PATCH net-next v3 12/13] net: bcmasp: Simplify with scoped for each OF child loop Jinjie Ruan
2024-08-29 12:54 ` Andrew Lunn
2024-08-29 20:54 ` Justin Chen
2024-08-29 22:16 ` Florian Fainelli
2024-08-29 6:31 ` [PATCH net-next v3 13/13] net: bcmasp: Simplify with __free() Jinjie Ruan
2024-08-29 12:43 ` [PATCH net-next v3 00/13] net: Simplified with scoped function Andrew Lunn
2024-08-30 2:03 ` Jinjie Ruan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3e47f3ee-bf44-46f2-a080-5dd9ac559cbc@lunn.ch \
--to=andrew@lunn.ch \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.torgue@foss.st.com \
--cc=alsi@bang-olufsen.dk \
--cc=ansuelsmth@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=jernej.skrabec@gmail.com \
--cc=jic23@kernel.org \
--cc=joabreu@synopsys.com \
--cc=justin.chen@broadcom.com \
--cc=krzk@kernel.org \
--cc=kuba@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux-sunxi@lists.linux.dev \
--cc=linux@armlinux.org.uk \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=ruanjinjie@huawei.com \
--cc=samuel@sholland.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=wens@csie.org \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox