From: Stephen Boyd <sboyd@kernel.org>
To: Maxime Ripard <maxime@cerno.tech>,
Michael Turquette <mturquette@baylibre.com>
Cc: linux-clk@vger.kernel.org, "Maxime Ripard" <maxime@cerno.tech>,
"Abel Vesa" <abelvesa@kernel.org>,
"Alessandro Zummo" <a.zummo@towertech.it>,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
"Andreas Färber" <afaerber@suse.de>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"Baolin Wang" <baolin.wang@linux.alibaba.com>,
"Charles Keepax" <ckeepax@opensource.cirrus.com>,
"Chen-Yu Tsai" <wens@csie.org>,
"Chen-Yu Tsai" <wenst@chromium.org>,
"Chunyan Zhang" <zhang.lyra@gmail.com>,
"Claudiu Beznea" <claudiu.beznea@microchip.com>,
"Daniel Vetter" <daniel@ffwll.ch>,
"David Airlie" <airlied@gmail.com>,
"David Lechner" <david@lechnology.com>,
"Dinh Nguyen" <dinguyen@kernel.org>,
"Fabio Estevam" <festevam@gmail.com>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"Jaroslav Kysela" <perex@perex.cz>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
"Jonathan Hunter" <jonathanh@nvidia.com>,
"Kishon Vijay Abraham I" <kishon@kernel.org>,
"Liam Girdw ood" <lgirdwood@gmail.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Luca Ceresoli" <luca.ceresoli@bootlin.com>,
"Manivannan Sadhasivam" <mani@kernel.org>,
"Mark Brown" <broonie@kernel.org>,
"Markus Schneider-Pargmann" <msp@baylibre.com>,
"Max Filippov" <jcmvbkbc@gmail.com>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
"Mikko Perttunen" <mperttunen@nvidia.com>,
"Miles Chen" <miles.chen@mediatek.com>,
"Nicolas Ferre" <nicolas.ferre@microchip.com>,
"Orson Zhai" <orsonzhai@gmail.com>,
"Paul Cercueil" <paul@crapouillou.net>,
"Peng Fan" <peng.fan@nxp.com>,
"Peter De Schrijver" <pdeschrijver@nvidia.com>,
"Prashant Gaikwad" <pgaikwad@nvidia.com>,
"Richard Fitzgerald" <rf@opensource.cirrus.com>,
"Samuel Holland" <samuel@sholland.org>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Sekhar Nori" <nsekhar@ti.com>, "Shawn Guo" <shawnguo@kernel.org>,
"Takashi Iwai" <tiwai@suse.com>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Ulf Hansson" <ulf.hansson@linaro.org>,
"Vinod Koul" <vkoul@kernel.org>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v4 00/68] clk: Make determine_rate mandatory for muxes
Date: Thu, 08 Jun 2023 18:49:28 -0700 [thread overview]
Message-ID: <431d1ae3993d1fc78decbcd065442f29.sboyd@kernel.org> (raw)
In-Reply-To: <20221018-clk-range-checks-fixes-v4-0-971d5077e7d2@cerno.tech>
Quoting Maxime Ripard (2023-05-05 04:25:02)
> Hi,
>
> This is a follow-up to a previous series that was printing a warning
> when a mux has a set_parent implementation but is missing
> determine_rate().
>
> The rationale is that set_parent() is very likely to be useful when
> changing the rate, but it's determine_rate() that takes the parenting
> decision. If we're missing it, then the current parent is always going
> to be used, and thus set_parent() will not be used. The only exception
> being a direct call to clk_set_parent(), but those are fairly rare
> compared to clk_set_rate().
>
> Stephen then asked to promote the warning to an error, and to fix up all
> the muxes that are in that situation first. So here it is :)
>
I've applied this to clk-next after squashing in an export. Thanks for
taking this on.
I'll have to monitor for wreckage with any in-flight drivers. I suspect
I'll have to take out the last commit, but maybe we can just let those
in-flight drivers get fixed up later.
prev parent reply other threads:[~2023-06-09 1:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-05 11:25 [PATCH v4 00/68] clk: Make determine_rate mandatory for muxes Maxime Ripard
2023-05-05 11:25 ` [PATCH v4 03/68] clk: Move no reparent case into a separate function Maxime Ripard
2023-06-13 11:15 ` Marek Szyprowski
2023-06-13 12:15 ` Marek Szyprowski
2023-06-13 12:29 ` Maxime Ripard
2023-05-05 11:25 ` [PATCH v4 04/68] clk: Introduce clk_hw_determine_rate_no_reparent() Maxime Ripard
2023-05-05 17:15 ` kernel test robot
2023-05-05 11:25 ` [PATCH v4 45/68] rtc: sun6i: Add a determine_rate hook Maxime Ripard
2023-05-05 18:46 ` Jernej Škrabec
2023-05-05 11:26 ` [PATCH v4 68/68] clk: Forbid to register a mux without determine_rate Maxime Ripard
2023-06-09 1:49 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=431d1ae3993d1fc78decbcd065442f29.sboyd@kernel.org \
--to=sboyd@kernel.org \
--cc=a.zummo@towertech.it \
--cc=abelvesa@kernel.org \
--cc=afaerber@suse.de \
--cc=airlied@gmail.com \
--cc=alexandre.belloni@bootlin.com \
--cc=alexandre.torgue@foss.st.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=baolin.wang@linux.alibaba.com \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=claudiu.beznea@microchip.com \
--cc=daniel@ffwll.ch \
--cc=david@lechnology.com \
--cc=dinguyen@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=festevam@gmail.com \
--cc=geert+renesas@glider.be \
--cc=jcmvbkbc@gmail.com \
--cc=jernej.skrabec@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=kishon@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=luca.ceresoli@bootlin.com \
--cc=mani@kernel.org \
--cc=maxime@cerno.tech \
--cc=mcoquelin.stm32@gmail.com \
--cc=miles.chen@mediatek.com \
--cc=mperttunen@nvidia.com \
--cc=msp@baylibre.com \
--cc=mturquette@baylibre.com \
--cc=nicolas.ferre@microchip.com \
--cc=nsekhar@ti.com \
--cc=orsonzhai@gmail.com \
--cc=paul@crapouillou.net \
--cc=pdeschrijver@nvidia.com \
--cc=peng.fan@nxp.com \
--cc=perex@perex.cz \
--cc=pgaikwad@nvidia.com \
--cc=rf@opensource.cirrus.com \
--cc=s.hauer@pengutronix.de \
--cc=samuel@sholland.org \
--cc=shawnguo@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=tiwai@suse.com \
--cc=ulf.hansson@linaro.org \
--cc=vkoul@kernel.org \
--cc=wens@csie.org \
--cc=wenst@chromium.org \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox