From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6AC36139E for ; Tue, 15 Nov 2022 15:00:58 +0000 (UTC) Received: by mail-lf1-f53.google.com with SMTP id s8so7689168lfc.8 for ; Tue, 15 Nov 2022 07:00:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=F4jUAwmhTQdTrwQKeKo2XqBWyE1rzqyVY9EqrXd1rb4=; b=yWlfIKfy1RjmW4cqzHEQYZ0P6H3bTMh70oUTOEi7dAkF6t8/GEcAvUZrYY7ugZZsqp /Hdlt3APkEkt28div8SyumBc1+KVCvgc+INVTlcp1s0IjvJP1g3lG8iXVGjywGKjifnQ aBxGT/fImyqWcbDHuZo0DLe7CU3jeOKDALA+4i5GjRScq2+6OkW7Bae3IW6l4ALmAWyJ k8ItIm9bclRbK98aOf6+tZRbqG+vjjwR2z5J/m1NugPrip33q9SXyHy7JM2XyUf1ivkS 4ygWO41BOOQG7sz54oV2TzccEwfKTVfRC/qbv8duc9T/J5XeHLurKqwVbKDi+C4ljgf1 13Ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=F4jUAwmhTQdTrwQKeKo2XqBWyE1rzqyVY9EqrXd1rb4=; b=NHA3H6xRW63R3UkyI3jOpzwM0KCHX/dEMN7/T+wGRsjJ6AOMxkK3JbDg58d7uXwJvZ UVnD91tAzUFSQrDoSmAt0+DSRez0XD62eATFNwj32GIOjn+SyXUWBLXR4wVZSuYtsZml +skzHYVkmW7ZhOka/qN3xhm+rDtedgHV+cRKpmW2S8WKGa+9rX6zFQVua3mhzYCHBJvz AYr1lxgBvWFCHPhf3dE+xWQXxLc0e7DUcbivMQOIBqtx5kxA5t/YHBJ4Xb2lHHhabO1x EW/5xRa3wso8ryu/iyR7afV1K3iff1G6ZR0GcDjUVxAv9xWiHBbZBr/aJevriJqhoTTM Duww== X-Gm-Message-State: ANoB5pmfFZBIVfc3eSWTILcdEeUREV/6ORdK/mahuoin2C9zzVbvVJI/ 8dewcAdJ1BQWrvwQJfRPAc2ggw== X-Google-Smtp-Source: AA0mqf7YV/RWxvpJd+exJ8ozFBpdV0AmoKBtjMSdoMFabRmcv88VA/ScE0Y/rh2lP/33+6Vl6LgfIg== X-Received: by 2002:ac2:5396:0:b0:4a4:6ee3:f57b with SMTP id g22-20020ac25396000000b004a46ee3f57bmr5439911lfh.17.1668524456417; Tue, 15 Nov 2022 07:00:56 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id y29-20020a19641d000000b004a22599c4ddsm2234896lfb.268.2022.11.15.07.00.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 15 Nov 2022 07:00:55 -0800 (PST) Message-ID: <4516dcfb-b928-d454-18a6-bd725f39cc24@linaro.org> Date: Tue, 15 Nov 2022 16:00:54 +0100 Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v3 03/11] phy: sun4i-usb: add support for the USB PHY on F1C100s SoC Content-Language: en-US To: Andre Przywara , Vinod Koul Cc: =?UTF-8?Q?Jernej_=c5=a0krabec?= , Chen-Yu Tsai , Samuel Holland , Rob Herring , Krzysztof Kozlowski , Greg Kroah-Hartman , Icenowy Zheng , soc@kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-phy@lists.infradead.org, linux-usb@vger.kernel.org References: <20221106154826.6687-1-andre.przywara@arm.com> <20221106154826.6687-4-andre.przywara@arm.com> <4438485.LvFx2qVVIh@jernej-laptop> <52920a00-8e29-f7f4-0cbd-ceb638ded970@linaro.org> <20221115104426.20728ba5@donnerap.cambridge.arm.com> From: Krzysztof Kozlowski In-Reply-To: <20221115104426.20728ba5@donnerap.cambridge.arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 15/11/2022 11:44, Andre Przywara wrote: > On Tue, 15 Nov 2022 11:03:24 +0100 > Krzysztof Kozlowski wrote: > > Hi, > >> On 15/11/2022 07:01, Jernej Škrabec wrote: >>> Dne četrtek, 10. november 2022 ob 08:35:39 CET je Vinod Koul napisal(a): >>>> On 06-11-22, 15:48, Andre Przywara wrote: >>>>> From: Icenowy Zheng >>>>> >>>>> The F1C100s SoC has one USB OTG port connected to a MUSB controller. >>>>> >>>>> Add support for its USB PHY. >>>> >>>> This does not apply for me, please rebase and resend >>>> >>>> Also, consider splitting phy patches from this. I dont think there is >>>> any dependency >>> >>> DT patches in this series depend on functionality added here. >>> >> >> DTS always goes separately from driver changes because it is a hardware >> description. Depending on driver means you have potential ABI break, so >> it is already a warning sign. > > We understand that ;-) > What Jernej meant was that the DTS patches at the end depend on patch > 01/10, which adds to the PHY binding doc. I am not sure if Vinod's > suggestion was about splitting off 01/10, 03/10, and 10/10, or just the > two latter which touch the driver. > > I can split off 03/10 and 10/10, rebased on top of linux-phy.git/next, and > send that to Vinod. > Then I would keep 01/10 in a respin of this series here, to satisfy the > dependency of the later DTS patches, and Vinod can pick that one patch from > there? There is no hard dependency of DTS on bindings. You can split these (and some maintainers prefer that way) and in DTS patches just provide the link to the bindings, saying it is in progress. The bindings should be however kept with driver changes as it goes the same way. Best regards, Krzysztof