From: "Jernej Škrabec" <jernej.skrabec@gmail.com>
To: Jagan Teki <jagan@amarulasolutions.com>,
Andre Przywara <andre.przywara@arm.com>
Cc: Samuel Holland <samuel@sholland.org>,
Tom Rini <trini@konsulko.com>, Simon Glass <sjg@chromium.org>,
Hans de Goede <hdegoede@redhat.com>,
Olliver Schinagl <oliver@schinagl.nl>,
Iain Paton <ipaton0@gmail.com>,
Marcus Cooper <codekipper@gmail.com>,
Stefan Mavrodiev <stefan@olimex.com>,
Paul Kocialkowski <contact@paulk.fr>,
Chen-Yu Tsai <wens@csie.org>, Maxime Ripard <mripard@kernel.org>,
Ian Campbell <ijc@hellion.org.uk>, Adam Sampson <ats@offog.org>,
Zoltan Herpai <wigyori@uid0.hu>,
Siarhei Siamashka <siarhei.siamashka@gmail.com>,
VishnuPatekar <vishnupatekar0510@gmail.com>,
Rask Ingemann Lambertsen <rask@formelder.dk>,
Aleksei Mamlin <mamlinav@gmail.com>,
Peter Korsgaard <peter@korsgaard.com>,
Michal Suchanek <hramrach@gmail.com>,
Icenowy Zheng <icenowy@aosc.xyz>, Stefan Roese <sr@denx.de>,
Phil Han <pengphei@sina.com>,
Quentin Schulz <quentin.schulz@free-electrons.com>,
Jonas Smedegaard <dr@jones.dk>,
Jaehoon Chung <jh80.chung@samsung.com>,
Heiko Schocher <hs@denx.de>,
u-boot@lists.denx.de, linux-sunxi@lists.linux.dev
Subject: Re: [PATCH v2 1/8] power: regulator: Add a driver for the AXP PMIC drivevbus
Date: Thu, 10 Apr 2025 09:04:35 +0200 [thread overview]
Message-ID: <4971028.GXAFRqVoOG@jernej-laptop> (raw)
In-Reply-To: <20250409002036.12212-2-andre.przywara@arm.com>
Dne sreda, 9. april 2025 ob 02:20:29 Srednjeevropski poletni čas je Andre Przywara napisal(a):
> From: Samuel Holland <samuel@sholland.org>
>
> AXP PMICs have a pin which can either report the USB VBUS state, or
> driving a regulator that supplies USB VBUS. Add a regulator driver for
> controlling this pin. The selection between input and output is done via
> the x-powers,drive-vbus-en pin on the PMIC (parent) node.
>
> Signed-off-by: Samuel Holland <samuel@sholland.org>
> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
Would it be less error prone to auto enable Kconfig option when compatible
AXP device is enabled? That way defconfigs could be smaller. Driver is pretty
small anyway.
In any case:
Reviewed-by: Jernej Skrabec <jernej.skrabec@gmail.com>
Best regards,
Jernej
next prev parent reply other threads:[~2025-04-10 7:04 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-09 0:20 [PATCH v2 0/8] sunxi: Control USB pins and supplies via DT regulators Andre Przywara
2025-04-09 0:20 ` [PATCH v2 1/8] power: regulator: Add a driver for the AXP PMIC drivevbus Andre Przywara
2025-04-10 7:04 ` Jernej Škrabec [this message]
2025-04-10 9:23 ` Andre Przywara
2025-04-09 0:20 ` [PATCH v2 2/8] sunxi: Enable PMIC drivevbus regulator support for USB supplies Andre Przywara
2025-04-10 7:08 ` Jernej Škrabec
2025-04-09 0:20 ` [PATCH v2 3/8] phy: sun4i-usb: Control supplies via the regulator uclass Andre Przywara
2025-04-10 7:11 ` Jernej Škrabec
2025-04-09 0:20 ` [PATCH v2 4/8] sunxi: Remove obsolete USBx_VBUS_PIN Kconfig symbols Andre Przywara
2025-04-10 7:12 ` Jernej Škrabec
2025-04-09 0:20 ` [PATCH v2 5/8] gpio: axp: Remove virtual VBUS enable GPIO Andre Przywara
2025-04-10 7:17 ` Jernej Škrabec
2025-04-09 0:20 ` [PATCH v2 6/8] phy: sun4i-usb: Determine VBUS detection pin from devicetree Andre Przywara
2025-04-10 7:18 ` Jernej Škrabec
2025-04-09 0:20 ` [PATCH v2 7/8] phy: sun4i-usb: Determine USB OTG " Andre Przywara
2025-04-10 7:19 ` Jernej Škrabec
2025-04-09 0:20 ` [PATCH v2 8/8] sunxi: Kconfig: Remove obsolete USBx_* pin symbols Andre Przywara
2025-04-10 7:20 ` Jernej Škrabec
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4971028.GXAFRqVoOG@jernej-laptop \
--to=jernej.skrabec@gmail.com \
--cc=andre.przywara@arm.com \
--cc=ats@offog.org \
--cc=codekipper@gmail.com \
--cc=contact@paulk.fr \
--cc=dr@jones.dk \
--cc=hdegoede@redhat.com \
--cc=hramrach@gmail.com \
--cc=hs@denx.de \
--cc=icenowy@aosc.xyz \
--cc=ijc@hellion.org.uk \
--cc=ipaton0@gmail.com \
--cc=jagan@amarulasolutions.com \
--cc=jh80.chung@samsung.com \
--cc=linux-sunxi@lists.linux.dev \
--cc=mamlinav@gmail.com \
--cc=mripard@kernel.org \
--cc=oliver@schinagl.nl \
--cc=pengphei@sina.com \
--cc=peter@korsgaard.com \
--cc=quentin.schulz@free-electrons.com \
--cc=rask@formelder.dk \
--cc=samuel@sholland.org \
--cc=siarhei.siamashka@gmail.com \
--cc=sjg@chromium.org \
--cc=sr@denx.de \
--cc=stefan@olimex.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=vishnupatekar0510@gmail.com \
--cc=wens@csie.org \
--cc=wigyori@uid0.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox