From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8F2741C2C for ; Fri, 1 Jul 2022 13:09:25 +0000 (UTC) Received: from p508fd39e.dip0.t-ipconnect.de ([80.143.211.158] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1o7GOc-0001dK-8y; Fri, 01 Jul 2022 15:09:18 +0200 From: Heiko Stuebner To: Chen-Yu Tsai , Jernej Skrabec , Linus Walleij , linux-arm-kernel@lists.infradead.org Cc: Samuel Holland , Krzysztof Kozlowski , Maxime Ripard , Ondrej Jirman , Rob Herring , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev, Samuel Holland Subject: Re: [PATCH 5/6] pinctrl: sunxi: Make some layout parameters dynamic Date: Fri, 01 Jul 2022 15:09:18 +0200 Message-ID: <5030179.KRxA6XjA2N@phil> In-Reply-To: <20220626021148.56740-6-samuel@sholland.org> References: <20220626021148.56740-1-samuel@sholland.org> <20220626021148.56740-6-samuel@sholland.org> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Am Sonntag, 26. Juni 2022, 04:11:46 CEST schrieb Samuel Holland: > Starting with the D1/D1s/T113 SoC, Allwinner changed the layout of the > pinctrl registers. This new layout widens the drive level field, which > affects the pull register offset and the overall bank size. > > In order to support multiple register layouts, some of the layout > parameters need to be set based on the pinctrl variant. This requires > passing the pinctrl struct pointer to the register/offset calculation > functions. > > Signed-off-by: Samuel Holland On a D1-Nezha Tested-by: Heiko Stuebner Reviewed-by: Heiko Stuebner