From: "Kryštof Černý" <cleverline1mc@gmail.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Samuel Holland <samuel@sholland.org>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH PATCH] arm64: dts: sunxi: nanopi-neo-plus2: Add pio regulators
Date: Sat, 24 Aug 2024 11:08:30 +0200 [thread overview]
Message-ID: <51f28d92-f670-47de-8e2d-53cbecfac081@gmail.com> (raw)
In-Reply-To: <761f18d4-9274-4983-a128-94efb96e1c59@kernel.org>
I am sorry if the message is wrong, this is my first patch ever sent to
the Linux kernel. I have checked the schematic of the board and it
shares the same power line with mmc0, so I assumed I can use the same
regulator. Thanks for your feedback and I would be glad for your further
response.
Dne 24. 08. 24 v 9:40 Krzysztof Kozlowski napsal(a):
> On 24/08/2024 09:09, Kryštof Černý wrote:
>> The board does not have a dedicated regulator for pio and r_pio,
>> but this fixes the kernel warning about dummy regulators being used.
>> Tested on the actual board.
>>
> Judging by commit msg these are not correct regulators. Please do not
> add incorrect hardware description to silence some warnings coming from
> OS. Either you need proper (correct) hardware description or fix the
> problem other way, assuming there is anything to fix in the first place.
>
> Best regards,
> Krzysztof
>
next prev parent reply other threads:[~2024-08-24 9:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-24 7:09 [PATCH PATCH] arm64: dts: sunxi: nanopi-neo-plus2: Add pio regulators Kryštof Černý
2024-08-24 7:40 ` Krzysztof Kozlowski
2024-08-24 9:08 ` Kryštof Černý [this message]
2024-08-24 12:34 ` Chen-Yu Tsai
2024-08-24 14:24 ` Kryštof Černý
2024-08-26 22:44 ` Andre Przywara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51f28d92-f670-47de-8e2d-53cbecfac081@gmail.com \
--to=cleverline1mc@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jernej.skrabec@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=robh@kernel.org \
--cc=samuel@sholland.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox