From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f53.google.com (mail-ed1-f53.google.com [209.85.208.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CCA87A939 for ; Tue, 14 Mar 2023 19:52:22 +0000 (UTC) Received: by mail-ed1-f53.google.com with SMTP id eg48so7486920edb.13 for ; Tue, 14 Mar 2023 12:52:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678823542; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xMc2AnlV82kWeOQMw4Z57Uy8gyinuEGs+efX/3BzdrM=; b=GaBPzv3wgeHg5mdOzdiwOVazLXCDhdCOrdePbsgJDi21f+1qnJM6ELcpmu7tU1rMST cjE8SlnKUyVc4FxAIbKf3kico9yQhyCmf0umFoCZlG8v7KZ0XkFh8PPO3cbZAyTm2nCH N/kIfjmK/Egjl5SbHw3k/SOTTT6+sIiCwY0kZpqrJ8gMnQq/7AIDTMp8yEnpdz4rfQuf D54Rs5kZCp++koUnziuR0GUPgtpl8GPiw5dywdDwOYVUCaLameqj32/emey+m+Tq2FGK OIou9a5lMr8BdC8svsyN5SZf9s8l5a3EQLYTP6FU0J3IWkhor6AUTxk78E26aUy22uE6 zKvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678823542; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xMc2AnlV82kWeOQMw4Z57Uy8gyinuEGs+efX/3BzdrM=; b=HRyUKYz13Mxx5SVIkdI/Zbk5L80CI0pGKzNu4NXq2vfXL++mfOo+oovTcarc/k2Anf OfHF+t/sn+gtDxc+EELJN6XWhmAH/PSixYAEjMfN/5TZQsQprRcZXDXfbYxM+z2WpRuc /3ZP8dJleeBaky+4Rfk9ey6DQUDQdhbhie0AIUV2mtNGlEDl5Mzrshqv67xgtL0DWbZo mZ1PBrhDz/qtEKsgoLvPAgTISRWHhiF71ZHGLeI3gnJhXwAMXUX4w2UjLisWIZdiegDa J+HW7z29wvbRKZo/PQJzbTPlYLs/e605YOgGXuemWrqVX5GqYe+IYK43+NKmy4yqmp8K dyXA== X-Gm-Message-State: AO0yUKXTM1H9TkAQJ42/erenlsf8Tt0WIcUx9Ev6HVvjE0XxPjBNOPYs Hr35pfsd0QTxJRsRdU9M27I= X-Google-Smtp-Source: AK7set9lGQSvj/0qLoxjjRbWIJWyy4clOJmKgKtnIzH8T77Xxvcq28Mg1JfG2Pp6mT42x0CH2tiMRw== X-Received: by 2002:a50:fe92:0:b0:4af:62af:460a with SMTP id d18-20020a50fe92000000b004af62af460amr322583edt.8.1678823542126; Tue, 14 Mar 2023 12:52:22 -0700 (PDT) Received: from jernej-laptop.localnet (82-149-1-233.dynamic.telemach.net. [82.149.1.233]) by smtp.gmail.com with ESMTPSA id v10-20020a50a44a000000b004fd204d180dsm1484455edb.64.2023.03.14.12.52.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Mar 2023 12:52:21 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Joe Tessler , Hans Verkuil , Mauro Carvalho Chehab , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Thierry Reding , Jonathan Hunter , Manivannan Sadhasivam , Michael Tretter , Pengutronix Kernel Team , Jacopo Mondi , Kieran Bingham , Laurent Pinchart , Niklas =?ISO-8859-1?Q?S=F6derlund?= , Rui Miguel Silva , Wenyou Yang , Bin Liu , Matthias Brugger , AngeloGioacchino Del Regno , Minghsiu Tsai , Houlong Wei , Andrew-CT Chen , Andrzej Pietrasiewicz , Jacek Anaszewski , Sylwester Nawrocki , Patrice Chotard , Yong Deng , Paul Kocialkowski , Chen-Yu Tsai , Samuel Holland , "Lad, Prabhakar" , Ezequiel Garcia , Philipp Zabel , Sean Young , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-tegra@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-rockchip@lists.infradead.org, Krzysztof Kozlowski Cc: Krzysztof Kozlowski Subject: Re: [PATCH 17/28] media: platform: sun6i-mipi-csi2: drop of_match_ptr for ID table Date: Tue, 14 Mar 2023 20:52:19 +0100 Message-ID: <5654872.DvuYhMxLoT@jernej-laptop> In-Reply-To: <20230312131318.351173-17-krzysztof.kozlowski@linaro.org> References: <20230312131318.351173-1-krzysztof.kozlowski@linaro.org> <20230312131318.351173-17-krzysztof.kozlowski@linaro.org> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Dne nedelja, 12. marec 2023 ob 14:13:07 CET je Krzysztof Kozlowski napisal(= a): > The driver can match only via the DT table so the table should be always > used and the of_match_ptr does not have any sense (this also allows ACPI > matching via PRP0001, even though it might not be relevant here). This > also fixes !CONFIG_OF error: >=20 > drivers/media/platform/sunxi/sun6i-mipi-csi2/sun6i_mipi_csi2.c:751:34: > error: =E2=80=98sun6i_mipi_csi2_of_match=E2=80=99 defined but not used > [-Werror=3Dunused-const-variable=3D] >=20 > Signed-off-by: Krzysztof Kozlowski > --- > drivers/media/platform/sunxi/sun6i-mipi-csi2/sun6i_mipi_csi2.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Acked-by: Jernej Skrabec Best regards, Jernej >=20 > diff --git a/drivers/media/platform/sunxi/sun6i-mipi-csi2/sun6i_mipi_csi2= =2Ec > b/drivers/media/platform/sunxi/sun6i-mipi-csi2/sun6i_mipi_csi2.c index > a220ce849b41..0851b6b4e1ff 100644 > --- a/drivers/media/platform/sunxi/sun6i-mipi-csi2/sun6i_mipi_csi2.c > +++ b/drivers/media/platform/sunxi/sun6i-mipi-csi2/sun6i_mipi_csi2.c > @@ -759,7 +759,7 @@ static struct platform_driver > sun6i_mipi_csi2_platform_driver =3D { .remove =3D sun6i_mipi_csi2_remove, > .driver =3D { > .name =3D SUN6I_MIPI_CSI2_NAME, > - .of_match_table =3D=20 of_match_ptr(sun6i_mipi_csi2_of_match), > + .of_match_table =3D sun6i_mipi_csi2_of_match, > .pm =3D &sun6i_mipi_csi2_pm_ops, > }, > };