Re: [PATCH v2 1/5] mfd: axp20x: AXP717: Fix missing IRQ status registers range

Lee Jones
2024-06-12T15:48:22Z

On Wed, 12 Jun 2024, Andre Przywara wrote:

> Hi,
>
> On 12/06/2024 16:25, Lee Jones wrote:
> > On Wed, 12 Jun 2024, Andre Przywara wrote:
> >
> > > Hi Lee,
> > >
> > > On 02/05/2024 10:39, Lee Jones wrote:
> > > > On Thu, 18 Apr 2024, Andre Przywara wrote:
> > > >
> > > > > While we list the "IRQ status *and acknowledge*" registers as volatile,
> > > > > they are missing from the writable range array, so acknowledging any
> > > > > interrupts was met with an -EIO error.
> > > > >
> > > > > Add the five registers that hold those bits to the writable array.
> > > > >
> > > > > Fixes: b5bfc8ab2484 ("mfd: axp20x: Add support for AXP717 PMIC")
> > > > > Reported-by: Chris Morgan <macromorgan@hotmail.com>
> > > > > Signed-off-by: Andre Przywara <andre.przywara@arm.com>
> > > > > ---
> > > > > drivers/mfd/axp20x.c | 1 +
> > > > > 1 file changed, 1 insertion(+)
> > > >
> > > > Acked-by: Lee Jones <lee@kernel.org>
> > >
> > > Can you please take just this patch as a fix for 6.10? This fixes the power
> > > key operation.
> > > This applies cleanly on top of v6.10-rc3, so there is no need for any extra
> > > immutable branch or coordination with regulator.
> > > (The same is true independently for patch 2/5, on the regulator side).
> >
> > What does the Fixes: commit break?
> >
> > Or is it the case that it never worked properly?
>
> The interrupt part never worked properly, but so far that's only needed for
> the power key operation. Unfortunately that part wasn't tested properly
> initially, so the patches were merged into your tree before that.

This doesn't sounds like a -fixes candidate. I'll mark the set for v6.11.

--
Lee Jones [李琼斯]