Re: [PATCH v2 0/5] regulator: Fix AXP717 PMIC support

Lee Jones
2024-08-05T14:21:54Z

On Thu, 01 Aug 2024, Chen-Yu Tsai wrote:

> Hi,
>
> On Thu, Apr 18, 2024 at 8:07 AM Andre Przywara <andre.przywara@arm.com> wrote:
> >
> > This is v2 of the fixes to the AXP717 PMIC support series. Lee put the
> > original patches in an immutable branch already, so these here go on top.
> > Patch 1 is new in v2, and adds the IRQ status and acknowledge registers
> > to the writable range. Thanks to Chris for pointing this out.
> > Patch 2 contains fixes to the regulator descriptions: the LDOs had the
> > wrong supply source, and two numbers were wrong. The datasheet describes
> > the voltage ranges and register values differently from what our macros
> > expect, in a way that literally begs for off-by-ones, so here you go.
> > Also there is an actual wrong number in the datasheet, add a comment to
> > document this.
> > I don't know if that's still feasible, but those two patches would be a
> > good candidate to squash into the patches that they fix.
> >
> > The other three patches add the "boost" regulator, which is meant to
> > provide the 5V USB VBUS power when operating from the battery. It's the
> > usual trinity of binding/mfd/regulator patches.
> > Again this could be squashed into the respective patches from the
> > original series, if people agree.
> >
> > Please have a look and test!
> >
> > Based on mfd/ib-mfd-regulator-6.10, as detailed below.
> >
> > Cheers,
> > Andre
> >
> > Changelog v1 .. v2:
> > - add tags
> > - add patch to add missing IRQ ack register range
> > - add comment to document bug in datasheet
> >
> > Andre Przywara (5):
> > mfd: axp20x: AXP717: Fix missing IRQ status registers range
> > regulator: axp20x: AXP717: fix LDO supply rails and off-by-ones
> > dt-bindings: mfd: x-powers,axp152: add boost regulator
> > mfd: axp20x: AXP717: Add support for boost regulator
> > regulator: axp20x: AXP717: Add boost regulator
>
> The latter three patches still haven't been merged.
>
> Andre, can you resend them for Lee or Mark to merge? Otherwise I
> can't take the RG35XXSP DT patches.

Right, please rebase and resubmit. I've lost all context now.

--
Lee Jones [李琼斯]