Re: [PATCH v2 2/5] regulator: axp20x: AXP717: fix LDO supply rails and off-by-ones

Andre Przywara
2024-06-14T10:02:08Z

On Fri, 14 Jun 2024 09:12:24 +0100
Lee Jones <lee@kernel.org> wrote:

Hi Lee,

> On Wed, 12 Jun 2024, Andre Przywara wrote:
>
> > Hi Broonie,
> >
> > On 18/04/2024 01:07, Andre Przywara wrote:
> > > The X-Powers AXP717 PMIC has separate input supply pins for each group
> > > of LDOs, so they are not all using the same DCDC1 input, as described
> > > currently.
> > >
> > > Replace the "supply" member of each LDO description with the respective
> > > group supply name, so that the supply dependencies can be correctly
> > > described in the devicetree.
> > >
> > > Also fix two off-by-ones in the regulator macros, after some double
> > > checking the numbers against the datasheet. This uncovered a bug in the
> > > datasheet: add a comment to document this.
> > >
> > > Fixes: d2ac3df75c3a ("regulator: axp20x: add support for the AXP717")
> > > Signed-off-by: Andre Przywara <andre.przywara@arm.com>
> >
> > Can you please take (at least) this one patch as a fix for 6.10? Applies
> > cleanly on top of v6.10-rc3. The changes are not super-critical, but worth
> > fixing nevertheless.
>
> FWIW, I have no idea what's going on with this set now.
>
> Once all of the necessary patches have been expedited, please gather
> together what's left and I'll take them via MFD.

Yes, we dropped the ball on this one a bit, apologies.
Broonie just took 2/5, so I will resend 3/5-5/5 as a new series, targeting
6.11.

Cheers,
Andre.