From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 732805D915 for ; Wed, 11 Sep 2024 10:32:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726050780; cv=none; b=Inez+8JVSDiKBxpJe5W76VdBLNJCXzcPMe0hYTNx7m0uv4An3d8mbKM0qID64hSYY6ATAAYpes83Db8+aCm4klCgSG9O8T1W1iNCL9PWrWlBRoPSDLDbx3QMtqhan57CvdjS1uzOg0jTY83l/gmWyQCb9XZkbc/3NQ6mXWeS+N4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726050780; c=relaxed/simple; bh=L3DfyRJyMBTh2hMe73ZBoYLf1innUkJOSEQ3kjB6jvE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=UJf92TXhBdCNsZ8HjV0N0eF7C5+2F3sFbvajRtCE/RSCqyV2JQ3BFysXbRjQyGD1t/ThjF33NF0RYDIDUHAR0nvTqEUxN7PxxLkL8x8/866BBrr3skjbz81XYqxHTKLxiQBfxN1xXDxHkGyfl3hSa+UtRWK+lw4/lsa64vnDAjs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=BBOUFPoN; arc=none smtp.client-ip=192.198.163.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="BBOUFPoN" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1726050779; x=1757586779; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=L3DfyRJyMBTh2hMe73ZBoYLf1innUkJOSEQ3kjB6jvE=; b=BBOUFPoNR/h4Tlt033g3R7rlmdTn7LR0jasxlaH/eTmM8ayDRWSNWli1 LudRuY/EjIZaVul4HFq0sbXqfHn7dK/b4tevFKj7X08l0iR/YXxhHx32G TAWRmDM1z4+uGzn5470I64x99BExIF+r0ul5+5nIEbJuMWs7c1OE1PnGB eJdzhUnWNQEvuPTB9kpBwBi4wWkioFgKioI179DoHsM07Jodl+XcZPQZw Auc2wlPY1nMSIGwzU+cs3xDdvESRmZiECiwSiMxU53H68q48H7EOffwyq jWq4+FNyEfs/eIDPOZMPFeXaUVP0iODVqp7gANjGesTeW+k5CRRofsjwz Q==; X-CSE-ConnectionGUID: KlU6/TR9QJu9y8cW1b7JKA== X-CSE-MsgGUID: w0UA0vwlSPeD5XnRWWYT9g== X-IronPort-AV: E=McAfee;i="6700,10204,11191"; a="50255170" X-IronPort-AV: E=Sophos;i="6.10,219,1719903600"; d="scan'208";a="50255170" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Sep 2024 03:32:59 -0700 X-CSE-ConnectionGUID: BNEu4AC2T/CJ3e9psPx4QQ== X-CSE-MsgGUID: 0lOjmVLITqO33NbgMFbjmA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,219,1719903600"; d="scan'208";a="72125867" Received: from pgcooper-mobl3.ger.corp.intel.com (HELO [10.245.244.58]) ([10.245.244.58]) by orviesa005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Sep 2024 03:32:53 -0700 Message-ID: <5c309853-c82c-475e-b8c2-fcdcfde20efc@linux.intel.com> Date: Wed, 11 Sep 2024 13:33:01 +0300 Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 01/13] ALSA: pcm: add more sample rate definitions To: Takashi Iwai , Pierre-Louis Bossart Cc: Jerome Brunet , Jaroslav Kysela , Takashi Iwai , David Rhodes , Richard Fitzgerald , Liam Girdwood , Mark Brown , Cezary Rojewski , Liam Girdwood , Bard Liao , Ranjani Sridharan , Kai Vehmanen , Srinivas Kandagatla , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com, alsa-devel@alsa-project.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev References: <20240905-alsa-12-24-128-v1-0-8371948d3921@baylibre.com> <20240905-alsa-12-24-128-v1-1-8371948d3921@baylibre.com> <1ab3efaa-863c-4dd0-8f81-b50fd9775fad@linux.intel.com> <87ed5q4kbe.wl-tiwai@suse.de> Content-Language: en-US From: =?UTF-8?Q?P=C3=A9ter_Ujfalusi?= In-Reply-To: <87ed5q4kbe.wl-tiwai@suse.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 11/09/2024 12:21, Takashi Iwai wrote: >> Wondering if this is backwards compatible with the alsa-lib definitions, >> specifically the topology parts which did unfortunately have a list of >> rates that will map to a different index now: >> >> >> typedef enum _snd_pcm_rates { >> SND_PCM_RATE_UNKNOWN = -1, >> SND_PCM_RATE_5512 = 0, >> SND_PCM_RATE_8000, >> SND_PCM_RATE_11025, >> SND_PCM_RATE_16000, >> SND_PCM_RATE_22050, >> SND_PCM_RATE_32000, >> SND_PCM_RATE_44100, >> SND_PCM_RATE_48000, >> SND_PCM_RATE_64000, >> SND_PCM_RATE_88200, >> SND_PCM_RATE_96000, >> SND_PCM_RATE_176400, >> SND_PCM_RATE_192000, >> SND_PCM_RATE_CONTINUOUS = 30, >> SND_PCM_RATE_KNOT = 31, >> SND_PCM_RATE_LAST = SND_PCM_RATE_KNOT, >> } snd_pcm_rates_t; > > As far as I understand correctly, those rate bits used for topology > are independent from the bits used for PCM core, although it used to > be the same. Maybe better to rename (such as SND_TPLG_RATE_*) so that > it's clearer only for topology stuff. Even if we rename these in alsa-lib we will need translation from SND_TPLG_RATE_ to SND_PCM_RATE_ in kernel likely? The topology files are out there and this is an ABI... > But it'd be better if anyone can double-check. Since the kernel just copies the rates bitfield, any rate above 11025 will be misaligned and result broken setup. > > > thanks, > > Takashi -- Péter