From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f178.google.com (mail-lj1-f178.google.com [209.85.208.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 43582C8E4 for ; Mon, 4 Sep 2023 19:53:20 +0000 (UTC) Received: by mail-lj1-f178.google.com with SMTP id 38308e7fff4ca-2bd6611873aso27025091fa.1 for ; Mon, 04 Sep 2023 12:53:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1693857199; x=1694461999; darn=lists.linux.dev; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=wvaluZJNHnPZbmcG4bvJEAilbtSGa3vKoc36gbuUccA=; b=VE+pJOW8IXD1xzanvXUW88eO8cvNZh8zFk5GkHa1aA8Pfq9Q/+/aagE4JCEg/0ARb+ bwKZYmD+FIZDh55A+jeRxKidk2bY78/pIF9KyMmzaGDtsdrs9fR3ewP/GPrr40wi1i6C UQjjNI4qLNER0urh0JYjymHJUgKjVJx6gq/60M7ZKfnvkOdbncOwAZvXb7Rzzgg58V7g V8PbPwnRCQnazUCc3qAUf7IhHafksYkwo8d9s1fq7gRWO3HeqCQVUHI0gGj4HmGapPAm 7mo9egvR8WlEaG1RtdNV81U/DwpyELiRB+SunJuIwJ1m7luUyrjwENm6sFackojfYjfr fIIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693857199; x=1694461999; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wvaluZJNHnPZbmcG4bvJEAilbtSGa3vKoc36gbuUccA=; b=MFO1+xV8a2JKk0VaVspJxcp+bLcv/GY+UMAMnjM7fM8S95KZsPZHAymZlHa0jU6fei a1RFYFz3wsRYkJRkJbyNuM56FPnOyYfN9dSKTQXYIehvmi4uzY3w4Hu7miK06PJ6qCwY oDEqMT+BcvsUgagotWKBfourdwSYsH0e0Y+4LLMraKuuP9nhQA65nPMHjfu09ZYgrQeS ADtOvr67j3iwFSv3Fu8XLbux40GTIyb0dB4imrdVdJ5TH01IKZxhjVhTzpYOHoSrq93m ef/qqjT2cWMLX2D2Ega+l90RmyXVIiQ7ks8BWJukugm8EXIbODYLWBV9KxNU3zrYvUes O/Cw== X-Gm-Message-State: AOJu0Yz7r6JC0oCuDy9OMJp1iT73Ri4pTNnt8OMl/MjAmN8t2Nb1fu6c FDstYTS6ZlvY7hzXYy5citC7kQ== X-Google-Smtp-Source: AGHT+IEfhBCcSQiWoHa2jiOolRPp2v0XsshOTlOP4jb6+QXkRjWKBP4OryeydAehfnhfGWiOqrEa0w== X-Received: by 2002:a2e:6a09:0:b0:2bd:16e6:f07c with SMTP id f9-20020a2e6a09000000b002bd16e6f07cmr7407883ljc.17.1693857198894; Mon, 04 Sep 2023 12:53:18 -0700 (PDT) Received: from [192.168.0.22] (77-252-46-238.static.ip.netia.com.pl. [77.252.46.238]) by smtp.gmail.com with ESMTPSA id o13-20020a17090637cd00b0098e2969ed44sm6475829ejc.45.2023.09.04.12.53.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 04 Sep 2023 12:53:18 -0700 (PDT) Message-ID: <6e4cd0a1-43d0-e2e8-7281-e20ae653eae6@linaro.org> Date: Mon, 4 Sep 2023 21:53:05 +0200 Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: [PATCH 3/6] dt-bindings: opp: Add compatible for H616 To: Martin Botka Cc: Mark Rutland , Lorenzo Pieralisi , Sudeep Holla , "Rafael J. Wysocki" , Viresh Kumar , Yangtao Li , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-sunxi@lists.linux.dev, devicetree@vger.kernel.org, Andre Przywara , Alan Ma , Luke Harrison , Marijn Suijten , AngeloGioacchino Del Regno , Konrad Dybcio , Rogerio Goncalves , Martin Botka References: <20230904-cpufreq-h616-v1-0-b8842e525c43@somainline.org> <20230904-cpufreq-h616-v1-3-b8842e525c43@somainline.org> <2C8H0S.90380B1U7TPP3@somainline.org> Content-Language: en-US From: Krzysztof Kozlowski In-Reply-To: <2C8H0S.90380B1U7TPP3@somainline.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 04/09/2023 21:48, Martin Botka wrote: > > > On Mon, Sep 4 2023 at 09:32:44 PM +02:00:00, Krzysztof Kozlowski > wrote: >> On 04/09/2023 21:31, Krzysztof Kozlowski wrote: >>> On 04/09/2023 17:57, Martin Botka wrote: >>>> We need to add compatible for H616 to H6 cpufreq driver bindings. >>> >>> Please describe the hardware, not what is needed for drivers. >>> >>>> >>>> Also enable opp_supported_hw property that will be needed for H616. >>>> >>>> Signed-off-by: Martin Botka >>>> --- >>>> .../bindings/opp/allwinner,sun50i-h6-operating-points.yaml >>>> | 6 +++++- >>>> 1 file changed, 5 insertions(+), 1 deletion(-) >>>> >>>> diff --git >>>> a/Documentation/devicetree/bindings/opp/allwinner,sun50i-h6-operating-points.yaml >>>> b/Documentation/devicetree/bindings/opp/allwinner,sun50i-h6-operating-points.yaml >>>> index 51f62c3ae194..2fa1199f2d23 100644 >>>> --- >>>> a/Documentation/devicetree/bindings/opp/allwinner,sun50i-h6-operating-points.yaml >>>> +++ >>>> b/Documentation/devicetree/bindings/opp/allwinner,sun50i-h6-operating-points.yaml >>>> @@ -23,7 +23,10 @@ allOf: >>>> >>>> properties: >>>> compatible: >>>> - const: allwinner,sun50i-h6-operating-points >>>> + contains: >>> >>> This does not look like part of allOf, so contains is no correct >>> here. >>> This must be specific, so drop contains. >> >> BTW, I also do no see it used by the driver at all. > Function sun50i_cpufreq_get_efuse uses it. It checks for H6 compatible > and if that fails we check for H616 compatible. Such code does no scale. It also does not look reasonable - you cannot have different compatible there. Device binds to h6 or h616, so you cannot have OPP table from other devices. Best regards, Krzysztof