From: Vasant Hegde <vasant.hegde@amd.com>
To: Jason Gunthorpe <jgg@nvidia.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Christian Benvenuti <benve@cisco.com>,
Heiko Stuebner <heiko@sntech.de>,
iommu@lists.linux.dev, Jernej Skrabec <jernej.skrabec@gmail.com>,
Joerg Roedel <joro@8bytes.org>, Leon Romanovsky <leon@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org,
linux-mediatek@lists.infradead.org, linux-rdma@vger.kernel.org,
linux-rockchip@lists.infradead.org, linux-sunxi@lists.linux.dev,
Matthias Brugger <matthias.bgg@gmail.com>,
Nelson Escobar <neescoba@cisco.com>,
Rob Clark <robin.clark@oss.qualcomm.com>,
Robin Murphy <robin.murphy@arm.com>,
Samuel Holland <samuel@sholland.org>,
Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>,
Chen-Yu Tsai <wens@csie.org>, Will Deacon <will@kernel.org>,
Yong Wu <yong.wu@mediatek.com>
Cc: Lu Baolu <baolu.lu@linux.intel.com>, patches@lists.linux.dev
Subject: Re: [PATCH v2 3/3] iommu: Allow drivers to say if they use report_iommu_fault()
Date: Sat, 8 Nov 2025 16:50:41 +0530 [thread overview]
Message-ID: <70252b95-6980-423b-a7cb-005f5064fe45@amd.com> (raw)
In-Reply-To: <3-v2-25fc75484cab+ab-iommu_set_fault_jgg@nvidia.com>
On 11/7/2025 2:04 AM, Jason Gunthorpe wrote:
> report_iommu_fault() is an older API that has been superseded by
> iommu_report_device_fault() which is capable to support PRI.
>
> Only two external drivers consume this, drivers/remoteproc and
> drivers/gpu/drm/msm. Ideally they would move over to the new APIs, but for
> now protect against accidentally mix and matching the wrong components.
>
> The iommu drivers support either the old iommu_set_fault_handler() via the
> driver calling report_iommu_fault(), or they are newer server focused
> drivers that call iommu_report_device_fault().
>
> Include a flag in the iommu_ops if the driver calls report_iommu_fault()
> and block iommu_set_fault_handler() for domain's of iommu drivers that
> can't support it.
>
> Reviewed-by: Lu Baolu <baolu.lu@linux.intel.com>
> Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
Reviewed-by: Vasant Hegde <vasant.hegde@amd.com>
-Vasant
next prev parent reply other threads:[~2025-11-08 11:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-06 20:34 [PATCH v2 0/3] Cleanup around iommu_set_fault_handler() Jason Gunthorpe
2025-11-06 20:34 ` [PATCH v2 1/3] RDMA/usnic: Remove iommu_set_fault_handler() Jason Gunthorpe
2025-11-17 6:37 ` Tian, Kevin
2025-11-06 20:34 ` [PATCH v2 2/3] iommu/amd: Don't call report_iommu_fault() Jason Gunthorpe
2025-11-08 11:17 ` Vasant Hegde
2025-11-18 18:57 ` Jason Gunthorpe
2025-11-17 6:38 ` Tian, Kevin
2025-11-18 18:58 ` Jason Gunthorpe
2025-11-18 23:58 ` Tian, Kevin
2025-11-20 19:35 ` Jason Gunthorpe
2025-11-06 20:34 ` [PATCH v2 3/3] iommu: Allow drivers to say if they use report_iommu_fault() Jason Gunthorpe
2025-11-08 11:20 ` Vasant Hegde [this message]
2025-11-17 6:43 ` Tian, Kevin
2025-11-18 1:30 ` Chaoyi Chen
2025-11-18 19:00 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=70252b95-6980-423b-a7cb-005f5064fe45@amd.com \
--to=vasant.hegde@amd.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=baolu.lu@linux.intel.com \
--cc=benve@cisco.com \
--cc=heiko@sntech.de \
--cc=iommu@lists.linux.dev \
--cc=jernej.skrabec@gmail.com \
--cc=jgg@nvidia.com \
--cc=joro@8bytes.org \
--cc=leon@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=matthias.bgg@gmail.com \
--cc=neescoba@cisco.com \
--cc=patches@lists.linux.dev \
--cc=robin.clark@oss.qualcomm.com \
--cc=robin.murphy@arm.com \
--cc=samuel@sholland.org \
--cc=suravee.suthikulpanit@amd.com \
--cc=wens@csie.org \
--cc=will@kernel.org \
--cc=yong.wu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox