From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net [217.70.183.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AD1FF84DE6 for ; Tue, 16 Apr 2024 07:55:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.199 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713254160; cv=none; b=bApw1S4hDRpQefYqV/yPKrrcnMYO/eUEVZ4onME97n+2CbjuNQ7f7Z/v5e2nIy08244Z8wIGkXclAvVqynwW/PJtMXd2h6HMPNljesusjIFXpdtB9TCd4cjX50d5gQtxaDk66ivEP0ayGeboAaY9+Xs1v45F8VPf7d1NNarSiz0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713254160; c=relaxed/simple; bh=FNHbQiBBP8Y9Z4UhDHB1kGtf1vaeV2YhdLHMFkJwVuo=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References: MIME-Version:Content-Type; b=SpZxrvs72TJ8ElumHN3AvMjJbEQfvAaSdomwcPY24DF2P2r079ipZRiZ9ZA3BivYqAswkfaPm/YWbM4UvU6NA7/nCLST8IWsTBlK511lx2HvKlm+r1SgCeBiUWilV37KiI9wENR2EOGcySMizCO/JT8rp4ze6IoOjJhooSeduI8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=LtugVChy; arc=none smtp.client-ip=217.70.183.199 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="LtugVChy" Received: by mail.gandi.net (Postfix) with ESMTPSA id 5B3FEFF802; Tue, 16 Apr 2024 07:55:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1713254157; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MNHJECVaeH5Bqcxn+tWmMLACctSfkhVXpwFzee2HMAk=; b=LtugVChyoDxebpXTrApSPFU1i07DT8qK9YJEwMwn/0JmI6ndkLuG22gdGgU0V+VI9K923L CK6F7wKZ7kaniEyTR5uvoEug6BjcnL1a/xdRTo1RsS1ZyHpnWZ8z14QKM7oMhRF+mWiy92 vWxP33Z9hLCY2jjTfrGbZRZ5gTmEdY8bEl7vj1HjfNZ8dF685mQdeRCVSdB/IHcemRbh/s 3xvMTWwNHqrUJxfAw7f5LSxNhnI4n+aw+YjU/IwJxsHyFLkYUsvcULOiA2MmqKyVkTCXZj QblLIhQt69FkaNO52lwcj+uADa+0o9vJMWZ7Sx51X+/M7rkz+wjyn/uqUU4ozQ== Date: Tue, 16 Apr 2024 09:56:32 +0200 (CEST) From: Romain Gantois To: Serge Semin cc: Alexandre Torgue , Jose Abreu , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Russell King , Yanteng Si , Maxime Coquelin , Simon Horman , Huacai Chen , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 4/4] net: stmmac: Move MAC caps init to phylink MAC caps getter In-Reply-To: <20240412180340.7965-5-fancer.lancer@gmail.com> Message-ID: <714199e5-edf2-dcbb-216b-563431d70488@bootlin.com> References: <20240412180340.7965-1-fancer.lancer@gmail.com> <20240412180340.7965-5-fancer.lancer@gmail.com> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-GND-Sasl: romain.gantois@bootlin.com Hi Serge, On Fri, 12 Apr 2024, Serge Semin wrote: > +static unsigned long stmmac_mac_get_caps(struct phylink_config *config, > + phy_interface_t interface) > +{ > + struct stmmac_priv *priv = netdev_priv(to_net_dev(config->dev)); > + > + /* Get the MAC-specific capabilities */ > + stmmac_mac_phylink_get_caps(priv); This is a bit of a nitpick, but the terminology is quite confusing between stmmac_mac_phylink_get_caps() and stmmac_mac_get_caps(). Ideally, we could just get rid of the whole stmmac_do_void_callback() complexity and just call phylink_get_caps() directly. In the meantime, maybe renaming this to stmmac_mac_core_get_caps() would be acceptable? Please let me know what you think. Thanks, -- Romain Gantois, Bootlin Embedded Linux and Kernel engineering https://bootlin.com