ARM Sunxi Platform Development
 help / color / mirror / Atom feed
From: Ruslan Zalata <rz@fabmicro.ru>
To: Guenter Roeck <linux@roeck-us.net>
Cc: "Jernej Škrabec" <jernej.skrabec@gmail.com>,
	linux-hwmon@vger.kernel.org, linux-sunxi@lists.linux.dev
Subject: [PATCH] ARM: Add hwmon driver for LRADC found on Allwinner A13/A20 SoCs
Date: Thu, 28 Apr 2022 02:58:30 +0500	[thread overview]
Message-ID: <77778e4a93d8f7e40b9d614055d05eac@fabmicro.ru> (raw)
In-Reply-To: <3fde4708-2775-6383-1652-12e072b4b9c4@roeck-us.net>

Hi Guenter.

sun4i-gpadc-iio.c uses built-in four-channel ADC that is dedicated to 
RTP (resistive touch panel). It also can be used as a general purpose 
10-bit ADC, but it's a different piece of hardware inside SoC along with 
LRADC.

---
Regards,
Ruslan.

Fabmicro, LLC.

On 2022-04-28 02:07, Guenter Roeck wrote:
> On 4/27/22 13:23, Jernej Škrabec wrote:
>> Hi Ruslan!
>> 
>> Dne sreda, 27. april 2022 ob 21:25:12 CEST je Ruslan Zalata 
>> napisal(a):
>>> Some Allwinner SoCs like A13, A20 or T2 are equipped with two-channel
>>> low rate (6 bit) ADC that is often used for extra keys. There's a 
>>> driver
>>> for that already implementing standard input device, but it has these
>>> limitations: 1) it cannot be used for general ADC data equisition, 
>>> and
>>> 2) it uses only one LRADC channel of two available.
>>> 
>>> This driver provides basic hwmon interface to both channels of LRADC 
>>> on
>>> such Allwinner SoCs.
>>> 
>>> Signed-off-by: Ruslan Zalata <rz@fabmicro.ru>
>> 
>> Before even going to check actual driver, please read 
>> https://www.kernel.org/
>> doc/html/latest/process/submitting-patches.html in detail.
>> 
>> Just few basic things to fix first:
>> 1. subject doesn't conform to rules
>> 2. send patch to maintainers and mailing lists (use 
>> scripts/get_maintainer.pl)
> 
> I only got the copy sent directly to me. Anyway, how is this different 
> to
> the driver in drivers/iio/adc/sun4i-gpadc-iio.c ?
> 
> Guenter

      reply	other threads:[~2022-04-27 21:58 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-27 19:25 [PATCH] ARM: Add hwmon driver for LRADC found on Allwinner A13/A20 SoCs Ruslan Zalata
2022-04-27 20:23 ` Jernej Škrabec
2022-04-27 21:01   ` Ruslan Zalata
2022-04-27 21:12     ` Jernej Škrabec
2022-04-27 21:50       ` Ruslan Zalata
2022-04-27 22:54         ` Guenter Roeck
2022-04-28 20:51           ` Ruslan Zalata
2022-04-27 21:07   ` Guenter Roeck
2022-04-27 21:58     ` Ruslan Zalata [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=77778e4a93d8f7e40b9d614055d05eac@fabmicro.ru \
    --to=rz@fabmicro.ru \
    --cc=jernej.skrabec@gmail.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-sunxi@lists.linux.dev \
    --cc=linux@roeck-us.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox