From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1A6BB193066 for ; Fri, 7 Jun 2024 15:36:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717774620; cv=none; b=Ci9A1B8jF2ZyGNoP1Zb4tnDql+1VKfV3p+Q2GOMlfGsj/HbZQxwAwnxhvCN+ekcl5KM9fnxFkBUM1JYa8EA64qtR3DFNWBEOq17nH4IlRx0Q4r5rvC8LFNS2uNBhbGP6Raif3IjoDGeYFMzUQ469Xd8PcC+y6XJzt8PnlDgFoQo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717774620; c=relaxed/simple; bh=njFwS84yyP3Xwr02JnamX7Dhu6AzJdZO+TJ88+ClOI0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Wp7CyNpwBrqGbJOarxoliUG8MZxXqSpg2h655/4kHfcl1hx+CRhaMh48QGWnkgBUUBlPUUWHCLpW16nmkhIBSRoly/CI5Tw1jLXr+aD2Bu5sFro7lHXASFxocdvwgZ6A1W0a+bDIFHjaFTfbIOrYSB+0hadwxYjtQubCSDMGQ6E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=QB7ZapiN; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="QB7ZapiN" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-421798185f0so1107935e9.1 for ; Fri, 07 Jun 2024 08:36:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1717774617; x=1718379417; darn=lists.linux.dev; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=4WFHGyOf2WCg/AHCXQoRe0OOLDlNcvfZjAFHn1msRSw=; b=QB7ZapiNWTOzhMeuqvjjYY8E3SRmyRBPdVvSfrAFtQqXvileBs6CS7yJTaTZqw5Is+ aAz/MLxP7wUZb51H3Zv0W8q7N/4aefbnCIMuhvPEplFIKLD5Q1XITCkgftymVQZD9Sc1 hTH6vwwNINjZYkA1k2blCx1Ln3uuuNtBQpU+1/1IX2KJ4eWN52F4Aq/S37wYyVOLj5RF BBXLMtE1QT+LQGgQIwv4/FAj1Us2NybX5UipYFSyKBfEEYB8I34aYkw0AgQkwweT2r6m ffUlTincmVwTkRbbw16bGKJOjpTbddnuTPENohZdKP2fTv9qz6o9vMQAdr/un7xRbFkC qEyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717774617; x=1718379417; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4WFHGyOf2WCg/AHCXQoRe0OOLDlNcvfZjAFHn1msRSw=; b=jG3ERk/fiWRhBN2KseocLbyr8/pSo0q12RU/JmzL2Ks4QIkkczqlCZ/KlHTITmOo55 lxc9m4S9t/Nt6xgN3uRrXxW49toHHPaffWFrue1nNKrJy/QpTInAVBbxBNMmIPZwauRb r0D2JeCcdWLETE+D0vdR6jryF0hR4GIcmz4HVD0VHcX3G8NaKh1+x988ybVaFMe29zsD XYdp/CuCAAaYtQ/xpwTdz9Cg8m3bqlhRAPLib35EA9bNaAE5sHNl6/G20dICZ606NdEJ mAzoVZTtQnrLurwE1QfPsnkpWtaUvKW8TJRWaWoCdcXnCBsCEVOMzT2wae3js2ICZPKP u90A== X-Forwarded-Encrypted: i=1; AJvYcCVhmIkHAwk73jxYI352hra93AWq0CFtVewvJqta9ICJLyW62Rxn0auFkt3ZlQviCZ1YeLI6YEgoVLe3y3FhRsDU31XdrVtqvCv3dQQ= X-Gm-Message-State: AOJu0YxFDOHy6VhhoPEU29fpTkrd7mIFsYcj8iEfgqtQC0pNYHP5J5Tl P3A0rJd0XUjalHoiriy8Gb0X3vuhoHm5X+nNGjAUC6ggBlANM7pf83NB3hAYZwk= X-Google-Smtp-Source: AGHT+IEDldfKJ9oi/vJP0wgtmawveExjpCYHaZ1+MQjCvlUC+KOjWN7/r5DIQyvHKU1HK5ctc+JgNw== X-Received: by 2002:a05:600c:444b:b0:420:29a8:ff5e with SMTP id 5b1f17b1804b1-42164a0c1c9mr25925175e9.19.1717774617356; Fri, 07 Jun 2024 08:36:57 -0700 (PDT) Received: from [192.168.1.195] ([5.133.47.210]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-4215f89aacfsm48862905e9.42.2024.06.07.08.36.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 07 Jun 2024 08:36:56 -0700 (PDT) Message-ID: <7cc32596-8af0-43ff-91fd-59264d0a29ac@linaro.org> Date: Fri, 7 Jun 2024 16:36:55 +0100 Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 07/17] misc: eeprom: at25: Change nvmem reg_read/write return type To: Dan Carpenter , Joy Chakraborty , Greg Kroah-Hartman Cc: AngeloGioacchino Del Regno , Lars-Peter Clausen , Sakari Ailus , Bingbu Cao , Zhihao Cheng , Jerome Brunet , Martin Blumenstingl , linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-media@vger.kernel.org, linux-i2c@vger.kernel.org, linux-gpio@vger.kernel.org, linux-mtd@lists.infradead.org, linux-rtc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, linux-usb@vger.kernel.org, manugautam@google.com References: <20240605175953.2613260-1-joychakr@google.com> <20240605175953.2613260-8-joychakr@google.com> Content-Language: en-US From: Srinivas Kandagatla In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 06/06/2024 09:41, Dan Carpenter wrote: > So the original bug was that rmem_read() is returning positive values > on success instead of zero[1]. That started a discussion about partial > reads which resulted in changing the API to support partial reads[2]. > That patchset broke the build. This patchset is trying to fix the > build breakage. > > [1]https://lore.kernel.org/all/20240206042408.224138-1-joychakr@google.com/ > [2]https://lore.kernel.org/all/20240510082929.3792559-2-joychakr@google.com/ > > The bug in rmem_read() is still not fixed. That needs to be fixed as > a stand alone patch. We can discuss re-writing the API separately. I agree with Dan, Lets fix the rmem_read and start working on the API rework in parallel. Am happy to pick the [1]. --srini