From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.manjaro.org (mail.manjaro.org [116.203.91.91]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D00D918B1A for ; Wed, 24 Apr 2024 18:53:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=116.203.91.91 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713984821; cv=none; b=jd6J1mI+w2b3fKCIdMKPE+VoEq7axDdDlnxngM/KxnZwidb5lCVfgiAUB+IvBlgT+xUgX/70oNWPU+O4s5pfQE1NYSdNpiuV4ww7BxZ8+izSUl+ataF1F6wf50CcP5xBuJaR/j/shrolY75PzDnaqKTYGSzTlLA3mtjQsB5prVI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713984821; c=relaxed/simple; bh=JReJtYzITQP6/VHBJJbrJcVU8JRMApJY+9XkPt1Iuys=; h=MIME-Version:Date:From:To:Cc:Subject:In-Reply-To:References: Message-ID:Content-Type; b=hVJT8ARpt+Jv+hXkZmpId5wZxib4I9Mn3arkLVTa+6Pnf3XCnZT/fCX9EbiISJJ/3HwmCcv5jMUgItgn95229mmxp5jz8FhIA35crNPXfrQj1bdu04jjOumDy9qB5fkTV+5fkA0CdXZRq6sxI68LGzOCisgq2tsGq10GQu7WdA8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=manjaro.org; spf=pass smtp.mailfrom=manjaro.org; dkim=pass (2048-bit key) header.d=manjaro.org header.i=@manjaro.org header.b=psyrmjYu; arc=none smtp.client-ip=116.203.91.91 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=manjaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=manjaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=manjaro.org header.i=@manjaro.org header.b="psyrmjYu" Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=manjaro.org; s=2021; t=1713984816; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Wmh2zsD5aonHgzjvtDSksCkYXZ2zaCKpg80CDN+KkvM=; b=psyrmjYuA48TPP0SxIo6oCGiiv9HjFHxQ92ys8CxP808wVs+ZDbAB3j02YIvlZQtVe3ZBA KMZvv6a+t9f+FCrfyvHlr0zZ3d2fC9a9FzIVBD59fK9lsPvaTJiwJZRrx80MKA18qiPFvm 4NmT4pL+ONkRLOzBCTC6RrR8XnXI0/eppZkYBgp09Jx0U8CA3W0q1CnOqJw5PXCGTmunJn W4PYNQmt+pEc5J0zZzXef6wGwyLRFgYFdrCBirQHYEEvDLO7B4k9yICyPqfRdHOOiEX9yB l76bOi9FmGqojFdR/rvA6s+S8Ir8tYaxmaQeZqFuREU9ZsCSUvre0/f4EkF0ag== Date: Wed, 24 Apr 2024 20:53:36 +0200 From: Dragan Simic To: =?UTF-8?Q?Jernej_=C5=A0krabec?= Cc: linux-sunxi@lists.linux.dev, wens@csie.org, samuel@sholland.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, robh+dt@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-kernel@vger.kernel.org, didi.debian@cknow.org, Marek Kraus Subject: Re: [PATCH 2/2] arm64: dts: allwinner: Correct the model names for Pine64 boards In-Reply-To: <4912377.31r3eYUQgx@jernej-laptop> References: <4912377.31r3eYUQgx@jernej-laptop> Message-ID: <7f6cc2b938f6f79b1a0fc63539273641@manjaro.org> X-Sender: dsimic@manjaro.org Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Authentication-Results: ORIGINATING; auth=pass smtp.auth=dsimic@manjaro.org smtp.mailfrom=dsimic@manjaro.org On 2024-04-24 20:51, Jernej Škrabec wrote: > Dne torek, 23. april 2024 ob 03:00:20 GMT +2 je Dragan Simic > napisal(a): >> Correct the model names of a few Pine64 boards and devices, according >> to their official names used on the Pine64 wiki. This ensures >> consistency >> between the officially used names and the names in the source code. >> >> Cc: Marek Kraus >> Signed-off-by: Dragan Simic > > Acked-by: Jernej Skrabec Thanks! >> --- >> >> Notes: >> This completes the correction of the model names of the Pine64 >> boards >> and devices, which was started with the Pine64 boards and devices >> based >> on Rockchip SoCs. [1] >> >> These improvements may cause certain issues if some scripts misuse >> /proc/device-tree/model to detect the board they're executed on. >> Though, >> the right way to detect a board is to use >> /proc/device-tree/compatible >> instead, because its contents is part of the ABI. Such scripts, >> if they >> actually exist in the field, should be improved to use the right >> way to >> detect the board model. >> >> [1] >> https://lore.kernel.org/linux-rockchip/06ce014a1dedff11a785fe523056b3b8ffdf21ee.1713832790.git.dsimic@manjaro.org/ >> >> arch/arm64/boot/dts/allwinner/sun50i-a64-pine64-lts.dts | 2 >> +- >> arch/arm64/boot/dts/allwinner/sun50i-a64-pinebook.dts | 2 >> +- >> .../boot/dts/allwinner/sun50i-a64-pinetab-early-adopter.dts | 2 >> +- >> arch/arm64/boot/dts/allwinner/sun50i-a64-pinetab.dts | 2 >> +- >> arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts | 2 >> +- >> arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64-model-b.dts | 2 >> +- >> arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts | 2 >> +- >> 7 files changed, 7 insertions(+), 7 deletions(-) >> >> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64-lts.dts >> b/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64-lts.dts >> index 596a25907432..4aab1f98fac7 100644 >> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64-lts.dts >> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64-lts.dts >> @@ -5,7 +5,7 @@ >> #include "sun50i-a64-sopine-baseboard.dts" >> >> / { >> - model = "Pine64 LTS"; >> + model = "Pine64 A64 LTS"; >> compatible = "pine64,pine64-lts", "allwinner,sun50i-r18", >> "allwinner,sun50i-a64"; >> >> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinebook.dts >> b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinebook.dts >> index 50ed2e9f10ed..a3c1752fc5d8 100644 >> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinebook.dts >> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinebook.dts >> @@ -13,7 +13,7 @@ >> #include >> >> / { >> - model = "Pinebook"; >> + model = "Pine64 Pinebook"; >> compatible = "pine64,pinebook", "allwinner,sun50i-a64"; >> chassis-type = "laptop"; >> >> diff --git >> a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinetab-early-adopter.dts >> b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinetab-early-adopter.dts >> index 6265360ce623..86cc85eb3d48 100644 >> --- >> a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinetab-early-adopter.dts >> +++ >> b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinetab-early-adopter.dts >> @@ -9,7 +9,7 @@ >> #include "sun50i-a64-pinetab.dts" >> >> / { >> - model = "PineTab, Early Adopter's version"; >> + model = "Pine64 PineTab Early Adopter"; >> compatible = "pine64,pinetab-early-adopter", "allwinner,sun50i-a64"; >> }; >> >> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinetab.dts >> b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinetab.dts >> index 0a5607f73049..ebeb04156eb6 100644 >> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinetab.dts >> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinetab.dts >> @@ -14,7 +14,7 @@ >> #include >> >> / { >> - model = "PineTab, Development Sample"; >> + model = "Pine64 PineTab Developer Sample"; >> compatible = "pine64,pinetab", "allwinner,sun50i-a64"; >> chassis-type = "tablet"; >> >> diff --git >> a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts >> b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts >> index 5e66ce1a334f..411d97610be9 100644 >> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts >> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts >> @@ -8,7 +8,7 @@ >> #include "sun50i-a64-sopine.dtsi" >> >> / { >> - model = "SoPine with baseboard"; >> + model = "Pine64 SOPine on Baseboard carrier board"; >> compatible = "pine64,sopine-baseboard", "pine64,sopine", >> "allwinner,sun50i-a64"; >> >> diff --git >> a/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64-model-b.dts >> b/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64-model-b.dts >> index b710f1a0f53a..52d81ff0d77d 100644 >> --- a/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64-model-b.dts >> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64-model-b.dts >> @@ -6,7 +6,7 @@ >> #include "sun50i-h6-pine-h64.dts" >> >> / { >> - model = "Pine H64 model B"; >> + model = "Pine64 H64 Model B"; >> compatible = "pine64,pine-h64-model-b", "allwinner,sun50i-h6"; >> >> /delete-node/ reg_gmac_3v3; >> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts >> b/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts >> index 1ffd68f43f87..f8b524d02429 100644 >> --- a/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts >> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts >> @@ -9,7 +9,7 @@ >> #include >> >> / { >> - model = "Pine H64 model A"; >> + model = "Pine64 H64 Model A"; >> compatible = "pine64,pine-h64", "allwinner,sun50i-h6"; >> >> aliases { >>