From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D1CE414AA9 for ; Sat, 7 Sep 2024 02:55:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.191 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725677745; cv=none; b=seTD2l4vk+9utpxTtLvSIK7hDONhspTgbvoLbeJ4y1sGRU+Bu+BDbIYSQI1x1QMwuyydZNL5q776Elh2A6gmLmxtNpq4hrlt/Yuu5iAfYm6y0Vm47Hy4+oBQ7w3mZFWhwmhqRfs70lbbEVx0Gakn172TdSYkDSCL2Ht2cnZce10= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725677745; c=relaxed/simple; bh=Mo7blfwgnaSNUonyuigBgsERMg7JbT1BgA+At6QtAq8=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=TFVX6zgSBUzCYfmUo+gNpkGcfBijLq/Q6UGQ53kBz25S9/fCOc/FNfCBHFN1CtTJ7j6CwFAFA3bzPaIeBdlXziGVz9XU9GkKqDiqKtpN3qfbjI1DSLiBsV2ARbMv2Cs7q4iDfxNObPM1EzaJHvrdoBQzesW8wEicSyzQE/g7Pcc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=45.249.212.191 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.19.88.234]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4X0yPv1pjQz1j80V; Sat, 7 Sep 2024 10:55:15 +0800 (CST) Received: from kwepemd500012.china.huawei.com (unknown [7.221.188.25]) by mail.maildlp.com (Postfix) with ESMTPS id CDF491400CF; Sat, 7 Sep 2024 10:55:38 +0800 (CST) Received: from [10.67.111.176] (10.67.111.176) by kwepemd500012.china.huawei.com (7.221.188.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.34; Sat, 7 Sep 2024 10:55:37 +0800 Message-ID: <852686ba-7578-4a1c-ae65-df7162e4e8bc@huawei.com> Date: Sat, 7 Sep 2024 10:55:36 +0800 Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next 00/12] net: Convert using devm_clk_get_enabled()/devm_clk_get_optional_enabled() To: Jeff Johnson , , , , , , , , , , , , , , , , , , , , , , , , , CC: , , , , , References: <20240831021334.1907921-1-lizetao1@huawei.com> <6f3f79f2-5755-4286-98f6-9950e7e994c8@quicinc.com> From: Li Zetao In-Reply-To: <6f3f79f2-5755-4286-98f6-9950e7e994c8@quicinc.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: dggpeml500004.china.huawei.com (7.185.36.140) To kwepemd500012.china.huawei.com (7.221.188.25) Hi, 在 2024/9/7 7:17, Jeff Johnson 写道: > On 8/30/2024 7:13 PM, Li Zetao wrote: >> There are many examples[1][2] of clk resource leakage in LTS. The >> reason is that developers need to maintain the allocation and release >> of clk resources themselves, but this will increase the burden on >> developers. Using the API related to devm_clk_get_*_enable ensures >> that the life cycle of clk is consistent with that of the device, >> reducing the risk of unreleased resources like clk. >> >> Several other developers are also working on converting to more >> secure interfaces, and this patch set is in principle the same as >> theirs. > > ... > >> drivers/net/dsa/bcm_sf2.c | 28 ++---- >> drivers/net/ethernet/allwinner/sun4i-emac.c | 13 +-- >> drivers/net/ethernet/arc/emac_rockchip.c | 34 ++----- >> drivers/net/ethernet/ethoc.c | 18 ++-- >> drivers/net/ethernet/faraday/ftgmac100.c | 27 ++--- >> drivers/net/ethernet/hisilicon/hisi_femac.c | 17 +--- >> drivers/net/ethernet/lantiq_xrx200.c | 17 +--- >> .../stmicro/stmmac/dwmac-dwc-qos-eth.c | 98 ++++--------------- >> drivers/net/ethernet/sunplus/spl2sw_driver.c | 18 +--- >> .../net/ethernet/xilinx/xilinx_axienet_main.c | 15 +-- >> .../net/wireless/microchip/wilc1000/sdio.c | 10 +- >> drivers/net/wireless/microchip/wilc1000/spi.c | 5 +- > > note the wifi driver changes go through the wireless tree and not the net tree > so those should be split out separately I have separated the wifi related patches and sent them to the community: https://lore.kernel.org/all/20240903110205.4127706-1-lizetao1@huawei.com/ > > Thanks, Li Zetao.