From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 103F67ED for ; Wed, 2 Nov 2022 09:04:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1667379844; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XBlp2DOijU5hXQ9AriUwp9vEVLgfxcCQxHX+sSZSvOs=; b=foE1tqMnN1euVXsjwdlyPW1Y4BTMlfQxIBqnZz2eDUgMOJ3r8Zu+tBZQX0GkNtDL2D+9Aj flWcioqcZUsIaIG4L65T3zBd/pzbd1EQRgPn+MZdj0iMkyKMJis4wJ5Qwuj07kEsp7CYEk jHcVQV9OGuPi3hRfiynfov54IpOv5aE= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-364-rPZJX2oMPMWiH-HUnM4ObQ-1; Wed, 02 Nov 2022 05:04:01 -0400 X-MC-Unique: rPZJX2oMPMWiH-HUnM4ObQ-1 Received: by mail-wr1-f70.google.com with SMTP id o13-20020adfa10d000000b00232c00377a0so4621101wro.13 for ; Wed, 02 Nov 2022 02:04:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XBlp2DOijU5hXQ9AriUwp9vEVLgfxcCQxHX+sSZSvOs=; b=LU5jp50xYT+LWVOerNMlTdJIP82LW0CN6iyP76LO25b3eNbSA20xTNHKo8Z6nIMRKo cliznDA+dcozlJacdBQHXEwS6bfljUT2gfwSbxtpTiCy/nyj5DYiJgqBYL0zr5LSa05v nztZzRfu0B4B3BbxOPSSkJH9fIkBqf7e0+aHhgT6N/8Z4UpbaBFEIfXxwLLmcByqRomL kauhdVJapP2XuwtXYvn+fcDFZ7WONO/0/eiTIp2LAU9LJuictnJ1RteZDUTMqN7Mwvds bws9tstvqT8tQfB0/WXNjvavpdv42dThVD7E2tD1shDYQXmBWz+GcmoBEy9qaTy48M4l UEKA== X-Gm-Message-State: ACrzQf0jCyPh59s3qS53XOVHDE2Aj2yvmCni3ls2fJYWTu7fTB1+FBzD yl+pqviPgbaq23AopQOCt1nfiEdoT2BQb1oLHAz5NEJwDYR1u8lUV1SR2EuEubriBMEyLVY7g7Y BbyTZ9pqkBBttHablJyJ36KM= X-Received: by 2002:a7b:c409:0:b0:3cf:4c81:8936 with SMTP id k9-20020a7bc409000000b003cf4c818936mr24380813wmi.38.1667379840253; Wed, 02 Nov 2022 02:04:00 -0700 (PDT) X-Google-Smtp-Source: AMsMyM72ckpdUoZR+NwXtu1sv2+7NmgS+YMIWWHB7QdeKnWTKduGDRl7tg4bkpenTZv0mX1kFf34kw== X-Received: by 2002:a7b:c409:0:b0:3cf:4c81:8936 with SMTP id k9-20020a7bc409000000b003cf4c818936mr24380784wmi.38.1667379840046; Wed, 02 Nov 2022 02:04:00 -0700 (PDT) Received: from [192.168.1.130] (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id b13-20020a5d550d000000b002366b17ca8bsm14083933wrv.108.2022.11.02.02.03.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Nov 2022 02:03:59 -0700 (PDT) Message-ID: <87284e5e-859e-3b1c-7142-28d4fa7a7939@redhat.com> Date: Wed, 2 Nov 2022 10:03:57 +0100 Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH v2 15/21] drm/fb-helper: Disconnect damage worker from update logic To: Thomas Zimmermann , daniel@ffwll.ch, airlied@gmail.com, sam@ravnborg.org, mripard@kernel.org, maarten.lankhorst@linux.intel.com Cc: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, linux-aspeed@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, etnaviv@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-hyperv@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-mips@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, nouveau@lists.freedesktop.org, virtualization@lists.linux-foundation.org, spice-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, xen-devel@lists.xenproject.org References: <20221024111953.24307-1-tzimmermann@suse.de> <20221024111953.24307-16-tzimmermann@suse.de> From: Javier Martinez Canillas In-Reply-To: <20221024111953.24307-16-tzimmermann@suse.de> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 10/24/22 13:19, Thomas Zimmermann wrote: > The fbdev helpers implement a damage worker that forwards fbdev > updates to the DRM driver. The worker's update logic depends on > the generic fbdev emulation. Separate the two via function pointer. > > The generic fbdev emulation sets struct drm_fb_helper_funcs.fb_dirty, > a new callback that hides the update logic from the damage worker. > It's not possible to use the generic logic with other fbdev emulation, > because it contains additional code for the shadow buffering that > the generic emulation employs. > > DRM drivers with internal fbdev emulation can set fb_dirty to their > own implementation if they require damage handling; although no such > drivers currently exist. > > Signed-off-by: Thomas Zimmermann > --- [...] > static void drm_fb_helper_damage_work(struct work_struct *work) > { > - struct drm_fb_helper *helper = container_of(work, struct drm_fb_helper, > - damage_work); > - struct drm_device *dev = helper->dev; > + struct drm_fb_helper *helper = container_of(work, struct drm_fb_helper, damage_work); This line is an unrelated code style change. But I guess it's OK. Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat