Re: [PATCH v2 2/3] iommu/amd: Don't call report_iommu_fault()

[Vasant Hegde <vasant.hegde@amd.com>]

On 11/7/2025 2:04 AM, Jason Gunthorpe wrote:
> This old style API is only used by drivers/gpu/drm/msm,
> drivers/remoteproc/omap_remoteproc.c, and
> drivers/remoteproc/qcom_q6v5_adsp.c none are used on x86 HW.
> 
> Remove the dead code to discourage new users.
> 
> Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>

Reviewed-by: Vasant Hegde <vasant.hegde@amd.com>


> ---
>  drivers/iommu/amd/iommu.c | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/drivers/iommu/amd/iommu.c b/drivers/iommu/amd/iommu.c
> index 2e1865daa1cee8..d4d9a5dbfa6333 100644
> --- a/drivers/iommu/amd/iommu.c
> +++ b/drivers/iommu/amd/iommu.c
> @@ -854,13 +854,6 @@ static void amd_iommu_report_page_fault(struct amd_iommu *iommu,
>  						   PCI_FUNC(devid), domain_id);
>  				goto out;
>  			}

If you're planning to respin this series, could you please update the comment
above the if condition?

-Vasant


> -
> -			if (!report_iommu_fault(&dev_data->domain->domain,
> -						&pdev->dev, address,
> -						IS_WRITE_REQUEST(flags) ?
> -							IOMMU_FAULT_WRITE :
> -							IOMMU_FAULT_READ))
> -				goto out;
>  		}
>  
>  		if (__ratelimit(&dev_data->rs)) {