From: "Arnd Bergmann" <arnd@arndb.de>
To: "Chen-Yu Tsai" <wens@csie.org>, "Stefan Wahren" <wahrenst@gmx.net>
Cc: "Jernej Skrabec" <jernej.skrabec@gmail.com>,
"Samuel Holland" <samuel@sholland.org>,
"Maxime Ripard" <mripard@kernel.org>,
"Mylène Josserand" <mylene.josserand@bootlin.com>,
linux-sunxi@lists.linux.dev, soc@kernel.org,
"Florian Fainelli" <f.fainelli@gmail.com>,
linux-arm-kernel@lists.infradead.org,
"Nick Desaulniers" <ndesaulniers@google.com>
Subject: Re: [PATCH V2 2/2] ARM: sun9i: smp: fix return code check of of_property_match_string
Date: Tue, 02 Jan 2024 16:49:07 +0100 [thread overview]
Message-ID: <952ceeab-de16-434e-b69f-a45522feb79b@app.fastmail.com> (raw)
In-Reply-To: <CAGb2v66dvTZdRZF+yrdiAsjHVLAQkusyAx=Z5f=UxMNYBAY80A@mail.gmail.com>
On Tue, Jan 2, 2024, at 15:59, Chen-Yu Tsai wrote:
> On Fri, Dec 29, 2023 at 3:39 AM Stefan Wahren <wahrenst@gmx.net> wrote:
>>
>> of_property_match_string returns an int; either an index from 0 or
>> greater if successful or negative on failure. Even it's very
>> unlikely that the DT CPU node contains multiple enable-methods
>> these checks should be fixed.
>>
>> This patch was inspired by the work of Nick Desaulniers.
>>
>> Link: https://lore.kernel.org/lkml/20230516-sunxi-v1-1-ac4b9651a8c1@google.com/T/
>> Cc: Nick Desaulniers <ndesaulniers@google.com>
>> Signed-off-by: Stefan Wahren <wahrenst@gmx.net>
>
> Reviewed-by: Chen-Yu Tsai <wens@csie.org>
>
> Arnd, would it be possible to apply the two fixes directly to the soc tree?
Yes, I've merged them into the arm/fixes branch now. These
are currently the only fixes I have queued up but I should
be able to send them before the v6.7 release.
Arnd
next prev parent reply other threads:[~2024-01-02 15:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-28 19:39 [PATCH V2 1/2] ARM: sun9i: smp: Fix array-index-out-of-bounds read in sunxi_mc_smp_init Stefan Wahren
2023-12-28 19:39 ` [PATCH V2 2/2] ARM: sun9i: smp: fix return code check of of_property_match_string Stefan Wahren
2024-01-02 14:59 ` Chen-Yu Tsai
2024-01-02 15:49 ` Arnd Bergmann [this message]
2024-01-02 14:58 ` [PATCH V2 1/2] ARM: sun9i: smp: Fix array-index-out-of-bounds read in sunxi_mc_smp_init Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=952ceeab-de16-434e-b69f-a45522feb79b@app.fastmail.com \
--to=arnd@arndb.de \
--cc=f.fainelli@gmail.com \
--cc=jernej.skrabec@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=mripard@kernel.org \
--cc=mylene.josserand@bootlin.com \
--cc=ndesaulniers@google.com \
--cc=samuel@sholland.org \
--cc=soc@kernel.org \
--cc=wahrenst@gmx.net \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox