From: Dragan Simic <dsimic@manjaro.org>
To: Tom Rini <trini@konsulko.com>
Cc: Andre Przywara <andre.przywara@arm.com>,
Jagan Teki <jagan@amarulasolutions.com>,
Simon Glass <sjg@chromium.org>, Vignesh R <vigneshr@ti.com>,
Jaehoon Chung <jh80.chung@samsung.com>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Samuel Holland <samuel@sholland.org>,
Mikhail Kalashnikov <iuncuim@gmail.com>,
Piotr Oniszczuk <piotr.oniszczuk@gmail.com>,
Bob McChesney <bob@electricworry.net>,
Stephen Graf <stephen.graf@gmail.com>,
u-boot@lists.denx.de, linux-sunxi@lists.linux.dev
Subject: Re: [PATCH v2 1/3] mtd: spi-nor: Add support for zBIT ZB25VQ128
Date: Sun, 10 Dec 2023 00:05:34 +0100 [thread overview]
Message-ID: <97a1444d984fd329351048bb571dadbb@manjaro.org> (raw)
In-Reply-To: <20231209221320.GN2513409@bill-the-cat>
On 2023-12-09 23:13, Tom Rini wrote:
> On Sat, Dec 09, 2023 at 10:43:35PM +0100, Dragan Simic wrote:
>> On 2023-12-09 22:21, Tom Rini wrote:
>> > On Sat, Dec 09, 2023 at 10:02:09PM +0100, Dragan Simic wrote:
>> > > On 2023-12-09 21:43, Tom Rini wrote:
>> > > > On Sat, Dec 09, 2023 at 09:37:28PM +0100, Dragan Simic wrote:
>> > > > > On 2023-12-09 21:34, Tom Rini wrote:
>> > > > > > On Wed, Dec 06, 2023 at 04:24:43PM +0000, Andre Przywara wrote:
>> > > > > > > On Mon, 4 Dec 2023 00:59:52 +0000
>> > > > > > > Andre Przywara <andre.przywara@arm.com> wrote:
>> > > > > > > > Add support for the zBIT ZB25VQ128 (128M-bit) SPI NOR flash memory chip,
>> > > > > > > > as used on the Xunlong Orange Pi Zero 3 board.
>> > > > > > >
>> > > > > > > does anyone have any objections against this patch? I wanted to take
>> > > > > > > this
>> > > > > > > via the sunxi tree, as this blocks some board support patches.
>> > > > > > >
>> > > > > > > IIUC Linux gave up on adding rather generic entries up for each and
>> > > > > > > every
>> > > > > > > SPI NOR chip, if there is nothing special about them:
>> > > > > > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=773bbe1044
>> > > > > > > Should we follow suit here?
>> > > > > >
>> > > > > > And we could then start trimming the table we do have as well, to
>> > > > > > reclaim space?
>> > > > >
>> > > > > In general, yes, but we'd also need to consume a bit more space with
>> > > > > the
>> > > > > additional auto-detection logic.
>> > > >
>> > > > Maybe part one of the series is backport that logic, part two is remove
>> > > > all the easy to remove tables? Or at least a number of them so the
>> > > > series is a wash and then a targeted series of drop-an-entry and cc the
>> > > > person that added it so they can run-time verify it's still fine?
>> > >
>> > > Sounds like a plan to me and I'm willing to work on that. Though, I think
>> > > we'll inevitably end up with increasing the resulting image sizes a bit, but
>> > > that might be an acceptable trade-off for making supporting more SPI chips
>> > > and more new boards much easier in the future.
>> >
>> > Yeah, this is where we need to go overall long term if nothing else.
>>
>> I agree, it would make the things a bit easier. I'll see to start
>> working
>> on it next week.
>
> Thanks!
Thank you for agreeing with this new approach.
next prev parent reply other threads:[~2023-12-09 23:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-04 0:59 [PATCH v2 0/3] sunxi: add OrangePi Zero 3 board support Andre Przywara
2023-12-04 0:59 ` [PATCH v2 1/3] mtd: spi-nor: Add support for zBIT ZB25VQ128 Andre Przywara
2023-12-06 16:24 ` Andre Przywara
2023-12-06 17:38 ` Dragan Simic
2023-12-09 20:34 ` Tom Rini
2023-12-09 20:37 ` Dragan Simic
2023-12-09 20:43 ` Tom Rini
2023-12-09 21:02 ` Dragan Simic
2023-12-09 21:21 ` Tom Rini
2023-12-09 21:43 ` Dragan Simic
2023-12-09 22:13 ` Tom Rini
2023-12-09 23:05 ` Dragan Simic [this message]
2023-12-04 0:59 ` [PATCH v2 2/3] sunxi: H616: remove default AXP305 selection Andre Przywara
2023-12-04 0:59 ` [PATCH v2 3/3] sunxi: H616: Add OrangePi Zero 3 board support Andre Przywara
2023-12-04 5:57 ` [PATCH v2 0/3] sunxi: add " Stephen Graf
2023-12-05 18:30 ` Andre Przywara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=97a1444d984fd329351048bb571dadbb@manjaro.org \
--to=dsimic@manjaro.org \
--cc=andre.przywara@arm.com \
--cc=bob@electricworry.net \
--cc=iuncuim@gmail.com \
--cc=jagan@amarulasolutions.com \
--cc=jernej.skrabec@gmail.com \
--cc=jh80.chung@samsung.com \
--cc=linux-sunxi@lists.linux.dev \
--cc=piotr.oniszczuk@gmail.com \
--cc=samuel@sholland.org \
--cc=sjg@chromium.org \
--cc=stephen.graf@gmail.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox