From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9AF4A3201 for ; Sat, 23 Apr 2022 19:45:08 +0000 (UTC) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id A59735C013A; Sat, 23 Apr 2022 15:45:07 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Sat, 23 Apr 2022 15:45:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sholland.org; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1650743107; x= 1650829507; bh=h1ToIWPq6OSSwLnJ0g8sY57Xw3btjZPjZHe3fJxISP0=; b=q jK62bDYmKLKKt7KIUq6xRKJoE9LOG6WmubRZJw6MAXLxh0+w3zCbfVsCN3BJEP4O DP4Ynb1murUnVqduMpPcpfywxEomaHp3YoKKy2GK9P0CZWW0FCuo9+ikOMnC7Ruh m4JUVTbVikFl2YjVMP6WKilRp4u/nSNuUDETgZ1nUi5RvqTh5qUdqQ2/4msX+FZE AotYMdHyAunPRRIPCLi3WyJvIm75bCQY+UgIj4qrQ4ISd/cQNr+gs1EVda7H10xx Q2Apl+gfgJm1JCaAD5F0RHv4EbiE+KYqrm7yqBzyfts0zmqV0FTQxhVwuQg+5Ayp CAG1iwHnR8KxLQ6bVy24A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1650743107; x=1650829507; bh=h1ToIWPq6OSSw LnJ0g8sY57Xw3btjZPjZHe3fJxISP0=; b=wJiL1f87DzHpR5NY7Vmu0j2wSacSG vg30qER4x3PQEpEjXZ5WtXA+PVm1kjxHWyfMBSWj3U6jj9ZjOLFvoFWtYLe6e52D CwKAezzvsJvbEtAomXvIWJg7c3hQm8UiMYk4EDDbkdDlkIoZkj361LwyNP0fI3s/ gCjF/fXsgg2OjK2xWjQyGBOMzHaz+7sdXTVpT2dTUREa5DH/NPDCBT/1nOevNgCa H5GAMbtS/SqCMPkGqx7SW7IxNGOJ8oqHB+8MhwfmQxIUfl6wPfat46HkH1yEehN6 YBxJqs5d64vVsuK9XCzTrZyR3/yzVXWKrfv0dTLxjytjZfwD5/cVXT4eg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrtdeigddugeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepuffvvehfhffkffgfgggjtgfgsehtjeertddtfeejnecuhfhrohhmpefurghm uhgvlhcujfholhhlrghnugcuoehsrghmuhgvlhesshhhohhllhgrnhgurdhorhhgqeenuc ggtffrrghtthgvrhhnpefftdevkedvgeekueeutefgteffieelvedukeeuhfehledvhfei tdehudfhudehhfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehsrghmuhgvlhesshhhohhllhgrnhgurdhorhhg X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 23 Apr 2022 15:45:06 -0400 (EDT) Subject: Re: [PATCH] clk: sunxi: sun9i-mmc: check return value after calling platform_get_resource() To: Yang Yingliang , linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org Cc: wens@csie.org, maxime@cerno.tech References: <20220421134308.2885094-1-yangyingliang@huawei.com> From: Samuel Holland Message-ID: <9ebabc53-72de-bbec-895c-fa3760ed5374@sholland.org> Date: Sat, 23 Apr 2022 14:45:05 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: <20220421134308.2885094-1-yangyingliang@huawei.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 4/21/22 8:43 AM, Yang Yingliang wrote: > It will cause null-ptr-deref if platform_get_resource() returns NULL, > we need check the return value. > > Fixes: 7a6fca879f59 ("clk: sunxi: Add driver for A80 MMC config clocks/resets") > Signed-off-by: Yang Yingliang Reviewed-by: Samuel Holland