From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 02BD94C78 for ; Mon, 14 Nov 2022 14:03:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8D14AC433D6; Mon, 14 Nov 2022 14:03:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668434586; bh=ZQFKFIqIqP3t6Xzc4YPRbr4vAQmSmgIvh8UjHkOiHMM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=H/GNe/Y9M+dpo3wX6AvTwWNpVVaZRCMe4iLLhI7VfWfRlgv8NNFSHSi0kPq97ze78 aw3QxaSl1VeIDYGxpCJbq+LRjOLMM85DbFyWuQYCNQ12kSGrc+cEiSKJ9MitOdxpgt hSzZG7AyvzhAPld5kAhJuLOwO185Udu7UEKEhKSMO54bH6eapSe05Z0t9zeXKHq2iv mQgGqZ7/s0zcQSXU9YlCu02FvdupLHzpisDSZuJUL9UzmOVUFTKZOSwOGjFY2NYGh9 Tmo5KpghqCCnOHNuUuA79Vc3ZPdPlhOQRUrj+EmPzs4S+BjJTHMSOMnfWMdfnQ0mCK AHGF6FEpgwG9A== Date: Mon, 14 Nov 2022 14:02:58 +0000 From: Lee Jones To: Aidan MacDonald Cc: Krzysztof Kozlowski , mani@kernel.org, cristian.ciocaltea@gmail.com, wens@csie.org, tharvey@gateworks.com, cw00.choi@samsung.com, brgl@bgdev.pl, mazziesaccount@gmail.com, orsonzhai@gmail.com, baolin.wang@linux.alibaba.com, zhang.lyra@gmail.com, jernej.skrabec@gmail.com, samuel@sholland.org, linux-kernel@vger.kernel.org, linux-actions@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev Subject: Re: [PATCH 05/18] mfd: max14577: Replace irqchip mask_invert with unmask_base Message-ID: References: <20221112151835.39059-1-aidanmacdonald.0x0@gmail.com> <20221112151835.39059-6-aidanmacdonald.0x0@gmail.com> <03b94d20-05a6-71fb-61e4-00889f5aa64d@linaro.org> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Mon, 14 Nov 2022, Aidan MacDonald wrote: > > Krzysztof Kozlowski writes: > > > On 12/11/2022 16:18, Aidan MacDonald wrote: > >> Remove use of the deprecated mask_invert flag. Inverted mask > >> registers (where a '1' bit enables an IRQ) can be described more > >> directly as an unmask register. > >> > >> Signed-off-by: Aidan MacDonald > >> --- > >> drivers/mfd/max14577.c | 7 ++----- > >> 1 file changed, 2 insertions(+), 5 deletions(-) > > > > Mention this is a resend or provide a changelog for v2. > > Most of these patches are resends, but they're so trivial it seems > pointless to mention that fact. There are no changes from v1. How are people supposed to know the difference between "no change" and "there have been lots of changes, but I forgot to add a change-log"? :) Nothing wrong with: v1 -> v2: No code changes > > Acked-by: Krzysztof Kozlowski > > > > Best regards, > > Krzysztof -- Lee Jones [李琼斯]