From: Andrew Lunn <andrew@lunn.ch>
To: "Jernej Škrabec" <jernej.skrabec@gmail.com>
Cc: "Maxime Ripard" <mripard@kernel.org>,
"Chen-Yu Tsai" <wens@csie.org>, "Clément Bœsch" <u@pkh.me>,
"Willy Liu" <willy.liu@realtek.com>,
"Rob Herring" <robh+dt@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: Re: [PATCH] arm64: dts: sun50i: h5: NanoPI Neo 2: phy-mode rgmii-id
Date: Tue, 31 Aug 2021 22:53:24 +0200 [thread overview]
Message-ID: <YS6WxHtJtNDaBxqz@lunn.ch> (raw)
In-Reply-To: <1746741.3t3T1tWQfl@kista>
> True, but then again, DT is a bit special, since it's not used only by Linux.
> It's shared at least with BSDs and U-Boot, which most likely have independent
> driver implementation. That's why it's good to have DT fixes referencing DT
> related commits. As you said, DT described HW wrong.
>
> Looking at past Allwinner related DT commits regarding this issue, we were not
> totally consistent. Most of them reference commit where emac node was
> introduced in DT. But I also found a couple of commits which indeed have fixes
> tag for bbc4d71d6354.
All true, and it is not a big deal if it does go back further. I don't
care, we can let the Allwinner Maintainer decide. Ah, that is you :-)
I just want to try to keep it simple for somebody who is contributing
their first Linux kernel patch. If it is good enough, i say accept it,
and we can do a bit more education on the second contribution.
Andre
next prev parent reply other threads:[~2021-08-31 20:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-30 15:16 [PATCH] arm64: dts: sun50i: h5: NanoPI Neo 2: phy-mode rgmii-id Clément Bœsch
2021-08-30 20:49 ` Jernej Škrabec
2021-08-30 21:25 ` Clément Bœsch
2021-08-31 20:17 ` Jernej Škrabec
2021-08-30 21:50 ` Andrew Lunn
2021-08-31 19:53 ` Jernej Škrabec
2021-08-31 20:53 ` Andrew Lunn [this message]
2021-09-01 15:31 ` Jernej Škrabec
2021-09-03 9:21 ` Maxime Ripard
2021-09-05 0:20 ` [PATCH v2] arm64: dts: allwinner: h5: NanoPI Neo 2: Fix ethernet node Clément Bœsch
2021-09-05 0:42 ` Andrew Lunn
2021-09-06 8:03 ` Maxime Ripard
2021-08-30 21:52 ` [PATCH] arm64: dts: sun50i: h5: NanoPI Neo 2: phy-mode rgmii-id Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YS6WxHtJtNDaBxqz@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=jernej.skrabec@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=mripard@kernel.org \
--cc=robh+dt@kernel.org \
--cc=u@pkh.me \
--cc=wens@csie.org \
--cc=willy.liu@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox