ARM Sunxi Platform Development
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: "Clément Bœsch" <u@pkh.me>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Maxime Ripard <mripard@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
	Willy Liu <willy.liu@realtek.com>,
	netdev@vger.kernel.org, linux-sunxi@lists.linux.dev,
	devicetree@vger.kernel.org
Subject: Re: sunxi H5 DTB fix for realtek regression
Date: Mon, 30 Aug 2021 15:51:25 +0200	[thread overview]
Message-ID: <YSziXfll/p/5OrOv@lunn.ch> (raw)
In-Reply-To: <YSwr6YZXjNrdKoBZ@ssq0.pkh.me>

On Mon, Aug 30, 2021 at 02:52:57AM +0200, Clément Bœsch wrote:
> Hi,
> 
> Commit bbc4d71d63549bcd003a430de18a72a742d8c91e ("net: phy: realtek: fix
> rtl8211e rx/tx delay config") broke the network on the NanoPI NEO 2 board
> (RTL8211E chip).
> 
> Following what was suggested by Andrew Lunn for another hardware¹, I tried
> the following diff:
> 
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo2.dts b/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo2.dts
> index 02f8e72f0cad..05486cccee1c 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo2.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo2.dts
> @@ -75,7 +75,7 @@ &emac {
>         pinctrl-0 = <&emac_rgmii_pins>;
>         phy-supply = <&reg_gmac_3v3>;
>         phy-handle = <&ext_rgmii_phy>;
> -       phy-mode = "rgmii";
> +       phy-mode = "rgmii-id";
>         status = "okay";
>  };
> 
> 
> ...which fixed the issue. This was tested on v5.11.4 but the patch applies
> cleanly on stable so far.
> 
> I'm sorry for not sending a proper patch: I unfortunately have very little
> clue about what I'm doing here so it's very hard for me to elaborate a
> proper commit description.

Hi Clément

You are not too far away from a proper patch. I can either guide you,
if you want to learn, or the allwinner maintainer can probably take
your work and finish it off.

     Andrew

  reply	other threads:[~2021-08-30 14:18 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-30  0:52 sunxi H5 DTB fix for realtek regression Clément Bœsch
2021-08-30 13:51 ` Andrew Lunn [this message]
2021-08-30 14:35   ` Clément Bœsch
2021-08-30 15:05     ` Andrew Lunn
2021-08-30 15:21       ` Clément Bœsch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YSziXfll/p/5OrOv@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=hkallweit1@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-sunxi@lists.linux.dev \
    --cc=mripard@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=u@pkh.me \
    --cc=wens@csie.org \
    --cc=willy.liu@realtek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox