From: Mark Brown <broonie@kernel.org>
To: Samuel Holland <samuel@sholland.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>, Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev
Subject: Re: [PATCH 2/2] regulator: sun20i: Add support for Allwinner D1 LDOs
Date: Mon, 1 Aug 2022 17:03:33 +0100 [thread overview]
Message-ID: <Yuf5VQNrBHi7xG81@sirena.org.uk> (raw)
In-Reply-To: <20220801044758.12679-2-samuel@sholland.org>
[-- Attachment #1: Type: text/plain, Size: 461 bytes --]
On Sun, Jul 31, 2022 at 11:47:58PM -0500, Samuel Holland wrote:
> +static const struct regulator_desc sun20i_d1_analog_ldo_descs[] = {
> + {
> + .name = "aldo",
> + .supply_name = "vdd33",
> + .of_match = "aldo",
> + .ops = &sun20i_d1_analog_ldo_ops,
> + .type = REGULATOR_VOLTAGE,
> + .owner = THIS_MODULE,
> + .n_voltages = BIT(3),
I'm really unconvinced that using BIT() is clearer than just writing the
number of voltages directly as a number.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-08-01 16:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-01 4:47 [PATCH 1/2] regulator: dt-bindings: Add Allwinner D1 LDOs Samuel Holland
2022-08-01 4:47 ` [PATCH 2/2] regulator: sun20i: Add support for " Samuel Holland
2022-08-01 16:03 ` Mark Brown [this message]
2022-08-01 13:43 ` [PATCH 1/2] regulator: dt-bindings: Add " Rob Herring
2022-08-01 17:27 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yuf5VQNrBHi7xG81@sirena.org.uk \
--to=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jernej.skrabec@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=robh+dt@kernel.org \
--cc=samuel@sholland.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox