From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-001ae601.pphosted.com (mx0a-001ae601.pphosted.com [67.231.149.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 533921E1A17; Tue, 17 Dec 2024 10:37:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=67.231.149.25 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734431825; cv=none; b=E98UtSjRIN/fD23aijLKNvifeeL78vBcvInkv2A00cQjW1I89hB6u2/sVapw4ZWu44guBKLaKBh13ic75cmOeAPKj59XO45M1hdo2OMAqEYj0V10cOOXtaIZ/ZMG0qZRlZXwl7W9U7eGBUrCTSYyPrwKyXgH/P31CWcdikHSW8o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734431825; c=relaxed/simple; bh=O8dKluOujhFZHtu4NC9kbCIEXTbQRJR5JMVk02v4L/I=; h=Date:From:To:CC:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=l7Puj91OT7We2+468DvAIQQRP7dBrQcTmUTBmF7BULN/ni1Wv+uQJV3h9bW6usXCaiDTSLq49RlcVsgsmws3p+Ndo7j1gfMHTOViNK5il6R1x7Ed7Zv+Ddqyls5IA+W4jUOV9ezec9iDpYDZJGoZsGX31mxp0/L0BTe/EkETi5Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com; spf=pass smtp.mailfrom=opensource.cirrus.com; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b=JHyqdCnA; arc=none smtp.client-ip=67.231.149.25 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b="JHyqdCnA" Received: from pps.filterd (m0077473.ppops.net [127.0.0.1]) by mx0a-001ae601.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4BH4pZxb025779; Tue, 17 Dec 2024 04:36:26 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=PODMain02222019; bh=DncSMB8awaOalGRsmX KLNqehj2Q8AYTF94wrCAJZets=; b=JHyqdCnAmk49Rks7tVDdl3Y0WoutMvr9mB x3iG4Gih0mGgeaQ7b7y6YZuqiBWOeWqniSGkkhacOVcylwjh8Ais2tnzOBK/LMn4 L0mw7++y/sEhaKUgqkptQ2STbN8qQslOWHFUNPyAGAbUW95HpYe45bEj6R2MacLE dr3Wr5bd/vBehFbMarGrAwhRCuKkSl17WHMrxdePJ6CkIqY7VVHogsI1yu/xu+jW Wa2jZzHOPe9mMk1J+kcKIRKz7s9P5ZOc7MRlf0NKePCETF34apari5BqsJ3qElvv wKRhesX/OXcQJ4j4tQh4kn7cFQdc5GKOyJmpynrAUNV3yzmMWYUg== Received: from ediex02.ad.cirrus.com ([84.19.233.68]) by mx0a-001ae601.pphosted.com (PPS) with ESMTPS id 43h8a237vd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 17 Dec 2024 04:36:26 -0600 (CST) Received: from ediex02.ad.cirrus.com (198.61.84.81) by ediex02.ad.cirrus.com (198.61.84.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.13; Tue, 17 Dec 2024 10:36:23 +0000 Received: from ediswmail9.ad.cirrus.com (198.61.86.93) by anon-ediex02.ad.cirrus.com (198.61.84.81) with Microsoft SMTP Server id 15.2.1544.13 via Frontend Transport; Tue, 17 Dec 2024 10:36:23 +0000 Received: from opensource.cirrus.com (ediswmail9.ad.cirrus.com [198.61.86.93]) by ediswmail9.ad.cirrus.com (Postfix) with ESMTPS id B0265820248; Tue, 17 Dec 2024 10:36:23 +0000 (UTC) Date: Tue, 17 Dec 2024 10:36:22 +0000 From: Charles Keepax To: Wolfram Sang CC: , Alexandre Belloni , Yiting Deng , Xianwei Zhao , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Nicolas Ferre , Claudiu Beznea , Benson Leung , Guenter Roeck , Support Opensource , Paul Cercueil , Vladimir Zapolskiy , Piotr Wojtaszczyk , Chanwoo Choi , Krzysztof Kozlowski , Neil Armstrong , Kevin Hilman , "Jerome Brunet" , Martin Blumenstingl , Eddie Huang , Sean Wang , Matthias Brugger , AngeloGioacchino Del Regno , Orson Zhai , Baolin Wang , Chunyan Zhang , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , "Vincent Shih" , Thierry Reding , Jonathan Hunter , Michal Simek , , , , , , , , , , , Subject: Re: [PATCH] rtc: use boolean values with device_init_wakeup() Message-ID: References: <20241217071331.3607-2-wsa+renesas@sang-engineering.com> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20241217071331.3607-2-wsa+renesas@sang-engineering.com> X-Proofpoint-ORIG-GUID: ZFiaGqpxjixZfdP0EJY2r8mb04vfd9VM X-Proofpoint-GUID: ZFiaGqpxjixZfdP0EJY2r8mb04vfd9VM X-Proofpoint-Spam-Reason: safe On Tue, Dec 17, 2024 at 08:13:26AM +0100, Wolfram Sang wrote: > device_init_wakeup() second argument is a bool type. Use proper boolean > values when calling it to match the type and to produce unambiguous code > which is easier to understand. > > Signed-off-by: Wolfram Sang > --- For the old Wolfson parts: Reviewed-by: Charles Keepax Thanks, Charles