From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 58E0C2770B for ; Tue, 25 Feb 2025 09:40:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740476429; cv=none; b=pyJZbWKkIys8GDll96UwbwhgJn4LF++CoSDvnyHm/XCOw5Tbhx2yo4Lcm6jtB66b3GOqIfryVY3GZuapbwA3MZJLdxw1rDj5YuDanBgKUcPwrkqddgDeHhzlpArrafyzyAySsWitlhOHEHQoMy+4ACgpvZCtF/tPmHiQ1oD5Bek= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740476429; c=relaxed/simple; bh=9MeSK15KTX1GpVUkanLg3jxBL8S+QzQcHgh3wTNK8Oc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=pGHh8o02fSoUAjxEA+t6hCazMEZTeiTKp48s9BI9K8KngjBtCubxFfjOpCYLE7fiPbXX6nAajhkuNrR/V5GdBM/9pRGaRI0IODALRBgFQ87rsXyHn3O6MWOOBzaHY6oi5LVpGJX9RdG8peyCEy6+ao1MZcRmweEJwfQaXmF2O3M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=Kmcl2aJp; arc=none smtp.client-ip=192.198.163.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Kmcl2aJp" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1740476428; x=1772012428; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=9MeSK15KTX1GpVUkanLg3jxBL8S+QzQcHgh3wTNK8Oc=; b=Kmcl2aJpA8oTw4fmvSTARNwxKw4RfMtg8KiIzu5L8TjtN3NHhaVvOAeW 1aiWkdHYvukahe/cJQu59P6YYyE93Y4EjXZ95CQ2VPMaH1uIocrksq35T yzlKkFg4aluazGEyai0pQ3miAtYH2gixnT6RiT2GryCaYYopBhQSWYiLV uKGZECihTCtVbQwsj5VpNSFJO4M/yEfxh4f0GKDPpCMAAtK08kom+k6iE HXNbN5RZoKfxumaif+gTSlrcHAHD0EL2ph1fxCb1/RQzpewlgvI3l9cuN 5c9bNQ06bRaXLIm6HJ/F2JIkq5wHtORhdODrh9QolAi0xWNfj044YghFB A==; X-CSE-ConnectionGUID: zhfg6r20RiWTEfbrygdf7w== X-CSE-MsgGUID: A2qJkCjDR6KcID8KEee6vA== X-IronPort-AV: E=McAfee;i="6700,10204,11355"; a="40510228" X-IronPort-AV: E=Sophos;i="6.13,313,1732608000"; d="scan'208";a="40510228" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Feb 2025 01:40:27 -0800 X-CSE-ConnectionGUID: wuPiuA/zQd22MTq7/2Oa3Q== X-CSE-MsgGUID: 1/aed8HrRI+DCsOedLJWuQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,224,1728975600"; d="scan'208";a="117267075" Received: from kuha.fi.intel.com ([10.237.72.152]) by orviesa008.jf.intel.com with SMTP; 25 Feb 2025 01:40:18 -0800 Received: by kuha.fi.intel.com (sSMTP sendmail emulation); Tue, 25 Feb 2025 11:40:16 +0200 Date: Tue, 25 Feb 2025 11:40:16 +0200 From: Heikki Krogerus To: Matti Vaittinen Cc: Matti Vaittinen , Jonathan Cameron , Lars-Peter Clausen , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andy Shevchenko , Daniel Scally , Sakari Ailus , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Lad Prabhakar , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Hugo Villeneuve , Nuno Sa , David Lechner , Javier Carrasco , Guillaume Stols , Olivier Moysan , Dumitru Ceclan , Trevor Gamblin , Matteo Martelli , Alisa-Dariana Roman , Ramona Alexandra Nechita , AngeloGioacchino Del Regno , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev Subject: Re: [PATCH v4 02/10] property: Add device_get_child_node_count_named() Message-ID: References: <29ec24f1498392cafbecc0e0c0e23e1ce3289565.1740421248.git.mazziesaccount@gmail.com> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <29ec24f1498392cafbecc0e0c0e23e1ce3289565.1740421248.git.mazziesaccount@gmail.com> Hi, > +/** > + * device_get_child_node_count_named - number of child nodes with given name > + * > + * Scan device's child nodes and find all the nodes with a specific name and > + * return the number of found nodes. Potential '@number' -ending for scanned > + * names is ignored. Eg, > + * device_get_child_node_count(dev, "channel"); > + * would match all the nodes: > + * channel { }, channel@0 {}, channel@0xabba {}... > + * > + * @dev: Device to count the child nodes for > + * > + * Return: the number of child nodes with a matching name for a given device. > + */ > +unsigned int device_get_child_node_count_named(const struct device *dev, > + const char *name) > +{ > + struct fwnode_handle *child; > + unsigned int count = 0; > + > + device_for_each_child_node(dev, child) > + if (fwnode_name_eq(child, "channel")) s/"channel"/name/ ? > + count++; > + > + return count; > +} > +EXPORT_SYMBOL_GPL(device_get_child_node_count_named); I did not check how many users are you proposing for this, but if there's only one, then IMO this should not be a global function yet. It just feels to special case to me. But let's see what the others think. thanks, -- heikki