Re: [PATCH 3/4] Input: sun4i-ts: drop of_match_ptr for ID table

Jernej Škrabec
2023-03-14T20:05:02Z

Dne nedelja, 12. marec 2023 ob 14:15:13 CET je Krzysztof Kozlowski napisal(a):
> The driver can match only via the DT table so the table should be always
> used and the of_match_ptr does not have any sense (this also allows ACPI
> matching via PRP0001, even though it might not be relevant here). This
> also fixes !CONFIG_OF error:
>
> drivers/input/touchscreen/sun4i-ts.c:392:34: error: ‘sun4i_ts_of_match’
> defined but not used [-Werror=unused-const-variable=]
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> drivers/input/touchscreen/sun4i-ts.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>

Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com>

Best regards,
Jernej

> diff --git a/drivers/input/touchscreen/sun4i-ts.c
> b/drivers/input/touchscreen/sun4i-ts.c index 1117fba30020..577c75c83e25
> 100644
> --- a/drivers/input/touchscreen/sun4i-ts.c
> +++ b/drivers/input/touchscreen/sun4i-ts.c
> @@ -400,7 +400,7 @@ MODULE_DEVICE_TABLE(of, sun4i_ts_of_match);
> static struct platform_driver sun4i_ts_driver = {
> .driver = {
> .name = "sun4i-ts",
> - .of_match_table = of_match_ptr(sun4i_ts_of_match),
> + .of_match_table = sun4i_ts_of_match,
> },
> .probe = sun4i_ts_probe,
> .remove = sun4i_ts_remove,