From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2054.outbound.protection.outlook.com [40.107.220.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E9F41097B; Tue, 8 Aug 2023 13:00:16 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I1hjE6IaP90TCitxaPNkWNsJ3UId0Ajm0CtnUi/+Soo2tLcr2La9Rx2ayzYRrbLD1zKQhwOhovnlkIFWBpFekcDnrxMO7pf2Xam4gI05JFtCjTTUlfs+6fg18LUERt6w58raTMciMCD2FBhDvQdlB7PMMZlh4G+P8VTM3uGhcNZpV1lWg1D63lsAQXNmCc6R8FqURqPRI/yoP+uQAPWZCuqK3YWp8bZz8ck3PfEDOoN4Rotakh9WlMWC/ymbZVJfwFgmM46wjPKgi9uqWhx0zSM0+XwLxwgut7j8TCDtl7lJ4CwjluQfYWlC2CTG/YYMVs7GgfQADbfBWKDMnmeYwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aodyOVhOuHu9bvMhfT504eiJCVe2QReDyr/8PDGRRUM=; b=QXV0k1K0OYQIKtlB4Sxr127laQiHafXopYozO0BDh6YEjnoMl+o5Nf7ytuWfbNUPf9DvaniAikPKMD7Zcf3pGiNl+mokhOwKrphjLjNUJVS36WVibd9Iuk0vkJ9crSzX5rUv3u5VEUTZUkFRK86dK/eFAT8B5WFV2sisZwnBkInyV6cjWiZDsFIaYrAAI0bxAa1X3tK6IwY9nXOEK+YlHHbId8k3zz2myWUr5fLm09cpQBQ8Y/pHzJF0eQ4hdrxQV9cNugQop34PGvVwiBa0zZica9+LR75kKyednWtxeDDnO8jY1MSGyAP7+PymwFdIOMeKEgOpxFnY21yU+tj+rA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aodyOVhOuHu9bvMhfT504eiJCVe2QReDyr/8PDGRRUM=; b=qQXiIvhjccFMH5M1hdsuJkEtxkq30+pAkfcXiOmAfPd0RY9hyf43izufgVBLMQtUEQvYSnch69LGhTZgArrJJhtHOyR/oRm3R1FXDs1byW5jO7Q9tjpB10n8G2O8BjQgTeoA3mWz45vvIvRKf5Ei/AnmkwL2VGkdqC49I4kaLpn1ceHSDQhgNGiVIeyltfYlaNLfDP2ya9JFt26hMwUO4jcH9wb6oFHDC02A8fPe7AND917rIvcAyxlkJGq7OcIurcF1CFnYerzh27+Udleh4mbfOOBWwT0z4b4vVJaOhSrtZL5uJrsJ1chv0/k8LdZx4T81MFmbVMQzq/f3pjeTHw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from LV2PR12MB5869.namprd12.prod.outlook.com (2603:10b6:408:176::16) by CY8PR12MB8244.namprd12.prod.outlook.com (2603:10b6:930:72::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.27; Tue, 8 Aug 2023 13:00:14 +0000 Received: from LV2PR12MB5869.namprd12.prod.outlook.com ([fe80::5111:16e8:5afe:1da1]) by LV2PR12MB5869.namprd12.prod.outlook.com ([fe80::5111:16e8:5afe:1da1%6]) with mapi id 15.20.6652.026; Tue, 8 Aug 2023 13:00:13 +0000 Date: Tue, 8 Aug 2023 10:00:11 -0300 From: Jason Gunthorpe To: Marek Szyprowski Cc: Chen-Yu Tsai , Joerg Roedel , Baolin Wang , David Woodhouse , Heiko Stuebner , iommu@lists.linux.dev, Jernej Skrabec , linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-sunxi@lists.linux.dev, Orson Zhai , Robin Murphy , Samuel Holland , Chen-Yu Tsai , Will Deacon , Chunyan Zhang , Alex Williamson , Lu Baolu Subject: Re: [PATCH v2 00/10] Refine the locking for dev->iommu_group Message-ID: References: <0-v2-b0417f84403e+11f-iommu_group_locking_jgg@nvidia.com> <7483d18e-d06f-53eb-92af-beed50674ab0@samsung.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <7483d18e-d06f-53eb-92af-beed50674ab0@samsung.com> X-ClientProxiedBy: BL6PEPF00013E13.NAMP222.PROD.OUTLOOK.COM (2603:10b6:22e:400:0:1001:0:14) To LV2PR12MB5869.namprd12.prod.outlook.com (2603:10b6:408:176::16) Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LV2PR12MB5869:EE_|CY8PR12MB8244:EE_ X-MS-Office365-Filtering-Correlation-Id: 5b4d5eb6-4af9-4ea6-9a24-08db980f6784 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: n1im6lIdKhx8CSO+lBPYKPM/UjY6xqIzhfilZNrmz2GcaLfFIf4INsC5ayZzfQVa4z08QX8yq8DhxJSOgjK6wLKdGpdmNqTcjz6Akgs9magC34A/RARpd9fzSH8ug6tQjWu2UHaKXHgw7T4FHn2RwAbvkWuJARDBtZbSL6fTFijOJRcHnPYabLN1qCcRPI3/fanDbvtUrOQB8H9176Y/X7fAP3GrOKHkKkT0i9RtsKyQj2dtEHMM4VbDWlMCXK0Se8udzK4BF3FMgJSVJ9a4brbI0LrrTzdT2Z6Dg9erhZFsCGoA5WN3eBCqDRgvVl0hNkm7/5An6UozyGdOcREeOESDlYx+V+jqxfuY4lYvIn0h0xHCSaKX3GP7fob4PcOEVVJQs9oL4n07Z/2S5Y1O6oP+B29cxawr/ODiP6pFpSJlYAS5ERjq8NpioH7qaL/M30LwCL6fBPbneaiIUImkO2crjU7ot0Q4ULC7nrXwRzqjiSw/zRM/wceK3ZFDcYTVMERwGcqPSsYllY7tRixdFbUPYdbfcUrysWMQ78Ry0ELbrJYTBFAu4fJJnQvRpzRdB3Y7YAUuCM9zvXv0QmZgeyD+273D/8k01TCYgR/0jio= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:LV2PR12MB5869.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(346002)(396003)(376002)(366004)(39860400002)(136003)(451199021)(186006)(1800799003)(7416002)(8676002)(8936002)(5660300002)(4326008)(41300700001)(316002)(83380400001)(86362001)(2906002)(6916009)(6512007)(966005)(6486002)(2616005)(53546011)(26005)(6506007)(36756003)(66946007)(66476007)(66556008)(478600001)(54906003)(38100700002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QnAzOEZURzJqN2pwN1lPaDZGUlRtZlBqWDhIcURreEVSTkNKMlp6bjhwYzZI?= =?utf-8?B?V21Fb2J6UVlVNG5BNFZUZTdkQkNySTVFWjVJbkc4blFBU00xM2tVZWxraGNG?= =?utf-8?B?Q2JYMG1lQStoNmd0WDhWeXhQN1g2V1RSZlE5ZmxYbXBxaUJ5cmhzMmlxRk4v?= =?utf-8?B?ekF5YytpSUUzcWNQalg3cUFMUmJ2TzFSTFJQamdDL3pjalZkb1lIRjZ6TlZ6?= =?utf-8?B?T3QxNHp4U1BEYzlXRFV3Uk1zaExtblN0aFJqMkVBL1JoQVZkWFdsN3ErT0Nz?= =?utf-8?B?ZmtKODFKSFkyZm1WOWVoQmg1MGlXcE5ZNll4UmtiU1VwTVNKVmJ2SHFHa1R6?= =?utf-8?B?akkwaXI5U202M21qZDNQOW5qSXFGL3FkV2x5R3VYNmRDaEc3Sis4MDNDek9Z?= =?utf-8?B?UXMvcVFlMXlYSFhDaWV1Sm1aT2dUWU9OSXI5UGgyRmRncUVScDZzYkVLNEdk?= =?utf-8?B?UDlMVmZFd0hTc1lLN2xod3hEQ1NyUk5EWTM3UUhqUFlhaXpCS1QveVhJTExC?= =?utf-8?B?d1phNTI0WEhLL3J0a1FnMDJkOFhTNTQrRmFJditHN1lGQU9VVjJSa1RBdE4v?= =?utf-8?B?dVU2L0sweDhjQW5hcTQvL3NxMTdmMVkzVXozNXJJSm9ISEJST3puQVhTYWgy?= =?utf-8?B?WUUzTGlSUmY0NENKYU9kS0lzRE0za0MveWpnOTVxK2pQUnVzSkc3QkFBK2FE?= =?utf-8?B?Q0g3UksrM3E2SDN4RktGWnp5dWlTNUs5L3kraU02ajBIUENYOFdXK05QUUlC?= =?utf-8?B?MnpPSjBYRUVOcS9FZ29DUjkrZEtXblQyK2RWMlBHbmJ2VmpDWUZRWXVJR3dj?= =?utf-8?B?eldpTW1ESExqcmFCdmk1WVpDVmUzSVpKaDkxMVJTTDVhMlQ2SldHdTUzbG5h?= =?utf-8?B?TkdLZktrRy9OQURBRmFBVFVXT1dsbVgzWWR1b0prTmd2NldMUFdmWUw3dlNP?= =?utf-8?B?dzRDMFdjbHZYUEJtOW1QQmxPRXVPVGZHS2FHLzZLUXJ0N0x5R3YvMmRDZW1P?= =?utf-8?B?WE9tRGR4Q3JlMDdaaE1EYk1XOEgveHM3RDd2Qit4ZWgvQytFMm9ialZkTjRJ?= =?utf-8?B?S2JHbVpacE91VGhsM2J3dGg2R3ZaRS9WQitVVnI4V3lCdDFLQmUvQ29PNVQ5?= =?utf-8?B?NE56S0RjckZMR2dId1dpSXlvS2VvWUlrOTdwaFY1RzkrSmo3R1poNDZTOS9B?= =?utf-8?B?a0JPblBJQjdSckJzWXY1T08yaC8wR2NaaHZweUZpQXUweVh1ei82K2hJWGZU?= =?utf-8?B?R1dWcHBUSjhEOXRrRjlkekJWQ3RIK0FzVVI3RUhGM2o0QjdVeU52a1pSbHJ6?= =?utf-8?B?RUNLcUJhRXpNYUlLRjVMZk5aSnpDZ1BUOVNnMFJ6T1ZEQlMySm1KUE5SY3Bi?= =?utf-8?B?ZDhHWVpPbDA2Y1E5TWM0TzBuV1NGWmdkclQ4Snh6OHVlMFhVMDBnb2FYZ3pp?= =?utf-8?B?STRiK25uSUFIWWJrcGpyQ2hzMHZabDl5UHhsbEExcGlKTXB1TGRXWVBNbEFl?= =?utf-8?B?WWdSVVJnMTNhRzI4S1gxTEg0ZjRrZkVoZ2xLaHpPVlBTa2U4U2F5MjZjSUFh?= =?utf-8?B?V0hGTWczQ2xKbk5ibGpYN2lsZTBlK0RNZjNrYU9IVWk1TUk4alZXKzJ5aHJs?= =?utf-8?B?RjFOZTA0SEl3MGhmeVFXSzdNNi9kZGd6Q2hSZWpWbjBQVldvUGFyUnBSQnVJ?= =?utf-8?B?MzBJYXlmRzlwSmc1NGp5WjVlR1hoR281U0s2c05lL3BZUWpENUEyOHVrckNT?= =?utf-8?B?U2dhdFZSbzZ6Z2l4bFc0bTAxOGtpbkltak9SQ0NuZ0VBcTZEcDMzVFc0anNC?= =?utf-8?B?S0Y2MFp4U1ZZaXJCYStzL2RXTXh3UURabWJnelFQRlZySjVrbDN3WUxtblZS?= =?utf-8?B?WTJDRGRJOGFiNWJTRVdmbzJ6SEJRUHFVbHdxeUVwYXFWMXFoN21xUkZYQUVM?= =?utf-8?B?eis1WkRyTXM5UkNhdmpwV05pVkMvVjYzdHFLVmw1TS8vU2dZenA2ZGFvLzV2?= =?utf-8?B?d1oreGZjcjNidVdWK2FWclllSnl3WUNCVE85MGorSkd6aE9qdFU2UkQvZlNu?= =?utf-8?B?TThkTE9MeGJnS2p1Q1pydHFEaEpETzduMXpWbWFzSXo1K3oyVG45Y0Q4Wlg2?= =?utf-8?Q?pxg1CcEXqCx9JE+ekj9fk0/HK?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5b4d5eb6-4af9-4ea6-9a24-08db980f6784 X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Aug 2023 13:00:13.8501 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: y4p7+miHUMSSh6uPDizKMH4e7TiSwsTRZFmz//cb6X4VRsj7q6uZr4fnC3s742Rt X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB8244 On Tue, Aug 08, 2023 at 02:32:48PM +0200, Marek Szyprowski wrote: > Hi, > > On 08.08.2023 12:31, Chen-Yu Tsai wrote: > > Hi, > > > > On Mon, Aug 7, 2023 at 8:54 PM Joerg Roedel wrote: > >> On Mon, Jul 31, 2023 at 02:50:23PM -0300, Jason Gunthorpe wrote: > >>> Jason Gunthorpe (10): > >>> iommu: Remove useless group refcounting > >>> iommu: Add a lockdep assertion for remaining dev->iommu_group reads > >>> iommu: Add generic_single_device_group() > >>> iommu/sun50i: Convert to generic_single_device_group() > >>> iommu/sprd: Convert to generic_single_device_group() > >>> iommu/rockchip: Convert to generic_single_device_group() > >>> iommu/ipmmu-vmsa: Convert to generic_single_device_group() > >>> iommu/omap: Convert to generic_single_device_group() > >>> iommu: Complete the locking for dev->iommu_group > >>> iommu/intel: Fix missing locking for show_device_domain_translation() > >>> > >>> drivers/iommu/intel/debugfs.c | 34 ++++---- > >>> drivers/iommu/iommu.c | 155 +++++++++++++++++++++------------ > >>> drivers/iommu/ipmmu-vmsa.c | 22 ++--- > >>> drivers/iommu/omap-iommu.c | 30 +------ > >>> drivers/iommu/omap-iommu.h | 2 +- > >>> drivers/iommu/rockchip-iommu.c | 22 +---- > >>> drivers/iommu/sprd-iommu.c | 24 +---- > >>> drivers/iommu/sun50i-iommu.c | 29 ++---- > >>> include/linux/iommu.h | 3 + > >>> 9 files changed, 138 insertions(+), 183 deletions(-) > >> Applied, thanks for the nice cleanup! > > This series seems to cause a hung task during boot on MediaTek platforms. > > It hangs with next-20230808. Reverting the 10 commits from this series > > makes the system boot up again. > > I confirm that next-20230808 is broken on ARM 32bit based Exynos boards > too. Boards lock up very early during boot. I will try to investigate > this soon. Any of the drivers that use platform device as the iommu_device will have a problem, please try: https://lore.kernel.org/linux-iommu/ZNIz%2FNVLb6WqqvQx@nvidia.com/ Jason