From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f44.google.com (mail-lf1-f44.google.com [209.85.167.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 072E98F52 for ; Tue, 22 Aug 2023 09:26:16 +0000 (UTC) Received: by mail-lf1-f44.google.com with SMTP id 2adb3069b0e04-4ffa248263cso6579094e87.2 for ; Tue, 22 Aug 2023 02:26:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692696375; x=1693301175; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=snw1DaEvTLglNmKWe5Qce4LHWKg43CbSW3JkoNbMXJ0=; b=XiXIuii02P5pSjXkR+wQ0pKRVSpsQstyOfKddLRnfUJb5HzDpWU0T9Lx/jHH+Qxkt2 oiBKZt4zdbBdH+qfbeMtvOpLZrTexyrebSfx57iVe94e9r2on2aP8OuwY21/rERQzQno TzpqAik5K1Nkx0eiAxq8pkt9a+5Phv5o60UybgQz4bL3+dyFTpqTnXx9drjaCnvoKyVq uNvwWoiJk5Msoi0M+Jz2pdqNV1vO3M3UUmn+SpKoCnh3v3vrtr3AoA/yi451f0c9Cxhl RenI6d7gS3jTyvilxhrFMvR3iKeHkqZbyrA4VfcKENMamsXDepNeQh/cy+avNyR2gUJR 8Few== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692696375; x=1693301175; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=snw1DaEvTLglNmKWe5Qce4LHWKg43CbSW3JkoNbMXJ0=; b=FqMTabKk+BAz4rxiZ4hNslRpXuPm7VolnwdpAIGoRXTsJUXYCFY4rWFAtGLd8kCJ4y eorD4NJazgGdcY/OyGogAoP1NNCCLmDrj26oatBuCRQ92am69sPgQ/gF7qW02F1hSUiO 6lJKNNb6s5m7pf8xFU7d8BeQYAa/fB48RSeokAe5DHu1giqx1URIlcExTuJnFf6rFAgc 4i82l00Pm5GWtLRh9V07mk0OLn91VTthcdmuzCSISInFJP2635fQXtdBrR9TzyqGgIED R+d73B056hPPTRQSXVRBg9/tWGBCxzUICvfiOU9UE6AbWiE1iEhwmmosQOd6t6JcscVk 332A== X-Gm-Message-State: AOJu0YxENLCKhyKH1vI6raBQDjcTvGIUuztLC2wA8h3GR9J25NQiNkCZ gjzXrWMtmWP9BXDihMEPxVE= X-Google-Smtp-Source: AGHT+IH0eg8a5KtlFVvbBYLuL38D3pN+Vqfg1Lgf5Kl+i/B3hhTqgj1n3Ui4j6vOyIxo6gIttJrKVg== X-Received: by 2002:ac2:5f0a:0:b0:4fa:ad2d:6c58 with SMTP id 10-20020ac25f0a000000b004faad2d6c58mr5033971lfq.61.1692696374699; Tue, 22 Aug 2023 02:26:14 -0700 (PDT) Received: from localhost ([2a05:3580:f312:6c00:826c:ae47:61a7:8af8]) by smtp.gmail.com with ESMTPSA id l14-20020ac24a8e000000b004ff8a466ed3sm2102918lfp.130.2023.08.22.02.26.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Aug 2023 02:26:14 -0700 (PDT) Date: Tue, 22 Aug 2023 12:26:13 +0300 From: Andrey Skvortsov To: Pavel Machek Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Kees Cook , Tony Luck , "Guilherme G. Piccoli" , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, Jarrah Gosbell , Arnaud Ferraris Subject: Re: [PATCH] arm64: dts: pinephone: Add pstore support for PinePhone A64 Message-ID: Mail-Followup-To: Andrey Skvortsov , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Kees Cook , Tony Luck , "Guilherme G. Piccoli" , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, Jarrah Gosbell , Arnaud Ferraris References: <20230724213457.24593-1-andrej.skvortzov@gmail.com> <20230821160817.GA2227@bug> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230821160817.GA2227@bug> Hi Pavel, On 23-08-21 18:08, Pavel Machek wrote: > Hi! > > > This patch reserves some memory in the DTS and sets up a > > pstore device tree node to enable pstore support. > > > > Signed-off-by: Andrey Skvortsov > > > > Gbp-Pq: Topic pinephone > > Gbp-Pq: Name 0161-arm64-dts-pinephone-Add-pstore-support-for-PinePhone.patch > > --- > > .../boot/dts/allwinner/sun50i-a64-pinephone.dtsi | 16 ++++++++++++++++ > > 1 file changed, 16 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi > > index 87847116ab6d..84f9410b0b70 100644 > > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi > > @@ -19,6 +19,22 @@ aliases { > > serial0 = &uart0; > > }; > > > > + reserved-memory { > > + #address-cells = <1>; > > + #size-cells = <1>; > > + ranges; > > + > > + pstore_mem: ramoops@61000000 { > > + compatible = "ramoops"; > > + reg = <0x61000000 0x100000>; > > + record-size = <0x20000>; > > + console-size = <0x20000>; > > + ftrace-size = <0x20000>; > > + pmsg-size = <0x20000>; > > + ecc-size = <16>; > > + }; > > + }; > > dts is supposed to be for hardware description, but this is really policy decision. > > Should we have something like "any dram is suitable for pstore"....? Thanks for the review. I'll add into commit message more details why this address was picked. -- Best regards, Andrey Skvortsov