From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out198-173.us.a.mail.aliyun.com (out198-173.us.a.mail.aliyun.com [47.90.198.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6CFDE4696 for ; Thu, 21 Dec 2023 02:21:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sjterm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sjterm.com X-Alimail-AntiSpam:AC=CONTINUE;BC=0.08253946|-1;CH=green;DM=|CONTINUE|false|;DS=CONTINUE|ham_regular_dialog|0.759945-0.00196268-0.238092;FP=0|0|0|0|0|-1|-1|-1;HT=ay29a033018047199;MF=fuyao@sjterm.com;NM=1;PH=DS;RN=16;RT=16;SR=0;TI=SMTPD_---.VpJwiCT_1703125249; Received: from localhost(mailfrom:fuyao@sjterm.com fp:SMTPD_---.VpJwiCT_1703125249) by smtp.aliyun-inc.com; Thu, 21 Dec 2023 10:20:50 +0800 Date: Thu, 21 Dec 2023 10:20:49 +0800 From: fuyao To: Andre Przywara Cc: fuyao , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Alexandre TORGUE , Enric Balletbo i Serra , Baruch Siach , Paul Barker , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH RESEND] ARM: dts: sun8i: r40: open the regulator aldo1 Message-ID: Mail-Followup-To: Andre Przywara , fuyao , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Alexandre TORGUE , Enric Balletbo i Serra , Baruch Siach , Paul Barker , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org References: <20231220150400.0f32e2a5@donnerap.manchester.arm.com> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231220150400.0f32e2a5@donnerap.manchester.arm.com> Organization: work_work_work On Wed, Dec 20, 2023 at 03:04:00PM +0000, Andre Przywara wrote: > On Wed, 20 Dec 2023 16:18:43 +0800 > fuyao wrote: > > Hi, > > > the aldo1 is connect regulator pin which power the TV. > > What do you mean with that? That ALDO1 is connected to VCC-TVOUT and/or > VCC-TVIN on the R40 SoC? The ALDO1 is connected to VCC-TVOUT on the R40 Soc. > > > The USB core use TV ref as reference Voltage. > > The USB core in the SoC? So pin VCC-USB, which requires 3.3V, the same > voltage as the TV pins? > Which means this doesn't really have much to do with TV, it's just that > USB and also "TV" are supplied by ALDO1? The internal USB PHY requires a reference voltage. It seems that in order to save costs, the reference voltage of the TVOUT module is used. > > > Signed-off-by: fuyao > > --- > > arch/arm/boot/dts/allwinner/sun8i-r40-feta40i.dtsi | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/arch/arm/boot/dts/allwinner/sun8i-r40-feta40i.dtsi b/arch/arm/boot/dts/allwinner/sun8i-r40-feta40i.dtsi > > index 9f39b5a2bb35..8906170461df 100644 > > --- a/arch/arm/boot/dts/allwinner/sun8i-r40-feta40i.dtsi > > +++ b/arch/arm/boot/dts/allwinner/sun8i-r40-feta40i.dtsi > > @@ -42,6 +42,13 @@ &pio { > > vcc-pg-supply = <®_dldo1>; > > }; > > > > +®_aldo1 { > > + regulator-always-on; > > So did USB never work before, with the DT as in mainline? > The USB can work, but is unstable. Occasionally disconnected because of the D+/D- electrical characteristics. > For always-on regulators it would be good to see some rationale why this > cannot be referenced by its consumer. If it is really supplying the USB > core, that would be a reason, because we don't have a good way of > describing this. > > > + regulator-min-microvolt = <3300000>; > > + regulator-max-microvolt = <3300000>; > > + regulator-name = "vcc-aldo1"; > > Regulators should be named after their users, so use something like: > regulator-name = "vcc-3v3-tv-usb"; > thanks. > That then also serves as documentation of why this is always on. > > Cheers, > Andre > > > +}; > > + > > ®_aldo2 { > > regulator-always-on; > > regulator-min-microvolt = <1800000>; >