From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f172.google.com (mail-pg1-f172.google.com [209.85.215.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EF84E249E8 for ; Fri, 12 Apr 2024 21:03:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712955835; cv=none; b=BW/Ek5M807G6FrDKhUBlaGaGObDEyjlGinnEtQZ96nH7d/gPiPADG2xG8atIEcvh3RHMAFCt69/2D/3ucSh0COLdlOEeJA83xombUEFPpKGowwRA7nBy+cQJdIx2gDWI/J9TT9ULxPCb9rIIjmNJi3wWyECyAyppzcdIjCZ3UcE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712955835; c=relaxed/simple; bh=ZPOljcUhl22FSoHSYfFQzaj3bojSiqS5Tmdy9qXTodQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Ri1WAdgzBKNJyr0XUdLY2Azh3upiQmgHBSBZC5DbKIMALln+h+A4AuNl2B0S8cn9DfnUpj8I9vt+7/rLJNvYo9TCgyV/ou1hfosUm8x9ZeB8wfafjkFunhtpos3U0FHTgvmryQpj3J7VZ0MeXP1o+U0QwNwIZcbFFBu+g0WILHc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=rivosinc.com; spf=pass smtp.mailfrom=rivosinc.com; dkim=pass (2048-bit key) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.b=rcqXkgBq; arc=none smtp.client-ip=209.85.215.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rivosinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.b="rcqXkgBq" Received: by mail-pg1-f172.google.com with SMTP id 41be03b00d2f7-5d3907ff128so1024259a12.3 for ; Fri, 12 Apr 2024 14:03:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1712955833; x=1713560633; darn=lists.linux.dev; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=aSqmAxropEDfNCG6GQv7daH4xVtfVuXJw9jJz7os0WU=; b=rcqXkgBq6pkWRVgVVGIXkIBRwAJOPexWVcC+a4v38/FlogRM/Tn8kEyWfNbmXuFV+F RqMIA2KdgOW32tgTxK1A13hvo/d2Q62Y+LM4uezuZuCZXdv5YZHuCg/SWL5CysGy0TRd A0Z2ce8F9nN4OYT+MmcQMr8ZisTgY6EWQAh3GNx4ZlesNwFTo3b2mmSyT5X3QLryT9Vz T5eBlwYG5ZpPuPNSGCtPU1oBGvHkqPxWgOCcH1QQclNPFdqCwV7N8F9VH1/IXYKS5BCU eVWcNSbGBYqTVi8nFP+UIJES/qyoqrtxPoQ5YqwCb0Z1VaSOOeFe/KAFwh4/C508w25I 3yIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712955833; x=1713560633; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=aSqmAxropEDfNCG6GQv7daH4xVtfVuXJw9jJz7os0WU=; b=A/WZ7ez0KBfc9T9rFbGDaIkPUvku9rBk/9x8MouAdmI8iH8poaLr/bxAzqwudx2eSO KWKrAfNMDY0h7679Yg5A4BCe+DP/ejII6PfpnHpMe/j0hw4J09ZzzfEWdox76eEnTrCH iXsxDE/3/nLWtos5CyDFaibSBbUmd08y6mOjcad7EsPY5gFOQ97frVZSiC66WXsF7Ik3 ak4x9cVmynJL3iRcVv4ethtfhbUiIC1ZcxgkfRIPn0F4yA5lIFahuRrDlJSDJ/kKRF4h xQHFsmOlkxJo+MRFHqJDsTxIHcti5ClCQ2E/y2U/xMiVl1pGCerPLRmI4bIu4iiB+XOi OU2w== X-Forwarded-Encrypted: i=1; AJvYcCWbqQl2jkcKlNXgaz7c2sMqnFlm7lnSppC2sAXUjsTsRGRk8stdH2EaXCAKHK/k83XARdAaaomOLPnlz5MZLCckuG+vQQRVPGQx/HI= X-Gm-Message-State: AOJu0YwJoiQTOxjiUdmkyaCEZie5eTuYqEvmY4jQHXYoPXkDSeSbpv+J 62ic6vNvwAOoJ+Ki9Ejpz4bK8TtFPKPxMmYcCpdLGwdJYbcIEK3BQedsmIn8MUQ= X-Google-Smtp-Source: AGHT+IEOtfsrGOvmFZobDx+oZIyIEnB1hXJRroDDmgDp9zSXNOuvWX12AXzBQuPGec6sDnDDhBi5CQ== X-Received: by 2002:a17:902:e5c6:b0:1e2:adce:9139 with SMTP id u6-20020a170902e5c600b001e2adce9139mr5386874plf.44.1712955833353; Fri, 12 Apr 2024 14:03:53 -0700 (PDT) Received: from ghost ([50.145.13.30]) by smtp.gmail.com with ESMTPSA id f18-20020a170902ce9200b001e511acfd0esm3424844plg.140.2024.04.12.14.03.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Apr 2024 14:03:52 -0700 (PDT) Date: Fri, 12 Apr 2024 14:03:48 -0700 From: Charlie Jenkins To: Conor Dooley Cc: Conor Dooley , Rob Herring , Krzysztof Kozlowski , Paul Walmsley , Palmer Dabbelt , Albert Ou , Guo Ren , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Evan Green , =?iso-8859-1?Q?Cl=E9ment_L=E9ger?= , Jonathan Corbet , Shuah Khan , linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Palmer Dabbelt , linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH 08/19] riscv: Introduce vendor variants of extension helpers Message-ID: References: <20240411-dev-charlie-support_thead_vector_6_9-v1-0-4af9815ec746@rivosinc.com> <20240411-dev-charlie-support_thead_vector_6_9-v1-8-4af9815ec746@rivosinc.com> <20240412-dwarf-shower-5a7300fcd283@wendy> <20240412-drab-french-55d8ff2c8cfa@spud> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240412-drab-french-55d8ff2c8cfa@spud> On Fri, Apr 12, 2024 at 09:40:03PM +0100, Conor Dooley wrote: > On Fri, Apr 12, 2024 at 10:43:02AM -0700, Charlie Jenkins wrote: > > On Fri, Apr 12, 2024 at 12:49:57PM +0100, Conor Dooley wrote: > > > On Thu, Apr 11, 2024 at 09:11:14PM -0700, Charlie Jenkins wrote: > > > > Create vendor variants of the existing extension helpers. If the > > > > existing functions were instead modified to support vendor extensions, a > > > > branch based on the ext value being greater than > > > > RISCV_ISA_VENDOR_EXT_BASE would have to be introduced. This additional > > > > branch would have an unnecessary performance impact. > > > > > > > > Signed-off-by: Charlie Jenkins > > > > > > I've not looked at the "main" patch in the series that adds all of the > > > probing and structures for representing this info yet beyond a cursory > > > glance, but it feels like we're duplicating a bunch of infrastructure > > > here before it is necessary. The IDs are all internal to Linux, so I'd > > > rather we kept everything in the same structure until we have more than > > > a handful of vendor extensions. With this patch (and the theadpmu stuff) > > > we will have three vendor extensions which feels like a drop in the > > > bucket compared to the standard ones. > > > > It is not duplicating infrastructure. If we merge this into the existing > > infrastructure, we would be littering if (ext > RISCV_ISA_VENDOR_EXT_BASE) > > in __riscv_isa_extension_available. This is particularily important > > exactly because we have so few vendor extensions currently so this check > > would be irrelevant in the vast majority of cases. > > That's only because of your implementation. The existing vendor extension > works fine without this littering. That's another thing actually, you > forgot to convert over the user we already have :) Oh right, I will convert them over. The fundemental goal of this patch is to allow a way for vendors to support their own extensions without needing to populate riscv_isa_ext. This is to create separation between vendors so they do not impact each other. xlinuxenvcfg does not fit into this scheme however. This scheme assumes that a hart cannot have multiple vendors which that extension breaks. xlinuxenvcfg is really filling a hole in the standard isa that is applicible to all vendors and does not appear in the device tree so it is okay for that to live outside this scheme. > > > It is also unecessary to push off the refactoring until we have some > > "sufficient" amount of vendor extensions to deem changing the > > infrastructure when I already have the patch available here. This does > > not introduce any extra overhead to existing functions and will be able > > to support vendors into the future. > > Yeah, maybe that's true but this was my gut reaction before reading the > other patch in detail (which I've still yet to do). - Charlie