From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f178.google.com (mail-pg1-f178.google.com [209.85.215.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6A47FDF60 for ; Wed, 1 May 2024 16:46:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714581972; cv=none; b=ajp3DgaujFmmG5hiTapSneI4F+9TcoINeU1My8u3F2rt6PqfvWDs7C+wNxwwDIqEO1//er7o535ZfAj8kKANTBiDca+CM7gV2Otz4UiO519LqON/jSUlRYaDowv5rG2L5wpvtWmLaDHcjqzlyMj0VWh/MIsHgwhx2wRPW7t+1dI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714581972; c=relaxed/simple; bh=krDJy1o6nlqSmGBvYIH6mBjLgfXcSgWyqs7rmpIkNjI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=BXCmBUeScsUch5n5ZfIDXO+RZlwsdcSvx4CuMVExZmfk9pxzBizZH5ENbtPsgjzeyULLIyr1HPFsxE+xQWhkBTsZURciM7zmvC9n5nfk6pQorXLJ3wUuyZKKH0mOY/H1MnCQJGccUSQIGJN8hKNnRNFw/I7NVUJuCTxTpQTDL40= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=rivosinc.com; spf=pass smtp.mailfrom=rivosinc.com; dkim=pass (2048-bit key) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.b=zcbwiTKL; arc=none smtp.client-ip=209.85.215.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rivosinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.b="zcbwiTKL" Received: by mail-pg1-f178.google.com with SMTP id 41be03b00d2f7-5dcc4076c13so745987a12.0 for ; Wed, 01 May 2024 09:46:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1714581970; x=1715186770; darn=lists.linux.dev; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=HNAlEVQt8bQKb4hVjkj/tzVzfjylPjyKPm1CNtyCLJI=; b=zcbwiTKLmXqPMWpn6WwguLb8dy7R088w4td2AkzE/7OhdR3Jsa7lPAoosME6fGHSGp Xu1SZETfTd7u/hd+OErMh8ZbnprhAdCnWE5ijTTlVTH9Izle6R2zqqe27vq975w/Twue VpaDK9ZKopMELWlD/jOR6OpYmmESQQ/m6rttod0abVk4oDl2FZF+WuYNCc3evHl9Xa/h p84/8JvvQl2IlVi+i3dW64ErJl9WbgklTj4gatzI9C2XShjqDbNDuwQB98e3n5QuRpJ3 eE3ctF+3Nj5KNJVlHNbsKR+3uHy6i/x/0kvMUHNqMVMU/twZjTPHBofZDzYdrWasrlem YA6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714581970; x=1715186770; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=HNAlEVQt8bQKb4hVjkj/tzVzfjylPjyKPm1CNtyCLJI=; b=OArw3iaaDrqDQFd5b2oDWhSajmprRJ63jQW2969I5bJUg/ggInEq0nZaKM2nQjFE8Q vyhMd0GsiUCN599Hlqe2BUrMtL9xdEwRRG87qoC/itqG2sG/Okqbz4b83KAxCZXUt5kQ GkN3b99TfgB9WLs/oJjuqLY2R08rGwm6At/xuMcr0U3AxyWCXbgV5wsCsFJDGsCCmHuO ZqV4Rn+RZZ2LUnXLw3S0nWBF4SONxRmTdEjkk+AsQ1B38Lj0EYUNyShbKiLEMbAs45L5 IA4Q/i28fFRkKx6y1wYEtZ5K6oYo9qjdCk9G2xZtO02e8xrp7Kdhv1kmXCBBNEzmbvDf YrsQ== X-Forwarded-Encrypted: i=1; AJvYcCWC81tUwtY6hqN6s44y+rRQ97PSoBUw9bZyK9FtHwQadEMbhEx7jZOkwG56bggoMX4gr2x2SzZA0aJSCGkBWJlTtZ1SCf5DtGZmZhU= X-Gm-Message-State: AOJu0YzP7ZlAHfD6bP/swZ+eoXI6ZcINyhYKOvY80om5lJf3/ekKTtg7 f0PUNjtUWX7yRu/MuIsvU/ZSF61yju8eYm70VopCLOi8uM0TQjP9MMyYcF7JUJw= X-Google-Smtp-Source: AGHT+IH65t3T7Cre6ETXiixVNrR9oMbdBgpbTRkUxmtEpcotJ4qRMx/UYqqnRRVgQ7nCUV3kiM8/gw== X-Received: by 2002:a17:90a:c78f:b0:2a5:3f30:f5f6 with SMTP id gn15-20020a17090ac78f00b002a53f30f5f6mr274501pjb.20.1714581969579; Wed, 01 May 2024 09:46:09 -0700 (PDT) Received: from ghost ([2601:647:5700:6860:1dcc:e03e:dc61:895d]) by smtp.gmail.com with ESMTPSA id g2-20020a170902934200b001e25da6f2f2sm24328716plp.68.2024.05.01.09.46.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 May 2024 09:46:08 -0700 (PDT) Date: Wed, 1 May 2024 09:46:04 -0700 From: Charlie Jenkins To: Conor Dooley Cc: Rob Herring , Krzysztof Kozlowski , Paul Walmsley , Palmer Dabbelt , Albert Ou , Guo Ren , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Conor Dooley , Evan Green , =?iso-8859-1?Q?Cl=E9ment_L=E9ger?= , Jonathan Corbet , Shuah Khan , linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Palmer Dabbelt , linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v4 03/16] riscv: vector: Use vlenb from DT Message-ID: References: <20240426-dev-charlie-support_thead_vector_6_9-v4-0-b692f3c516ec@rivosinc.com> <20240426-dev-charlie-support_thead_vector_6_9-v4-3-b692f3c516ec@rivosinc.com> <20240501-showroom-rephrase-66c0929011b3@spud> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240501-showroom-rephrase-66c0929011b3@spud> On Wed, May 01, 2024 at 11:31:45AM +0100, Conor Dooley wrote: > On Fri, Apr 26, 2024 at 02:29:17PM -0700, Charlie Jenkins wrote: > > If vlenb is provided in the device tree, prefer that over reading the > > vlenb csr. > > > > Signed-off-by: Charlie Jenkins > > --- > > arch/riscv/include/asm/cpufeature.h | 2 ++ > > arch/riscv/kernel/cpufeature.c | 43 +++++++++++++++++++++++++++++++++++++ > > arch/riscv/kernel/vector.c | 12 ++++++++++- > > 3 files changed, 56 insertions(+), 1 deletion(-) > > > > diff --git a/arch/riscv/include/asm/cpufeature.h b/arch/riscv/include/asm/cpufeature.h > > index 347805446151..0c4f08577015 100644 > > --- a/arch/riscv/include/asm/cpufeature.h > > +++ b/arch/riscv/include/asm/cpufeature.h > > @@ -31,6 +31,8 @@ DECLARE_PER_CPU(struct riscv_cpuinfo, riscv_cpuinfo); > > /* Per-cpu ISA extensions. */ > > extern struct riscv_isainfo hart_isa[NR_CPUS]; > > > > +extern u32 riscv_vlenb_of; > > + > > void riscv_user_isa_enable(void); > > > > #if defined(CONFIG_RISCV_MISALIGNED) > > diff --git a/arch/riscv/kernel/cpufeature.c b/arch/riscv/kernel/cpufeature.c > > index 3ed2359eae35..8158f34c3e36 100644 > > --- a/arch/riscv/kernel/cpufeature.c > > +++ b/arch/riscv/kernel/cpufeature.c > > @@ -35,6 +35,8 @@ static DECLARE_BITMAP(riscv_isa, RISCV_ISA_EXT_MAX) __read_mostly; > > /* Per-cpu ISA extensions. */ > > struct riscv_isainfo hart_isa[NR_CPUS]; > > > > +u32 riscv_vlenb_of; > > + > > /** > > * riscv_isa_extension_base() - Get base extension word > > * > > @@ -648,6 +650,42 @@ static int __init riscv_isa_fallback_setup(char *__unused) > > early_param("riscv_isa_fallback", riscv_isa_fallback_setup); > > #endif > > > > +static int riscv_homogeneous_vlenb(void) > > Without a verb, this function name is rather odd. > Maybe has_riscv_homogeneous_vlenb() is better. > > +{ > > + int cpu; > > + u32 prev_vlenb = 0; > > + u32 vlenb; > > + > > + for_each_possible_cpu(cpu) { > > + struct device_node *cpu_node; > > + > > + cpu_node = of_cpu_device_node_get(cpu); > > + if (!cpu_node) { > > + pr_warn("Unable to find cpu node\n"); > > + continue; > > Hmm, if we fail to find the cpu node, then shouldn't we be returning an > error? Yes, I will change that. > > > + } > > + > > + if (of_property_read_u32(cpu_node, "riscv,vlenb", &vlenb)) { > > + of_node_put(cpu_node); > > + > > + if (prev_vlenb) > > + return -1; > > Can you return an errno here and below please? > Sounds good. > > + continue; > > + } > > + > > + if (prev_vlenb && vlenb != prev_vlenb) { > > + of_node_put(cpu_node); > > + return -1; > > + } > > + > > + prev_vlenb = vlenb; > > + of_node_put(cpu_node); > > + } > > + > > + riscv_vlenb_of = vlenb; > > + return 0; > > +} > > + > > void __init riscv_fill_hwcap(void) > > { > > char print_str[NUM_ALPHA_EXTS + 1]; > > @@ -671,6 +709,11 @@ void __init riscv_fill_hwcap(void) > > pr_info("Falling back to deprecated \"riscv,isa\"\n"); > > riscv_fill_hwcap_from_isa_string(isa2hwcap); > > } > > + > > + if (riscv_homogeneous_vlenb() < 0) { > > + pr_warn("RISCV_ISA_V only supports one vlenb on SMP systems. Please ensure that the riscv,vlenb devicetree property is the same across all CPUs. Either all CPUs must have the riscv,vlenb property, or none. If no CPUs in the devicetree use riscv,vlenb then vlenb will be probed from the vlenb CSR. Disabling vector.\n"); > > Oh dear, that's a bit unwieldy... I think you could get away with a far > more basic message - and you should be able to break this over lines, > adjacent string literals should get concatenated. > I'd probably say something like "unsupported heterogeneous vlen detected, > vector extension disabled", however we should actually check that the > vector extension has been detected on all CPUs and that kernel support > for vector is enabled before emitting a warning for this. Haha yeah I wanted to provide as much information as possible, but I will shorten it. I can add an if-statement to only run this code if check if V is contained in elf_hwcap. - Charlie > > Cheers, > Conor. > > > + elf_hwcap &= ~COMPAT_HWCAP_ISA_V; > > + } > > } > > > > /* > > diff --git a/arch/riscv/kernel/vector.c b/arch/riscv/kernel/vector.c > > index 6727d1d3b8f2..e04586cdb7f0 100644 > > --- a/arch/riscv/kernel/vector.c > > +++ b/arch/riscv/kernel/vector.c > > @@ -33,7 +33,17 @@ int riscv_v_setup_vsize(void) > > { > > unsigned long this_vsize; > > > > - /* There are 32 vector registers with vlenb length. */ > > + /* > > + * There are 32 vector registers with vlenb length. > > + * > > + * If the riscv,vlenb property was provided by the firmware, use that > > + * instead of probing the CSRs. > > + */ > > + if (riscv_vlenb_of) { > > + this_vsize = riscv_vlenb_of * 32; > > + return 0; > > + } > > + > > riscv_v_enable(); > > this_vsize = csr_read(CSR_VLENB) * 32; > > riscv_v_disable(); > > > > -- > > 2.44.0 > >