From: Andrey Skvortsov <andrej.skvortzov@gmail.com>
To: Chen-Yu Tsai <wens@csie.org>
Cc: Jernej Skrabec <jernej.skrabec@gmail.com>,
Samuel Holland <samuel@sholland.org>,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org,
Shoji Keita <awaittrot@shjk.jp>, Icenowy Zheng <icenowy@aosc.io>,
Andre Przywara <andre.przywara@arm.com>
Subject: Re: [PATCH 1/2] arm64: dts: sun50i-a64-pinephone: Add AF8133J to PinePhone
Date: Sun, 15 Sep 2024 13:12:50 +0300 [thread overview]
Message-ID: <ZuazIgLz5PP_Z8Cn@skv.local> (raw)
In-Reply-To: <CAGb2v65Laka+YaPyAecwxEhMkoodrXnDPn+UTwZUS_wsSBMzyg@mail.gmail.com>
Hi Chen-Yu Tsai,
On 24-09-09 16:08, Chen-Yu Tsai wrote:
> On Mon, Sep 9, 2024 at 5:48 AM Andrey Skvortsov
> <andrej.skvortzov@gmail.com> wrote:
> >
> > From: Icenowy Zheng <icenowy@aosc.io>
> >
> > New batches of PinePhones switched the magnetometer to AF8133J from
> > LIS3MDL because lack of ST components.
> >
> > Both chips use the same PB1 pin, but in different modes.
> > LIS3MDL uses it as an gpio input to handle interrupt.
> > AF8133J uses it as an gpio output as a reset signal.
> >
> > It wasn't possible at runtime to enable both device tree nodes and
> > detect supported sensor at probe time, because both drivers try to
> > acquire the same gpio in different modes.
> >
> > Device tree fixup will be done in firmware without introducing new board
> > revision and new dts.
>
> FYI I've been working on an in-kernel prober [1] for such alternative
> components. This does not require firmware support.
>
> [1] https://lore.kernel.org/all/20240904090016.2841572-1-wenst@chromium.org/
Thank you for the information.
I've tried to use in-kernel prober from your v7 patchset [1] on top of
-next and it worked without any changes to firmware.
Since there is still on-going review of your patches it looks like
it's to early to submit my changes for review. But I'm ready to test
your new patches.
[1] https://lore.kernel.org/all/20240911072751.365361-1-wenst@chromium.org/
--
Best regards,
Andrey Skvortsov
next prev parent reply other threads:[~2024-09-15 10:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-08 21:47 [PATCH 0/2] Fix magnetometers on PinePhone Andrey Skvortsov
2024-09-08 21:47 ` [PATCH 1/2] arm64: dts: sun50i-a64-pinephone: Add AF8133J to PinePhone Andrey Skvortsov
2024-09-09 8:08 ` Chen-Yu Tsai
2024-09-15 10:12 ` Andrey Skvortsov [this message]
2024-10-19 2:04 ` Chen-Yu Tsai
2024-11-05 19:51 ` Andrey Skvortsov
2024-11-06 2:31 ` Chen-Yu Tsai
2024-11-06 7:05 ` Andrey Skvortsov
2024-09-08 21:47 ` [PATCH 2/2] arm64: dts: sun50i-a64-pinephone: Add mount-matrix for PinePhone magnetometers Andrey Skvortsov
2024-11-07 15:26 ` [PATCH 0/2] Fix magnetometers on PinePhone Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZuazIgLz5PP_Z8Cn@skv.local \
--to=andrej.skvortzov@gmail.com \
--cc=andre.przywara@arm.com \
--cc=awaittrot@shjk.jp \
--cc=icenowy@aosc.io \
--cc=jernej.skrabec@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=samuel@sholland.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox