From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7EFCC1DE2DC for ; Mon, 28 Oct 2024 15:59:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.20 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730131191; cv=none; b=CpzA7ilvOpiN4mEBML1AWh9+539FNvRNGFOWUps8KxXP9lth6R0SkOnMeYCUlkT1HgbhrQmE38nGYXx65VSfkYslc9+heymYwbtxCHNJlc0hLdoH+HvatH+e+gM9pWYyfB/bXw1lWODQOYTDIIPoOP7w/CJwJjSi2GOcFTqMbIY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730131191; c=relaxed/simple; bh=M0le9V9Kdnc+SoqVOHgbafA8bV44ev7rfgdQq7f2H2o=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=doT5hbMDyFSCwUL9J+G5tEFhVldpQSB1eEFQ1EiJ0J0lJaUBUSiZdx3Q72DOBazjc2aYfgEA1GoV/fUmRPBXdXzzypuJxdH6KhLJCTuHWRVXdAJ0ZZyhEeBcjfm+aU/5QhtBrIbSNJFUvv9luO2Sny1U7B/jcx0OxVWkUR+3jQg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=IB/nJfof; arc=none smtp.client-ip=198.175.65.20 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="IB/nJfof" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1730131190; x=1761667190; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=M0le9V9Kdnc+SoqVOHgbafA8bV44ev7rfgdQq7f2H2o=; b=IB/nJfof77LIKLsuZkb4zT2V36lPGuOiV23y5dWu5o7pEnuBGM0SM07H b8gnDrqRqQdCTcRlInpxKOZ69zwEluCqmrq7pc+9jUBB2RUiO96JX/pHb zRn2nvRsXxPmww/x/8bMLqaDZR69z/IfZVKMWdV+696vw2fkM3dXgsv9h UMzpnq+gvN51+IOGDX+a8WRN6TQFYwHwW5p9uHQf3rU8DkiLNFWymrwuz 72V9KfW97sbpS05i7jVpVf1lHRPTv3ZVpnRMTXbTHQipEZCT2CLgoHslw 6/5MP29XtDYkBSCi7AdCt1/hsQ5bvuCv1tElhcAZPX2nwbSMG2RCdpkOI Q==; X-CSE-ConnectionGUID: aU3fg4YnQny9l9wb1J58kQ== X-CSE-MsgGUID: TWEq5QVBRei9CG1Gblewjg== X-IronPort-AV: E=McAfee;i="6700,10204,11222"; a="29506441" X-IronPort-AV: E=Sophos;i="6.11,199,1725346800"; d="scan'208";a="29506441" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Oct 2024 08:59:33 -0700 X-CSE-ConnectionGUID: iQc8wkRRTKWL3fpaCf50SQ== X-CSE-MsgGUID: ov8Po5UBSmyDzG3bh9zQUw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,239,1725346800"; d="scan'208";a="112480471" Received: from smile.fi.intel.com ([10.237.72.54]) by fmviesa001.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Oct 2024 08:59:28 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.98) (envelope-from ) id 1t5S9M-000000087nQ-3TE6; Mon, 28 Oct 2024 17:59:24 +0200 Date: Mon, 28 Oct 2024 17:59:24 +0200 From: Andy Shevchenko To: Aren Cc: Jonathan Cameron , Lars-Peter Clausen , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Kaustabh Chakraborty , =?iso-8859-1?B?QmFybmFi4XMgQ3rpbeFu?= , Ondrej Jirman , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, Dragan Simic , phone-devel@vger.kernel.org Subject: Re: [PATCH v3 5/6] iio: light: stk3310: log error if reading the chip id fails Message-ID: References: <20241028142000.1058149-1-aren@peacevolution.org> <20241028142000.1058149-6-aren@peacevolution.org> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Mon, Oct 28, 2024 at 11:29:35AM -0400, Aren wrote: > On Mon, Oct 28, 2024 at 04:45:35PM +0200, Andy Shevchenko wrote: > > On Mon, Oct 28, 2024 at 10:19:59AM -0400, Aren Moynihan wrote: > > > If the chip isn't powered, this call is likely to return an error. > > > Without a log here the driver will silently fail to probe. Common errors > > > are ENXIO (when the chip isn't powered) and ETIMEDOUT (when the i2c bus > > > isn't powered). > > > > The commit message does not explain why dev_err_probe() has been chosen > > and not simple dev_err(). > > This function is only called from stk3310_probe, and this condition > should propagate it's error, so it fits what dev_err_probe is designed > for. dev_err would be pretty much equivalent just longer, like this: > > if (ret < 0) { > dev_err(&client->dev, "failed to read chip it: %d\n", ret); > return ret; > } It's fine, the problem is the commit message in the patch. Please, update the commit message accordingly. -- With Best Regards, Andy Shevchenko