From: "Noralf Trønnes" <noralf@tronnes.org>
To: Maxime Ripard <maxime@cerno.tech>,
Samuel Holland <samuel@sholland.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Ben Skeggs <bskeggs@redhat.com>, Chen-Yu Tsai <wens@csie.org>,
David Airlie <airlied@linux.ie>,
Jani Nikula <jani.nikula@linux.intel.com>,
Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
Emma Anholt <emma@anholt.net>, Karol Herbst <kherbst@redhat.com>,
Lyude Paul <lyude@redhat.com>,
Thomas Zimmermann <tzimmermann@suse.de>,
Daniel Vetter <daniel@ffwll.ch>
Cc: "Dave Stevenson" <dave.stevenson@raspberrypi.com>,
"Hans de Goede" <hdegoede@redhat.com>,
nouveau@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
dri-devel@lists.freedesktop.org,
"Mateusz Kwiatkowski" <kfyatek+publicgit@gmail.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, "Dom Cobley" <dom@raspberrypi.com>,
"Phil Elwell" <phil@raspberrypi.com>,
"Geert Uytterhoeven" <geert@linux-m68k.org>,
"Noralf Trønnes" <noralf@tronnes.org>
Subject: Re: [PATCH v10 06/19] drm/modes: Add a function to generate analog display modes
Date: Thu, 24 Nov 2022 14:39:45 +0100 [thread overview]
Message-ID: <a3380bb8-65c7-9dd9-12ac-8558d03ff5c8@tronnes.org> (raw)
In-Reply-To: <20220728-rpi-analog-tv-properties-v10-6-256dad125326@cerno.tech>
Den 17.11.2022 10.28, skrev Maxime Ripard:
> Multiple drivers (meson, vc4, sun4i) define analog TV 525-lines and
> 625-lines modes in their drivers.
>
> Since those modes are fairly standard, and that we'll need to use them
> in more places in the future, it makes sense to move their definition
> into the core framework.
>
> However, analog display usually have fairly loose timings requirements,
> the only discrete parameters being the total number of lines and pixel
> clock frequency. Thus, we created a function that will create a display
> mode from the standard, the pixel frequency and the active area.
>
> Tested-by: Mateusz Kwiatkowski <kfyatek+publicgit@gmail.com>
> Signed-off-by: Maxime Ripard <maxime@cerno.tech>
>
> ---
I'm no domain expert so apart from the timing details which I can't
comment on, it looks fine. I personally advocated for a much simpler
solution for these NTSC and PAL modes, but AIUI this is part of a
grander plan to support devices with other timings.
Acked-by: Noralf Trønnes <noralf@tronnes.org>
next prev parent reply other threads:[~2022-11-24 13:39 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-17 9:28 [PATCH v10 00/19] drm: Analog TV Improvements Maxime Ripard
2022-11-17 9:28 ` [PATCH v10 01/19] drm/tests: client: Mention that we can't use MODULE_ macros Maxime Ripard
2022-11-17 11:54 ` Noralf Trønnes
2022-11-17 9:28 ` [PATCH v10 02/19] drm/connector: Rename legacy TV property Maxime Ripard
2022-11-17 9:28 ` [PATCH v10 03/19] drm/connector: Only register TV mode property if present Maxime Ripard
2022-11-17 9:28 ` [PATCH v10 04/19] drm/connector: Rename drm_mode_create_tv_properties Maxime Ripard
2022-11-17 9:28 ` [PATCH v10 05/19] drm/connector: Add TV standard property Maxime Ripard
2022-11-17 14:35 ` Mauro Carvalho Chehab
2022-11-17 14:53 ` Maxime Ripard
2022-11-24 13:33 ` Noralf Trønnes
2022-11-17 9:28 ` [PATCH v10 06/19] drm/modes: Add a function to generate analog display modes Maxime Ripard
2022-11-24 13:39 ` Noralf Trønnes [this message]
2022-11-17 9:28 ` [PATCH v10 07/19] drm/connector: Add a function to lookup a TV mode by its name Maxime Ripard
2022-11-17 9:28 ` [PATCH v10 08/19] drm/modes: Introduce the tv_mode property as a command-line option Maxime Ripard
2022-11-17 9:28 ` [PATCH v10 09/19] drm/modes: Properly generate a drm_display_mode from a named mode Maxime Ripard
2022-11-17 9:28 ` [PATCH v10 10/19] drm/client: Remove match on mode name Maxime Ripard
2022-11-17 9:28 ` [PATCH v10 11/19] drm/modes: Introduce more named modes Maxime Ripard
2022-11-17 9:28 ` [PATCH v10 12/19] drm/probe-helper: Provide a TV get_modes helper Maxime Ripard
2022-11-17 9:28 ` [PATCH v10 13/19] drm/atomic-helper: Add a TV properties reset helper Maxime Ripard
2022-11-17 9:28 ` [PATCH v10 14/19] drm/atomic-helper: Add an analog TV atomic_check implementation Maxime Ripard
2022-11-17 9:28 ` [PATCH v10 15/19] drm/vc4: vec: Use TV Reset implementation Maxime Ripard
2022-11-17 9:28 ` [PATCH v10 16/19] drm/vc4: vec: Check for VEC output constraints Maxime Ripard
2022-11-17 9:29 ` [PATCH v10 17/19] drm/vc4: vec: Convert to the new TV mode property Maxime Ripard
2022-11-17 9:29 ` [PATCH v10 18/19] drm/vc4: vec: Add support for more analog TV standards Maxime Ripard
2022-11-17 15:49 ` Mauro Carvalho Chehab
2022-11-17 17:14 ` Maxime Ripard
2022-11-21 20:30 ` Mateusz Kwiatkowski
2022-11-17 9:29 ` [PATCH v10 19/19] drm/sun4i: tv: Convert to the new TV mode property Maxime Ripard
2022-11-21 14:51 ` [PATCH v10 00/19] drm: Analog TV Improvements Daniel Vetter
2022-11-24 11:49 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a3380bb8-65c7-9dd9-12ac-8558d03ff5c8@tronnes.org \
--to=noralf@tronnes.org \
--cc=airlied@linux.ie \
--cc=bskeggs@redhat.com \
--cc=daniel@ffwll.ch \
--cc=dave.stevenson@raspberrypi.com \
--cc=dom@raspberrypi.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=emma@anholt.net \
--cc=geert@linux-m68k.org \
--cc=hdegoede@redhat.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=jernej.skrabec@gmail.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=kfyatek+publicgit@gmail.com \
--cc=kherbst@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=lyude@redhat.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=maxime@cerno.tech \
--cc=mripard@kernel.org \
--cc=nouveau@lists.freedesktop.org \
--cc=phil@raspberrypi.com \
--cc=rodrigo.vivi@intel.com \
--cc=samuel@sholland.org \
--cc=tvrtko.ursulin@linux.intel.com \
--cc=tzimmermann@suse.de \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox