Re: [PATCH next v3] board: sunxi: Add X96Q support

["J. Neuschäfer" <j.ne@posteo.net>]

On Thu, Jan 22, 2026 at 11:53:04PM +0000, Andre Przywara wrote:
> Hi,
> 
> thanks, that looks very good now. Just one tiny thing:
> 
> On 20/01/2026 15:20, J. Neuschäfer via B4 Relay wrote:
> > From: "J. Neuschäfer" <j.ne@posteo.net>
> > 
> > The X96Q is a set-top box with an H313 SoC, AXP305 PMIC, 1 or 2 GiB RAM,
> > 8 or 16 GiB eMMC flash, 2x USB A, Micro-SD, HDMI, Ethernet, audio/video
> > output, and infrared input.
[...]
> > +++ b/configs/x96q_defconfig
> > @@ -0,0 +1,26 @@
> > +CONFIG_ARM=y
> > +CONFIG_ARCH_SUNXI=y
> > +CONFIG_DEFAULT_DEVICE_TREE="allwinner/sun50i-h313-x96q"
> > +CONFIG_DRAM_CLK=600
> > +CONFIG_SPL=y
> > +CONFIG_DRAM_SUNXI_DX_ODT=0x03030303
> > +CONFIG_DRAM_SUNXI_DX_DRI=0x0e0e0e0e
> > +CONFIG_DRAM_SUNXI_CA_DRI=0x1f12
> > +CONFIG_DRAM_SUNXI_TPR0=0xc0001002
> > +CONFIG_DRAM_SUNXI_TPR2=0x00000100
> > +CONFIG_DRAM_SUNXI_TPR10=0x002f0107
> > +CONFIG_DRAM_SUNXI_TPR11=0xddddcccc
> > +CONFIG_DRAM_SUNXI_TPR12=0xeddc7665
> > +CONFIG_MACH_SUN50I_H616=y
> > +CONFIG_SUNXI_DRAM_H616_DDR3_1333=y
> 
> This misses -CONFIG_MMC_SUNXI_SLOT_EXTRA=2 here, was this deliberate? The DT
> mentions the eMMC, and you have CONFIG_SUPPORT_EMMC_BOOT below, so is this
> just on omission? Or did the eMMC not work?
> 
> If you can confirm, I can just add this while committing.

I forgot to test booting from eMMC. Indeed it doesn't work as is.
With CONFIG_MMC_SUNXI_SLOT_EXTRA=2 added, booting from eMMC works.


Thanks again!
J. Neuschäfer