From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6EC192F2A for ; Mon, 2 May 2022 16:57:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1651510628; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=K0Gq4g+r6nSFFN2UMiOU7agj8frQhJOC3wt5ScKN4WI=; b=EuaI6+8mGao7a8l+K63gjGBTuhOaz9qc/BGKNFHMEg40mW5WtgLZIF9RjoeRcIZLAO04Rc 5ZZmOh/tLkWmcpODSmYsqbE8j4iiDhq94ej36Wb0yZoAEft7kIIF9nW+S/54yO3gxlN4Hf uJl/Syqb7aElGuowD8ShM8d+LnU7+rU= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-625-uHe2OSrXMV6mQLkQVjphqg-1; Mon, 02 May 2022 12:57:07 -0400 X-MC-Unique: uHe2OSrXMV6mQLkQVjphqg-1 Received: by mail-wr1-f72.google.com with SMTP id p10-20020adfaa0a000000b0020c4829af5fso3250137wrd.16 for ; Mon, 02 May 2022 09:57:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=K0Gq4g+r6nSFFN2UMiOU7agj8frQhJOC3wt5ScKN4WI=; b=h/Zq3+5JIaAEbiF2k8knXj/+m2AJUe9V8rlHSmevslEE1bLogjhf9LECOiK/oT8Y/i vLyaKvN5745+hYnalxIYT9wmBVwszLcEZDnA/T36cBrHaCmZvL5Q5a6UPexTl5g0uVuc mQrWcXiMRDL6+J8JpEGlxMM6NNcuM19h/EQhxtkWK3dTr3eVcP+TZbQJIKUCUGNzRuGo YA9hlz02p3Amd4b5ZZylhd4SGYGKmONnHLiRHgQW7aCQasJqtWHQMEaBN7LFr1tIzf0o XaEi0c9/48DoBCoz9mdLOwaJmhQ0UsnKop5/JVsK8NRA4H7n/oYe6qHuG8DwNDzzH2ZV xG3A== X-Gm-Message-State: AOAM533QLv8rtFcIJB2706bx+sJrGJ8BcOxgVqKvon/6wVWst42MZMRk QhqcVyM3uKqk9v1oNZcwC+Fbs0tTrJ/dYLo6bb9N2KIY65BwHT8v2Tb8n36zDKxEo6nkhqEFmBO GL8oNNHlGL8J/eEa7d/++HlY= X-Received: by 2002:a05:600c:4f08:b0:391:fe3c:40e6 with SMTP id l8-20020a05600c4f0800b00391fe3c40e6mr78542wmq.34.1651510626176; Mon, 02 May 2022 09:57:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzBR5y6TmCRfu+8hzM0SQTGA4cZrpN3ZhuFriWyFUH2mb/ZbNn3olE2yOJI8bAuj+96a04yXQ== X-Received: by 2002:a05:600c:4f08:b0:391:fe3c:40e6 with SMTP id l8-20020a05600c4f0800b00391fe3c40e6mr78523wmq.34.1651510625948; Mon, 02 May 2022 09:57:05 -0700 (PDT) Received: from [192.168.1.129] ([92.176.231.205]) by smtp.gmail.com with ESMTPSA id r20-20020adfa154000000b0020c5253d8c7sm7273243wrr.19.2022.05.02.09.57.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 May 2022 09:57:05 -0700 (PDT) Message-ID: Date: Mon, 2 May 2022 18:57:04 +0200 Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH v2 2/3] drm/fb-helper: Rename preferred_bpp drm_fbdev_generic_setup() parameter To: Laurent Pinchart Cc: linux-kernel@vger.kernel.org, Thomas Zimmermann , Daniel Vetter , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-mediatek@lists.infradead.org, linux-mips@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev, spice-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org References: <20220502153900.408522-1-javierm@redhat.com> <20220502153900.408522-3-javierm@redhat.com> From: Javier Martinez Canillas In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=javierm@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 5/2/22 18:07, Laurent Pinchart wrote: > Hi Javier, > > Thank you for the patch. > > On Mon, May 02, 2022 at 05:38:59PM +0200, Javier Martinez Canillas wrote: >> By default the bits per pixel for the emulated framebuffer device is set >> to dev->mode_config.preferred_depth, but some devices need another value. >> >> Since this second parameter is only used by a few drivers, and to allow >> drivers to use it for passing other configurations when registering the >> fbdev, rename @preferred_bpp to @options and make it a multi-field param. >> >> The DRM_FB_OPTION() and DRM_FB_GET_OPTION() macros are provided to drivers >> for computing options bitfield values and getting the values respectively >> >> For now, only the DRM_FB_BPP option exists but other options can be added. >> >> Suggested-by: Thomas Zimmermann >> Signed-off-by: Javier Martinez Canillas >> Reviewed-by: Thomas Zimmermann >> Reviewed-by: Laurent Pinchart >> --- >> >> Changes in v2: >> - Rename DRM_FB_SET_OPTION() to DRM_FB_SET() and make more clear in the > > I assume you meant DRM_FB_OPTION() here, not DRM_FB_SET(). > >> kernel-doc what this macro does (Laurent Pinchart). >> Right, that's a typo. The patch description and content are correct though. I'll fix the patch history log in v3. -- Best regards, Javier Martinez Canillas Linux Engineering Red Hat