From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com [209.85.167.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 06FCA33CC for ; Tue, 16 Aug 2022 10:00:37 +0000 (UTC) Received: by mail-lf1-f42.google.com with SMTP id z6so14219218lfu.9 for ; Tue, 16 Aug 2022 03:00:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=NiqjZdaElPv0Moy0J0kc1e2plbktdvmbHILgFoEtkN0=; b=x+JEVq67Pgxsj6flc0kjfjNPIoXYPrJNovtiA9koO4BMEsg4+opIi+s1y1obKFPI9Q RAhO2dGD0vie3y2wBj+L5ti5PrJwBP48GbOXQrtaFWgVQdldzlnpxojBkSVzq85hskGd OT+QLlaw4f42MQUb+TSMvufxU+JEtSM0StxGuRV9CZSpsV4qpTecwCxOlF1H5ZC1zSL8 kqZ/nkA0UK5kZJseHHUJ7+8MP4ILZeWa9jdLkBbTmFzE4nzQ386JMPXIm45QjKxku9P4 DRmeQJkWUaxEYMzqA2ognq9H6iNVrD47ZUJOn5RV/YFoz52MYTgr8IyYQuYXtbahOg6F jlYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=NiqjZdaElPv0Moy0J0kc1e2plbktdvmbHILgFoEtkN0=; b=XCrwFfvo4OVImpoHaU+qP0SfFl7TC1IUXX0BHX0iv9E+1YApJS5/YarqP8BInWqVtH A7iZimRFKsm+P+clKBq+kfS79Rt7pU4YcNJmQNv5Vz1AKa2yppo3ABVNQE3aCFDl63oi 0PcT3tuzpSraGy/XiWvB91aBHt5tantQJ+rQeU2oeYT9j6QJRRFaCEhzSs1J6B6Ewe6F fVlAnOAFpy6u4AqUNufZEnA5bC/tytBTA7P/xvtSIoZAmn6Xz8dGrQ1MmoAfcDEjNJFQ cFtxRrMDHSl5PxMCVMecb1ex1zWwymxztUJH6kpFJ9e1FvVj3HHGiKVQb7T7XH8EXFRl y59Q== X-Gm-Message-State: ACgBeo0OPaxaeETOOWfJphO3igNNYatd+b0lPGl8wRzh2rXG41PMgkWe aOit4qB+fBKwUFxGtG9jHm+aHw== X-Google-Smtp-Source: AA6agR5J9MnoK1JzNnr2RzzIi4yHAdEmc5+JM9mzKRac2egPPP/6bbZQLUoxHKb/IDwxVOf9+ki2YA== X-Received: by 2002:a05:6512:3c93:b0:48c:dc60:4786 with SMTP id h19-20020a0565123c9300b0048cdc604786mr6701452lfv.208.1660644036069; Tue, 16 Aug 2022 03:00:36 -0700 (PDT) Received: from ?IPV6:2001:14bb:ae:539c:1782:dd68:b0c1:c1a4? (d15l54g8c71znbtrbzt-4.rev.dnainternet.fi. [2001:14bb:ae:539c:1782:dd68:b0c1:c1a4]) by smtp.gmail.com with ESMTPSA id c7-20020a056512324700b0048b01bd4dbasm1333291lfr.307.2022.08.16.03.00.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Aug 2022 03:00:35 -0700 (PDT) Message-ID: Date: Tue, 16 Aug 2022 13:00:33 +0300 Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH v3 1/4] regulator: dt-bindings: Add Allwinner D1 LDOs Content-Language: en-US To: =?UTF-8?Q?Heiko_St=c3=bcbner?= , Liam Girdwood , Mark Brown , Chen-Yu Tsai , Jernej Skrabec , Krzysztof Kozlowski , Rob Herring , linux-arm-kernel@lists.infradead.org Cc: Samuel Holland , Maxime Ripard , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev References: <20220815043436.20170-1-samuel@sholland.org> <20220815043436.20170-2-samuel@sholland.org> <4371868.Wku2Vz74k6@diego> From: Krzysztof Kozlowski In-Reply-To: <4371868.Wku2Vz74k6@diego> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 15/08/2022 18:32, Heiko Stübner wrote: > Am Montag, 15. August 2022, 06:34:32 CEST schrieb Samuel Holland: >> The Allwinner D1 SoC contains two pairs of in-package LDOs. One pair is >> for general purpose use. LDOA generally powers the board's 1.8 V rail. >> LDOB generally powers the in-package DRAM, where applicable. >> >> The other pair of LDOs powers the analog power domains inside the SoC, >> including the audio codec, thermal sensor, and ADCs. These LDOs require >> a 0.9 V bandgap voltage reference. The calibration value for the voltage >> reference is stored in an eFuse, accessed via an NVMEM cell. >> >> Neither LDO control register is in its own MMIO range; instead, each >> regulator device relies on a regmap/syscon exported by its parent. >> >> Signed-off-by: Samuel Holland >> --- >> >> Changes in v3: >> - Add "reg" property to bindings >> - Add "unevaluatedProperties: true" to regulator nodes >> - Minor changes to regulator node name patterns >> - Remove system-ldos example (now added in patch 3) >> >> Changes in v2: >> - Remove syscon property from bindings >> - Update binding examples to fix warnings and provide context >> >> .../allwinner,sun20i-d1-analog-ldos.yaml | 74 +++++++++++++++++++ >> .../allwinner,sun20i-d1-system-ldos.yaml | 37 ++++++++++ >> 2 files changed, 111 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/regulator/allwinner,sun20i-d1-analog-ldos.yaml >> create mode 100644 Documentation/devicetree/bindings/regulator/allwinner,sun20i-d1-system-ldos.yaml >> >> diff --git a/Documentation/devicetree/bindings/regulator/allwinner,sun20i-d1-analog-ldos.yaml b/Documentation/devicetree/bindings/regulator/allwinner,sun20i-d1-analog-ldos.yaml >> new file mode 100644 >> index 000000000000..d6964b44ef21 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/regulator/allwinner,sun20i-d1-analog-ldos.yaml >> @@ -0,0 +1,74 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/regulator/allwinner,sun20i-d1-analog-ldos.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Allwinner D1 Analog LDOs >> + >> +description: >> + Allwinner D1 contains a set of LDOs which are designed to supply analog power >> + inside and outside the SoC. They are controlled by a register within the audio >> + codec MMIO space, but which is not part of the audio codec clock/reset domain. >> + >> +maintainers: >> + - Samuel Holland >> + >> +properties: >> + compatible: >> + enum: >> + - allwinner,sun20i-d1-analog-ldos >> + >> + reg: >> + maxItems: 1 >> + >> + nvmem-cells: >> + items: >> + - description: NVMEM cell for the calibrated bandgap reference trim value >> + >> + nvmem-cell-names: >> + items: >> + - const: bg_trim > > aren't dashes "-" preferred over underscores "_" in > string names? > > Maybe even make this "bandgap-trim" for a bit more > explanatory naming? In node names yes. In strings, I think there is no preference. At least I am not aware of it. Best regards, Krzysztof