From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f178.google.com (mail-lj1-f178.google.com [209.85.208.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D9D8C38B7DE for ; Mon, 6 Apr 2026 21:23:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775510604; cv=none; b=M8leBYf2BRkLaqYMzKoqdYWTPox3hhQs3Ox2AoMUahiExhzaupVXMSAmxKdMFDJJMFB4UaK80UedUBprl8PsccQaPzfS9cI4wnhcMVKlxxMb4C1g1aZSZ4xlXW2DRhr8YLRAOd7Vnj1eWD1OOg67OrimVe72oTxHTiaT0GSZq7s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775510604; c=relaxed/simple; bh=tX3o9f7nD1vUlJVRpS/dXcDlEK/tjAUp+SSuZzHNZTA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=V6h6UrI0yfkKVEI+sjPHQMVownoHcY6owRsjw7Qvfb2axJ4owr+ZHnWMzA/1nwYlU7hPl46XJBTvSRdO4l0CpiMzgTkWo6McIvkYcYEN69Op6HB1Noj6I7xq/7/J8m8Tc/fPmlwdevzsVhGA88mb5bmvCmOG0AREcuqK4xfgAXU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cdeK5c8E; arc=none smtp.client-ip=209.85.208.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cdeK5c8E" Received: by mail-lj1-f178.google.com with SMTP id 38308e7fff4ca-38df11810abso16271901fa.1 for ; Mon, 06 Apr 2026 14:23:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775510601; x=1776115401; darn=lists.linux.dev; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=q6xJ/zDoOR7Os811YjMwToE+cggB6rQ02aG/lrQ8U/U=; b=cdeK5c8ExFheAPSZEbOKfFm9T+9NQBaNe7wNZ97vfHJmqZ8yA8cyd+7hiEfW/5+qxZ 65RCfC3KtbGmnnyF0NXEaMUunIgPc6Q6yU+PxYVLq6fW0rUBJDd1rIsrSvlJjlKhaspl 2PBVGLXBP6DmtyeisL9o0oaf6umWsHxrqCa18tnRTtw8uN3sltyaht5Q5mfMD7tjoZ9i hgSKK2M6Bepq+uRzHkg1jmd7OYU5eot8Fsn91G4dhriJUzfoh9eoiF1mp16w9l0QlWJo xa6BGiDdsQEtmxPJn/PBXD5KisqKjHoGxoIAcKf1J/Qg/93WpJJz6LRETpMtfspPx0Y0 ObzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775510601; x=1776115401; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=q6xJ/zDoOR7Os811YjMwToE+cggB6rQ02aG/lrQ8U/U=; b=jNRbLopEAGv9KAGCgsK6SlWkoDZVTJUV2R2bswhMGdBYAS1Id9+Nw3d2p70hJ7fPi1 hSWaT5mRRrFMcM8ob2MTFz6k7iLRZ08l7LJPQZlv78OQNvW4Q7QS1yJVsoddjlg2mtBF OBNqQ7zihLd91qyCT8lNGh/IfOT8LyYIVctW266bCJWKjK+yP07hRRx5eO5zi6443i5Q krMSdAct1KUACLWYzGAqXKITm1kf55ABe1g6QZYfU4LVxyf8GTH0HuG/3Ve25570sSgI pzgzbT3LfEfAwLZSJ6fnKp0w9jVLS/Leef9jDZHin6tcyzQyM/IHaODxsgGLqHwPelAu 9kVg== X-Forwarded-Encrypted: i=1; AJvYcCViVW00+gJD7TwYZC/na+479i3PsPyJ5nH3ig0Ba1KounWstmU0LSQke7WeuCgXxNAHCKW0rYsvgi6n7w==@lists.linux.dev X-Gm-Message-State: AOJu0YwdD9HtPRalqTGNIFyCQaIZTIdWlj1ic6t5WXBMwAnMBimT3w7c SoIipm+oCvG9gmaQLWfG+IBCMBDpnhzRyPHubU/g0/qzlB3Xr+JyKJe5 X-Gm-Gg: AeBDievkhVZScnMGIWuziqPC5RT0UsyxRJjFRRhfmKiDLxq6/7e5Nirzv+kHpzHqWD1 l3/oMFTHocZSevOkIwwGOBjSEI5vjwpgMeBpLjQJC3FT4weBZeQfRXsamMIwnPIUTbLqC6BgmzC zwobYC0srR9ODI2LMCLXMe/7GJzdPq9nTnTeTKVgvEOEAWF4y9doLbDuxV1DAJiI7Pr8I/gImdS xpxZ3W7guR5konirniKanSDPmdybAKzruADwUVn83FpHQ43541fHJRgZaqD4OHBEbUGEmLROu3f Eir6GXJXZquDjwPQcTgegPHevhMXMaWm4ysdjrRlWdexsPXqMrmFKIPpih/nspeA0jTt7NliCTD EtcjKtsHi/tE3vgmt8sQDkcEGS3maYD8NzK0QA4YDEq1ccVPfk8ThQZnsXYZuoR9wCI2Yrj42bh uLMTm4JItCGffEogoFbHJW8veRs04= X-Received: by 2002:a05:651c:1a0a:b0:38a:3498:e2f5 with SMTP id 38308e7fff4ca-38cd6e4f078mr57915391fa.15.1775510600748; Mon, 06 Apr 2026 14:23:20 -0700 (PDT) Received: from localhost ([94.19.228.143]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-38cd1fffb53sm32700151fa.16.2026.04.06.14.23.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Apr 2026 14:23:20 -0700 (PDT) Date: Tue, 7 Apr 2026 00:23:19 +0300 From: Andrey Skvortsov To: Dan Carpenter Cc: Maxime Ripard , Paul Kocialkowski , Mauro Carvalho Chehab , Greg Kroah-Hartman , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Hans Verkuil , linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] media: cedrus: Fix missing cleanup in error path Message-ID: Mail-Followup-To: Andrey Skvortsov , Dan Carpenter , Maxime Ripard , Paul Kocialkowski , Mauro Carvalho Chehab , Greg Kroah-Hartman , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Hans Verkuil , linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org References: <20260401191441.1217646-1-andrej.skvortzov@gmail.com> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Hi, On 26-04-02 16:09, Dan Carpenter wrote: > On Wed, Apr 01, 2026 at 10:14:40PM +0300, Andrey Skvortsov wrote: > > From: Samuel Holland > > > > From: Samuel Holland > > > > According to the documentation struct v4l2_fh has to be cleaned up with > > v4l2_fh_exit() before being freed. [1] > > > > 1. https://docs.kernel.org/driver-api/media/v4l2-fh.html > > > > I wish the commit message would say what the use visible effect of the > bug is. I looked at it and I don't think this patch hurts but I also > didn't necessarily see a that the original code had a user visible bug. > > I read the documentation but it wasn't as unambiguous as I'd prefer. > Thank you for the review. Currently there is no visible bug. v4l2_fh_exit() in this case only destroys mutex. But it may change in the future, when v4l2_fh_init/v4l2_fh_exit will be changed. I think the change maybe useful in this regard. I'll describe this in the commit message in v2 and resend it separately from the patch 2, that fixes actual problem. So this change may be skipped, if maintainers think it's not worth to apply. -- Best regards, Andrey Skvortsov