From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 80FD93F6C57 for ; Mon, 6 Jul 2026 07:20:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783322417; cv=none; b=UFw8AUlFJYVKcjPBDC+Geth8VjLi3xkO700UNtpv3QiNKHHDT/jti4aI9Dhg4Q/A8n32DpLqI+oJUGqyzVQS2TIp+syoczT8KZDSZTUC0h2Ui4j4SUwnU8rTvQsq1ZBPBODk8UK1iFIHbH6KR7y3tzZd34UzJ4jyy79QrGjW9gM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783322417; c=relaxed/simple; bh=9ZXUr18b6ICtMwcnfCfQqcoadYON5lGnHDJBPbVufHU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=otZqBNrbyQj8gOvtH5pf2261hfKnD4fIOglLaYlgWdOEcmDtmEHSBwXpJd31EM7CSFWnDMhubmyMzdQaoEuBPGNQ0F/s4xczm5jAyUjGX/wlpRLLPUwu0IXrOvZdRxFL4N7d1UoZWfkx5PivGaUJB7i6dP3Mj2OQ2MkiqcPorBg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=Zl5T4/KD; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="Zl5T4/KD" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-474560436c3so2591973f8f.0 for ; Mon, 06 Jul 2026 00:19:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1783322390; x=1783927190; darn=lists.linux.dev; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=VIt88eh6zWv+oEhKK/Aw514C6mk0Vd1i5LusZK/Ssuc=; b=Zl5T4/KDsgVn9y77bkrN3Vo4LXpucrt0YSk3UxI3dPE6uHG4wr1a0ePCiIQG9BXnN7 tTUJmovfC4OuOdu+X6gBWIDvoM75oOFoBjAR/McjnE29YMltrcxeH9fDy2UYJNIAPC7V YXuO+KmzvpCufmoDgSjvOAuHcISCmJScZo98QgINYZ0lOMJQtUsMGys4sQJa3scFPQ7c 5odf/cb7fWdFzDN/alxmTlCRiCvIzJG0EfbWoHiXSLTvztjW1p3Mh8Z/pojwSCbX77cC XQI6DWIGWKVqchcgGhEpmf9zjRvh3i32HmunrPpuRqPiI+jpkJ4UNf66DgLyCDbtQpQL JoIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783322390; x=1783927190; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VIt88eh6zWv+oEhKK/Aw514C6mk0Vd1i5LusZK/Ssuc=; b=l4QwHpn785BopKZvjuTl5/x23V3nneZew47b0ESvBD172pSJG3j1ZMCTn+BOUH9exC h8DWtbdv31/MRc6S5LoPt3RZuSedCY+8HQ5uNnN9Hg6cNfanCSFfTTpwpwpN+0b/f2Z2 a5hGim2b3JEd0M2IhvNT5fdt70hhb+w5IA4T9oMoear08T7z2aYX9fVXsRy40EoXSHry oDqBdMK4gFQzBlCgIQXDgkmbudRQPglcDTy1eltFKJdtJhqzDkXjxD45UPyxHcL8qu9o qhkKDubSg/Vflv3JBD3PGumuW18jW/9fcaZXX+0yh49Moe7orYoWCX50mhmqo70569J9 M/pg== X-Forwarded-Encrypted: i=1; AHgh+RpXdClaGG4+WacvNdgn4unuP9AST0T70nzOHn/gr8vhU8lDIJHSHwaRMCnrSmC/v3lXZFB4DBT2JYiTpg==@lists.linux.dev X-Gm-Message-State: AOJu0Yx1mOrqkht7RSTovLmNcKBlAZNFY7FyGFeTtipkg2LJsi5ukXUB kcu0/Dj7NUf5xH1t2LftCKva+vK3IvE7pTT6yv2eDjgf6JuoBO2IAtRX225hgGi4cgo= X-Gm-Gg: AfdE7clhRH5BiuOAs+PmT6F/a1a/YI3IcPnoVXctigyWW1vskE8bGWEIWB5N4RQFjK1 EjSwz6QiLbkz9wiPYOtrKID322KASBo4Hdhr9CbzDyfigKtMWOcV5nidT2vFCJkFyTKHFDpF2T6 FFar73F8qXfd0CJWgAzqf2zsFlh/FZmownmqtdiPI6hwz+fTn8VzNYYPQh8Tr3fPuXX6W6LyjrO gl7swdhcc2HYsIeQN+oNuJwzp0UKCmTcWQkx/GBlKHESHTR9t3piB4rCZMJjTw/7dbWwAgnSdL0 2q9w7N359DGMa5jNwX/YDuOMwyj12GB3+FG/OeY8ya+9rmT2iHPbhjrFLWpQnXs3H4YHMxTTyj9 2YxO9thlbF0Hgswo2hIoW2fnmEcXtiHoqe5v29NEYuF4irVVn7ZZhmJDACsitS6AsOdkxoeyadU v+gXJs2LDh0MKiNzGzc7tJhCy7jtXpaT1St5UV1CQjsDFHlsui6HKVsT2IUXGZLzE9sIO5IY4gy ykG X-Received: by 2002:a05:6000:d4f:b0:478:4de8:9b91 with SMTP id ffacd0b85a97d-47aac7d018dmr7577860f8f.41.1783322390409; Mon, 06 Jul 2026 00:19:50 -0700 (PDT) Received: from localhost (p200300f65f47db0426af56a07ec3b32d.dip0.t-ipconnect.de. [2003:f6:5f47:db04:26af:56a0:7ec3:b32d]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-47aa039bcdasm23183058f8f.21.2026.07.06.00.19.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2026 00:19:49 -0700 (PDT) Date: Mon, 6 Jul 2026 09:19:47 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig_=28The_Capable_Hub=29?= To: Chen Wang Cc: linux-pwm@vger.kernel.org, Sven Peter , Janne Grunau , Neal Gompa , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Ray Jui , Scott Branden , Broadcom internal kernel review list , Florian Fainelli , Benson Leung , Guenter Roeck , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Paul Cercueil , Vladimir Zapolskiy , Piotr Wojtaszczyk , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Matthias Brugger , AngeloGioacchino Del Regno , Geert Uytterhoeven , Magnus Damm , Heiko Stuebner , Krzysztof Kozlowski , Peter Griffin , Alim Akhtar , Paul Walmsley , Samuel Holland , Michael Walle , Inochi Amaoto , Orson Zhai , Baolin Wang , Chunyan Zhang , Fabrice Gasnier , Maxime Coquelin , Alexandre Torgue , Chen-Yu Tsai , Jernej Skrabec , Hammer Hsieh , Nobuhiro Iwamatsu , Alexey Charkov , Sean Anderson , Michal Simek , asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, chrome-platform@lists.linux.dev, imx@lists.linux.dev, linux-mips@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-riscv@lists.infradead.org, sophgo@lists.linux.dev, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev Subject: Re: [PATCH v1 4/5] pwm: Unify coding style of of_device_id arrays Message-ID: References: <20de6cd60c2938aad2d21397b92742849418ab1b.1783263835.git.ukleinek@kernel.org> <973f3d6f-6ff4-4685-9c9f-b07987f74d98@linux.dev> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="64vjgbl764osolti" Content-Disposition: inline In-Reply-To: <973f3d6f-6ff4-4685-9c9f-b07987f74d98@linux.dev> --64vjgbl764osolti Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH v1 4/5] pwm: Unify coding style of of_device_id arrays MIME-Version: 1.0 Hello Chen, On Mon, Jul 06, 2026 at 08:33:47AM +0800, Chen Wang wrote: > On 7/5/2026 11:14 PM, Uwe Kleine-K=C3=B6nig (The Capable Hub) wrote: > > - Use a single space in a of_device_id array terminator; A single spa= ce > > after the opening { and before the closing } in non-empty > > initializers; > > - No comma after an array terminator; > > - Also no trailing comma after a named initializer iff the > iff -> if This is actually intended. iff =3D "if and only if", see e.g. https://en.wikipedia.org/wiki/If_and_only_if . > > closing } is on the same line; > >=20 > > Signed-off-by: Uwe Kleine-K=C3=B6nig (The Capable Hub) >=20 > [......] >=20 > > diff --git a/drivers/pwm/pwm-sophgo-sg2042.c b/drivers/pwm/pwm-sophgo-s= g2042.c > > index 7d07b0ca7d29..0b6461172e6a 100644 > > --- a/drivers/pwm/pwm-sophgo-sg2042.c > > +++ b/drivers/pwm/pwm-sophgo-sg2042.c > > @@ -225,11 +225,10 @@ static const struct sg2042_chip_data sg2044_chip_= data =3D { > > static const struct of_device_id sg2042_pwm_ids[] =3D { > > { > > .compatible =3D "sophgo,sg2042-pwm", > > - .data =3D &sg2042_chip_data > > - }, > > - { > > + .data =3D &sg2042_chip_data, > > + }, { > > .compatible =3D "sophgo,sg2044-pwm", > > - .data =3D &sg2044_chip_data > > + .data =3D &sg2044_chip_data, > > }, > > { } > > }; >=20 > Changes to sophgo related files=EF=BC=9A >=20 > Reviewed-by: Chen Wang Thanks Uwe --64vjgbl764osolti Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmpLVxEACgkQj4D7WH0S /k6otAf+MDN98V1OLHB7JSvapxuE4DwDpddJFumdMe3z/vu/P/VdI1oEao4PKhGo 2fMsJUgJT4k/6wIfoB6C3asAQFoEg3UirigbTf0d26+LpcWXfr+MJ/e2tzlX/Yzn 2dH88yKAhOR4HFj73YAi1FscS6vtyPmk7w2A84lWRMvteeY+zJan75O9xwgRC7FX gEMJExnAEBHY9tEW8dgB3EK07MFFQWLlVpGQll6BbLHxOcMIz17Pj/sI6+7Sv0xW cahUhiwZ1m+Y0EElAHIwQFoWyyyg7KINbFYsCsnyL1ev/EbUFyGCMRuR270OEIJW bKMoVE2keTYc8IQjmKqk7x/VPRLsTw== =LX/u -----END PGP SIGNATURE----- --64vjgbl764osolti--