From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy2-f43.google.com (mail-dy2-f43.google.com [74.125.229.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 817E312C534 for ; Sat, 26 Sep 2026 03:48:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.229.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790394537; cv=none; b=IOrfn3eyV16Mlw22uRj8Kqo3/zP/yr/WuYhswZ+yJrqDsyOfBLEqTTxmIL0tEaSK8EGO3wrzxJgqWDI0PGLEexOEoEfV8RyZ2obm7IVi8Deo4IcFgUbBXuptHDtlqF6YE+KGHQVUbjFxxn5keFFg6iydwrreSTF40Flpz5Wk/kg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790394537; c=relaxed/simple; bh=CLrM2wPA9wxnXi7IhEgR7GfVZFShh2FdnM2mC8plLbc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=EZ8RWfaZLKqVZU4B+U9CjoXXCuJw3P6crBD4IkDvHzU/C7NV46AWJua0XMWQHpHxj1lbQmdsTKi5mbB6Jlg6isfLB9BCU8xY08f3gXfc+WDR4eTffK1hAWpm3oGWBVBf3wbdbHSJW1A5E1pSBl5a+YknSCibVn5K+exDW1l5h7A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MU0KPHX4; arc=none smtp.client-ip=74.125.229.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MU0KPHX4" Received: by mail-dy2-f43.google.com with SMTP id 5a478bee46e88-33bfb26865fso1302103eec.2 for ; Fri, 25 Sep 2026 20:48:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790394534; x=1790999334; darn=lists.linux.dev; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=s/TFdpTxMiYwHrmjouP2VwdkJofSRV30LB9rRr0t5Pc=; b=MU0KPHX4z2isUnSrVi5I6u+g9oVnsmpvjLSGQVyuyeQf2esDz1AH6tGyF4MZXT//H6 dsEuRH6rlzpqYIxbyLCb1oc7K3XnimZFpx4Jln2EOZqL3lKLcgAIOszI5/73WYkyPplU pEEYOEnTa7LNAyyf5I8kcMNS2PPtbGfzJIPEmZJMWtumAcpbbaudZrxUmxzu8Zts5i6X +vraqoMhNZ96uo7zWgXOvRoregIgLJNQRK2uciN5+2tt+vQQ7P+0CO2d5S+If/F0G/ey D+LdCLwHW7aTqHL5vLmVUgbSX5aRuVUr8poOKoHs2l9Wv3hvGGldV6z0H7vhMc5Umpp7 kudw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790394534; x=1790999334; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=s/TFdpTxMiYwHrmjouP2VwdkJofSRV30LB9rRr0t5Pc=; b=d3Eu3ZVR4O595V3KpaitaR65e4Dy/FEpAFMXxoVonWjz0jPpylyLGYTlCamXEoHFms B2FditcM+Ils+qsMGSG7PuGS8MPhmbDGuzDSCUOSwlyuXxfGHcRpQVWjzdBQG1n0bCQd xaEO/QZEwgOJWPzwb2BdRHM5uaZk5fHfgZeJVr3z8MTXJmjKF8BG1YRSFp6DB/XweZ40 k8g2xAOTlckBf3bJZaD5yKu5ki9RHeboXjdVhxZ31qL4STaDOP/lBEeUwa0Z+W1Vro+B Sme+jV6ce7n/Zsjb8ohkZjLiTEh6tgTRd1KariBmxXEduSFEzUDSHCQlBoi9SdOcGq46 ARCA== X-Forwarded-Encrypted: i=1; AKwUvByb33DOhnIsReTYt9tfwGfgfgXmBXgGKQ4dEwjzmFGglUBtnFhzl2miLCJJO+RRVArsQus2YoJLoV4wdA==@lists.linux.dev X-Gm-Message-State: AFuF++mp2VtG6HMHRycv4Cse6j+DS6utig90vyPq8eqveSeYbLgC9LaY mYxq/gqgA50KfHDDtVeGLDA94vhSOGHQW/hH+Ub+yV1jmaZKq+q5J92y X-Gm-Gg: AYBFou0S4jkDv6gSUyk+nNApA+whrUlB8ULdlxdjJZFT3UnYpr92U3QcKABTNiajR3i 1OCdK5c406bOSFKjKTfEc1wsZBYwC+wNnn2tHjyepQVvIHiPTrm7xWAr24gVfxjVmRduHS94Nbs NyVeIYdtRn5Hyeo1PIf2tlZAZ69sWz+VInBJDy7MaxIAPAc5p7Q5q8I0+Yz0T91LNqeaGniseZn 0/mFSdOu1TmI0H4aA+tAAftDTv7AE41NseS4v4nKKpsaC/mZShNj/HlZT4xtYc34obajmrYPd+K 3azVwCQaCONvp1jLseiGJHSJlzkEw1AgoMzeL60HYuyKtmjvmK8AWyKlC95cRjjKt32d7nUQlMH ANEhlGSm7FF1H056Uy1tGDW7ruZgpJ7BoBBlTH+n1zLlSPriw/Cn6eVs1zDoOrFzEKOM5MquyRs HhV7GoQQBwOLE7nh2pJmW0SOhKGpdohgyWRhWYQYbHAGz4ikeue0ZwpY40p7NebN4etzJlBAVb5 OqtHI1IOzld2m/2vbfmFlGpN6+oYfGeH3uU04/iZyNhgGl4Bw== X-Received: by 2002:a05:7301:7e04:b0:33b:c122:6bd4 with SMTP id 5a478bee46e88-342701bed7amr1482746eec.6.1790394532963; Fri, 25 Sep 2026 20:48:52 -0700 (PDT) Received: from google.com ([2a00:79e0:2ebe:8:375:19cf:5fee:be32]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3434958c3adsm902665eec.22.2026.09.25.20.48.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Sep 2026 20:48:52 -0700 (PDT) Date: Fri, 25 Sep 2026 20:48:49 -0700 From: Dmitry Torokhov To: Vladimir Cc: Chen-Yu Tsai , Samuel Holland , linux-input@vger.kernel.org, linux-pm@vger.kernel.org, linux-sunxi@lists.linux.dev Subject: Re: [PATCH v2] Input: axp20x-pek - add AXP313a support Message-ID: References: <20260923110741.1880-1-anykey196@gmail.com> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260923110741.1880-1-anykey196@gmail.com> On Wed, Sep 23, 2026 at 04:07:41PM +0500, Vladimir wrote: > The AXP313a MFD driver registers its power button cell as "axp313a-pek", > but the axp20x-pek platform id table only matches "axp20x-pek" and > "axp221-pek". The power button therefore never probes on boards using the > AXP313a PMIC (e.g. the OrangePi Zero 2W). > > Add the missing id table entry. Unlike the other variants the AXP313a has > no PEK key/startup/shutdown registers - AXP20X_PEK_KEY (0x36) lies beyond > its register map (max_register = AXP313A_IRQ_STATE, 0x21) - so give it its > own axp20x_info without start-up/shutdown times and hide the corresponding > sysfs attributes, instead of exposing files that always fail with -EIO. > > Tested on: OrangePi Zero 2W (Allwinner H618 + AXP313a), kernel 7.1.13. > > Signed-off-by: Vladimir While we no longer require legal names on sign-offs we do need a "known identity" and just the first name does not cut. > --- > drivers/input/misc/axp20x-pek.c | 39 ++++++++++++++++++++++++++++++++- > 1 file changed, 38 insertions(+), 1 deletion(-) > > diff --git a/drivers/input/misc/axp20x-pek.c b/drivers/input/misc/axp20x-pek.c > index 24f9e9d893d..b912f13b607 100644 > --- a/drivers/input/misc/axp20x-pek.c > +++ b/drivers/input/misc/axp20x-pek.c > @@ -85,6 +85,16 @@ static const struct axp20x_info axp221_info = { > .shutdown_mask = AXP20X_PEK_SHUTDOWN_MASK, > }; > > +static const struct axp20x_info axp313a_info = { > + /* > + * The AXP313a has no PEK key/startup/shutdown registers: AXP20X_PEK_KEY > + * (0x36) lies beyond the end of its register map (max_register = > + * AXP313A_IRQ_STATE, 0x21). Leaving startup_time/shutdown_time unset > + * keeps the matching sysfs attributes from being created, so they > + * cannot fail with -EIO. > + */ Maybe just say: .startup_time = NULL, /* not supported */ .shutdown_time = NULL, /* not supported */ > +}; > + Thanks. -- Dmitry