From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pz2-f39.google.com (mail-pz2-f39.google.com [74.125.228.39]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5F4F04E1C88 for ; Tue, 29 Sep 2026 21:29:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.228.39 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790717369; cv=none; b=ovi5w2CESwa1Hio6me8bLf8A6PwCGtpV+Sy788F9o5DVdJqdogs7jymvc5ZKuAVshk8/xnJlN64OLz0eW/9M+fVGPMckHoTqvKqnDTP4L3M643CfBhALt882nvVFEba6sXo+7R45vLKie+F/TKZBNQekdVtyKSYpemutcxBtk0M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790717369; c=relaxed/simple; bh=ySN2jKS9dHhRYoH81doQjhzbQkfdJK+9O/ToilcRwv8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=WL1Qt5Pyh6vWugoSOpR3kmS9lN+UMs6SQ9INTDV/vncwYlmnyk5RGpGBbVRcNYz7MeK1ohZ4Gtd0tf6kzmy7GaDltZR6eIeS7NOSU79Lax3ve4zazvgJHMEoLBHsRARW4aNY6NBz3mgfraYZPx45HefH8w6Ngoy8g/pHluSz/Y0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dama.to; spf=none smtp.mailfrom=dama.to; dkim=pass (2048-bit key) header.d=dama-to.20251104.gappssmtp.com header.i=@dama-to.20251104.gappssmtp.com header.b=Ml+9zNBY; arc=none smtp.client-ip=74.125.228.39 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dama.to Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=dama.to Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=dama-to.20251104.gappssmtp.com header.i=@dama-to.20251104.gappssmtp.com header.b="Ml+9zNBY" Received: by mail-pz2-f39.google.com with SMTP id d2e1a72fcca58-88103e47f72so3238455b3a.2 for ; Tue, 29 Sep 2026 14:29:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dama-to.20251104.gappssmtp.com; s=20251104; t=1790717367; x=1791322167; darn=lists.linux.dev; h=in-reply-to:content-disposition:content-type:mime-version :references:mail-followup-to:message-id:subject:cc:to:from:date:from :to:cc:subject:date:message-id:reply-to:content-type; bh=EyT+xHf5qLUoWCtLPqQerMtkJAwK/AAEHgHwEUT5UR4=; b=Ml+9zNBYYg9DiBpfLDD5OdijQm+iGuyQMGBYpErRuXEM/fNhk7A50Rh7vURDy29MYI Gxxe8RjXZq8kiJ9AZqLHYuH1tvj4ClSUisNlNO5aM2IxK89oxpHUJIGxZpugV4+8MZ+e fiO9opr1nnXf3W+5+dXtueU+dzqkVEV1NACxUs1rsph9pDilkBu4hEpYe8gwjNRwG+Nv Iykn0ei8DZ3/b25F2P33E3bI+WtRn1mMu7LX0S+yGBXJLz+7g0ZTvGqnvWgY8ctS4WG7 nxFRkR6/UhJaqfxkBx7ne0Oo4W0yVl712Ekn7+eBjJbvcudOW3avJ2vYiPKzC1IxPcdz CZYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790717367; x=1791322167; h=in-reply-to:content-disposition:content-type:mime-version :references:mail-followup-to:message-id:subject:cc:to:from:date :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=EyT+xHf5qLUoWCtLPqQerMtkJAwK/AAEHgHwEUT5UR4=; b=1JPHLXO0QqGs2TM2auYSoC6Hzmkuviy4xmRR/BZbPVqK29aCDhrlsLL1ENb/+Ryl9g amTmSy3WD+pkZ737mfBOdGPegqKfThS4EXlUw1wpo6EopqMoC1Az85P5vCSby9XCF3qX dgE+Mo9TUwNhA1LCRWnAglK9hUUdF4AQoBA7QWLD1W4JJcL2rx38sOrcnFNFL0cjVtDQ CJIOvb0saCoLaPMgdHxVlm7TcCibWbEsXJy8YsPF49W9pwyEvNQ6JdORYBJfKc8L81fZ +BccuHHu5A3hN61ajgax/tFcy5OxSOw2/ZzYeIyakJ4vCoXtU1C1/qXMrIsdVUH0mU86 hCUw== X-Forwarded-Encrypted: i=1; AKwUvBzwFloK9x3gYOQcW88LZPDSPQrzAgbigT4Qc8rTYgenG97Ni11yUblIGCa4dZ1g9GOzdT/t+Dsq9/Fm9w==@lists.linux.dev X-Gm-Message-State: AFuF++lVtw3ilG2vZf99TFohAFtVyM5M0D1LOJvf+oubh+k8vqnZ6f0g brIqJJ4Uh/doTVdOddtbLcvuFkyxCCsd/6r1mITMakZnlG+3QvQR0f1NgPTQjxzE9og= X-Gm-Gg: AYBFou2nCuh10+EJYT1yjagjCtWmoNRuw0IdUN7AI/+hHaVhR60ubNw3JAINB9Ftf+R tnRQOb6lmfYrHn5PLT+Y7rnmfYb7+ldq7qzzpRZ3fbAbc22AEnujBL094GRIMWc0w/kpu6A928i cpxrYW/qECzVj8eKooyr5gw9C7/r8ajht7G1DUHJNy4ui+UA4dcmY7AO8bRutdYCPyPdr1CpXbR /+4ZbmYZkAtwvFdn+BNTabywD6/lII1lT+4Yxzgp5oGI/KYgyM3cRI+MnqzOWQdAOn4YpAx1T92 oANbYpvFNy5//CmuSR1eR9uR46t4KglKYgsU3Po61FgGm0FJgDxwPMeC/YrB9BplAhBszD94DEM dAk+KQNCYOiPTktydm6MNis0zfEKKoD1TNeGgwlQn0BRfXmZoPCkPm2mXaW8PHth2ec3OUReX27 irhgMnhCoNrMGNOC6U6lKka/4CW8PErG9UwD0BQJqO3Wwunqtf4v6LXc32YifS9dH/RCshkE3EW jMFUj8+2v5L X-Received: by 2002:a05:6a00:4186:b0:881:f5e1:6e7f with SMTP id d2e1a72fcca58-886c48b54bcmr338925b3a.31.1790717366754; Tue, 29 Sep 2026 14:29:26 -0700 (PDT) Received: from localhost ([2a03:2880:2ff:57::]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8868866150bsm495163b3a.3.2026.09.29.14.29.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Sep 2026 14:29:26 -0700 (PDT) Date: Tue, 29 Sep 2026 14:29:25 -0700 From: Joe Damato To: Frank.Li@oss.nxp.com Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Bartosz Golaszewski , Andre Przywara , bui duc phuc , Arnd Bergmann , Kees Cook , Li Youhong , Frank Li , "open list:NETWORKING DRIVERS" , "moderated list:ARM/Allwinner sunXi SoC support" , "open list:ARM/Allwinner sunXi SoC support" , open list , vkoul@kernel.org, imx@lists.linux.dev Subject: Re: [PATCH 1/1] net: allwinner: remove dmaengine_desc_free() Message-ID: Mail-Followup-To: Joe Damato , Frank.Li@oss.nxp.com, Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Bartosz Golaszewski , Andre Przywara , bui duc phuc , Arnd Bergmann , Kees Cook , Li Youhong , Frank Li , "open list:NETWORKING DRIVERS" , "moderated list:ARM/Allwinner sunXi SoC support" , "open list:ARM/Allwinner sunXi SoC support" , open list , vkoul@kernel.org, imx@lists.linux.dev References: <20260929190640.3516766-1-Frank.Li@oss.nxp.com> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260929190640.3516766-1-Frank.Li@oss.nxp.com> On Tue, Sep 29, 2026 at 03:06:36PM -0400, Frank.Li@oss.nxp.com wrote: > From: Frank Li > > dmaengine_desc_free() is designed for DMA_CTRL_REUSE. If DMA_CTRL_REUSE > is not set, dmaengine_desc_free() will return -EPERM. > > if (!dmaengine_desc_test_reuse(desc)) > return -EPERM; > > So calling dmaengine_desc_free() does nothing. > dmaengine_terminate_(a)sync() will free all already allocated descriptors. > > Signed-off-by: Frank Li > --- > drivers/net/ethernet/allwinner/sun4i-emac.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) Reviewed-by: Joe Damato