ARM Sunxi Platform Development
 help / color / mirror / Atom feed
From: "Ryan Walklin" <ryan@testtoast.com>
To: "Jernej Skrabec" <jernej.skrabec@gmail.com>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Chen-Yu Tsai" <wens@csie.org>,
	"Samuel Holland" <samuel@sholland.org>
Cc: "Andre Przywara" <andre.przywara@arm.com>,
	"Chris Morgan" <macroalpha82@gmail.com>,
	"Hironori KIKUCHI" <kikuchan98@gmail.com>,
	"Philippe Simons" <simons.philippe@gmail.com>,
	linux-sunxi@lists.linux.dev, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 5/8] arm64: dts: allwinner: h616: Add TCON nodes to H616 DTSI
Date: Sun, 23 Feb 2025 12:39:43 +1300	[thread overview]
Message-ID: <b1e36d92-552e-45b9-b93b-76f369e1a235@app.fastmail.com> (raw)
In-Reply-To: <1916004.CQOukoFCf9@jernej-laptop>

On Sat, 22 Feb 2025, at 10:45 PM, Jernej Škrabec wrote:
> Dne nedelja, 16. februar 2025 ob 10:27:12 Srednjeevropski standardni 
>> Add TCON nodes for the TOP, and the LCD and TV timing controllers. The
>> timing controllers are compatible with the existing R40 driver.
>> +			resets = <&ccu RST_BUS_TCON_LCD0>, <&ccu RST_BUS_TCON_LCD1>;
>> +			reset-names = "lcd", "lvds";
>
> That's not true, is it? LVDS should be LVDS reset. Check my WIP patch:
> https://github.com/jernejsk/linux-1/commit/8b090dc866d4c4b5b0a1804da021a9f44c67d5f1

Thanks, will correct for next version.

> It turns out that H616 clock driver missed LVDS reset, as it can be 
> seen here:
> https://github.com/jernejsk/linux-1/commit/88bad1a59876f5d385bcd45a363784ed2beec6ae#diff-b340c978bcdbe240f7b99f4d0d96ea130a8acb1a5786a8efbb24d9e7a0b14e53R1084
>
> I also commented on this series:
> https://lore.kernel.org/linux-sunxi/20250213172248.158447-1-macroalpha82@gmail.com/T/#t

Thanks, I will add those in for next version with this patch.

Regards,

Ryan

  reply	other threads:[~2025-02-22 23:40 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-16  9:27 [PATCH 0/8] arm64: dts: allwinner: h616: add LCD timing controller and display engine support Ryan Walklin
2025-02-16  9:27 ` [PATCH 1/8] bus: sun50i: add DE33 compatible string to the DE2 bus driver Ryan Walklin
2025-02-22  9:35   ` Jernej Škrabec
2025-02-22 23:38     ` Ryan Walklin
2025-02-16  9:27 ` [PATCH 2/8] arm64: dts: allwinner: h616: add display engine, bus and mixer nodes Ryan Walklin
2025-02-24 18:00   ` Andre Przywara
2025-02-16  9:27 ` [PATCH 3/8] dt-bindings: allwinner: Add TCON_TOP and TCON_LCD clock/reset defines Ryan Walklin
2025-02-19 23:11   ` Rob Herring (Arm)
2025-02-16  9:27 ` [PATCH 4/8] drm/sun4i: tcon: Add support for R40 LCD Ryan Walklin
2025-02-16  9:27 ` [PATCH 5/8] arm64: dts: allwinner: h616: Add TCON nodes to H616 DTSI Ryan Walklin
2025-02-22  9:45   ` Jernej Škrabec
2025-02-22 23:39     ` Ryan Walklin [this message]
2025-02-16  9:27 ` [PATCH 6/8] arm64: dts: allwinner: h616: add LCD, LVDS and PWM pins Ryan Walklin
2025-02-22  9:48   ` Jernej Škrabec
2025-02-22 23:40     ` Ryan Walklin
2025-02-16  9:27 ` [PATCH 7/8] arm64: dts: allwinner: rg35xx: Enable LCD output Ryan Walklin
2025-02-22  9:46   ` Jernej Škrabec
2025-02-16  9:27 ` [PATCH 8/8] arm64: dts: allwinner: rg35xx: Add GPIO backlight control Ryan Walklin
2025-02-17  8:13   ` Philippe Simons

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b1e36d92-552e-45b9-b93b-76f369e1a235@app.fastmail.com \
    --to=ryan@testtoast.com \
    --cc=andre.przywara@arm.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jernej.skrabec@gmail.com \
    --cc=kikuchan98@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-sunxi@lists.linux.dev \
    --cc=macroalpha82@gmail.com \
    --cc=robh@kernel.org \
    --cc=samuel@sholland.org \
    --cc=simons.philippe@gmail.com \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox