From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Richard Genoud" <richard.genoud@bootlin.com>,
"Uwe Kleine-König" <u.kleine-koenig@baylibre.com>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Chen-Yu Tsai" <wens@csie.org>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
"Samuel Holland" <samuel@sholland.org>,
"Philipp Zabel" <p.zabel@pengutronix.de>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
linux-pwm@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] pwm: sun50i: Add H616 PWM support
Date: Mon, 8 Dec 2025 07:09:16 +0100 [thread overview]
Message-ID: <b5731ee5-8a16-40f1-8418-07c45a97c609@kernel.org> (raw)
In-Reply-To: <20251205100239.1563353-3-richard.genoud@bootlin.com>
On 05/12/2025 11:02, Richard Genoud wrote:
> +static struct platform_driver h616_pwm_driver = {
> + .driver = {
> + .name = "h616-pwm",
> + .of_match_table = h616_pwm_dt_ids,
> + },
> + .probe = h616_pwm_probe,
> +};
> +module_platform_driver(h616_pwm_driver);
> +
> +MODULE_ALIAS("platform:h616-pwm");
You should not need MODULE_ALIAS() in normal cases. If you need it,
usually it means your device ID table is wrong (e.g. misses either
entries or MODULE_DEVICE_TABLE()). MODULE_ALIAS() is not a substitute
for incomplete ID table.
> +MODULE_AUTHOR("Richard Genoud <richard.genoud@bootlin.com>");
> +MODULE_DESCRIPTION("Allwinner H616 PWM driver");
> +MODULE_LICENSE("GPL");
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-12-08 6:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-05 10:02 [PATCH 0/4] Introduce Allwinner H616 PWM controller Richard Genoud
2025-12-05 10:02 ` [PATCH 1/4] dt-bindings: pwm: sunxi: add PWM controller for Allwinner H616 Richard Genoud
2025-12-08 6:52 ` Krzysztof Kozlowski
2025-12-12 7:50 ` Richard GENOUD
2025-12-12 8:25 ` Krzysztof Kozlowski
2025-12-12 8:52 ` Richard GENOUD
2025-12-05 10:02 ` [PATCH 2/4] pwm: sun50i: Add H616 PWM support Richard Genoud
2025-12-06 4:22 ` kernel test robot
2025-12-06 4:32 ` kernel test robot
2025-12-06 14:24 ` kernel test robot
2025-12-08 6:09 ` Krzysztof Kozlowski [this message]
2025-12-05 10:02 ` [PATCH 3/4] arm64: dts: allwinner: h616: add PWM controller Richard Genoud
2025-12-05 10:02 ` [PATCH 4/4] MAINTAINERS: Add entry on Allwinner H616 PWM driver Richard Genoud
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b5731ee5-8a16-40f1-8418-07c45a97c609@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jernej.skrabec@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=p.zabel@pengutronix.de \
--cc=richard.genoud@bootlin.com \
--cc=robh@kernel.org \
--cc=samuel@sholland.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=u.kleine-koenig@baylibre.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox