From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from ssl.serverraum.org (ssl.serverraum.org [176.9.125.105]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0EDB336A for ; Sat, 16 Jul 2022 09:30:22 +0000 (UTC) Received: from ssl.serverraum.org (web.serverraum.org [172.16.0.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ssl.serverraum.org (Postfix) with ESMTPSA id 577BB22239; Sat, 16 Jul 2022 11:30:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2016061301; t=1657963814; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=alWQWqJmW7ZADT7MYc2k0cPnPrjW8BlVpk1tN0F8YTw=; b=sS/BtGpoDtyTxY4EdLTptKbkjwAr0HDroLGkiJzisbXIXU+WH+OkV+4FDIt4WdFSJoO22g 9E6mMeRLFw1DxTw5GQd1lkgHQcBzQdUL5cUV/ek0bJ6l+urZi/zXN/rmJuQnbIcSaNsrtT 5J7MYCx0RTPCSOP+R/0DGqJgt2soMNQ= Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Sat, 16 Jul 2022 11:30:12 +0200 From: Michael Walle To: =?UTF-8?Q?Michal_Such=C3=A1nek?= Cc: Pratyush Yadav , linux-sunxi@lists.linux.dev, Rob Herring , Krzysztof Kozlowski , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Tudor Ambarus , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org Subject: Re: [PATCH 1/2] mtd: spi-nor: When a flash memory is missing do not report an error In-Reply-To: <20220716082027.GK17705@kitsune.suse.cz> References: <701967b0c418db333c66b48d225df60aa9d03ead.1657826188.git.msuchanek@suse.de> <20220714205529.GE17705@kitsune.suse.cz> <33abf7b84860049c4a22605578303ff2@walle.cc> <20220714220744.GF17705@kitsune.suse.cz> <20220715092017.2ftoyzm22i4amrbt@ti.com> <20220716082027.GK17705@kitsune.suse.cz> User-Agent: Roundcube Webmail/1.4.13 Message-ID: X-Sender: michael@walle.cc Am 2022-07-16 10:20, schrieb Michal Suchánek: >> So if DT says there isn't a flash on a specific CS when there is, then >> DT should be fixed to describe the flash, and then we can probe it. >> You >> both seem to be saying the same thing here, and I agree. > > The disagreement is about the situation when there is sometimes a flash > chip. No. The disagreement is what should happen if the DT says there is a device but there isn't. Which right now is an error and it should stay that way. Your hardware description says there is a flash but it cannot be probed, so it is an error. What about a board which has an actual error and the flash isn't responding? You trade one use case for another. Also I've looked at the PHY subsystem and there, if a PHY is described in the DT but isn't there, the following error will be printed: dev_err(&mdio->dev, "MDIO device at address %d is missing.\n", addr); And that is for a bus which can even be automatically be probed/detected. -michael